Redmine

2023-11-19

12:05 Defect #39437 (Resolved): MySQL / MariaDB issue nested set deadlocks and consistency

Go MAEDA wrote in #note-12:
> Marius BALTEANU wrote in #note-8:
> > I would like to commit the fixes next week, but... Marius BĂLTEANU

08:13 Defect #39437: MySQL / MariaDB issue nested set deadlocks and consistency

Marius BALTEANU wrote in #note-8:
> I would like to commit the fixes next week, but I'm not sure if we can deliver t... Go MAEDA

12:02 Revision 22467 (svn): Merged r22458, r22459, r22460, r22461, r22462 and r22464 from trunk to 5.1-stable (#39437).

Marius BĂLTEANU

08:42 Defect #39527 (Closed): Deprecate unused ApplicationHelper#render_if_exist

Committed the patch in r22466. Thank you for pointing out this issue. Go MAEDA

08:41 Revision 22466 (svn): Deprecate unused ApplicationHelper#render_if_exist (#39527).

Go MAEDA

08:30 Revision 22465 (svn): Fix typo in test names in application_helper_test.rb: Change "redner" to "render" (#39527).

Go MAEDA

08:10 Revision 22464 (svn): Use tx_isolation for MySQL lower than 8. (#39437).

Marius BĂLTEANU

07:55 Feature #39579: Drop official support for MySQL 5.5, 5.6 and 5.7

I have no objection to ending support for older versions of MySQL, but I don't think it is necessary to display such ... Go MAEDA

06:37 Defect #39576 (Closed): `rake yard` does not work with Ruby >= 3.2

Go MAEDA

06:36 Revision 22463 (svn): Merged r22456 from trunk to 5.1-stable (#39576).

Go MAEDA

2023-11-18

23:57 Feature #39579 (Closed): Drop official support for MySQL 5.5, 5.6 and 5.7

In Redmine version:6.0.0, we should display a warning during boot or on the Administration page if Redmine is using a... Marius BĂLTEANU

23:47 Defect #39437: MySQL / MariaDB issue nested set deadlocks and consistency

Both patches committed, including the test for concurrent subtask removal, I think it's importat to cover this case a... Marius BĂLTEANU

23:30 Revision 22462 (svn): Workaround to use READ-COMMITTED as transaction_isolation level when running the concurrency tests in MySQL. (#39437).

Marius BĂLTEANU

23:27 Revision 22461 (svn): Add concurrent subtask removal test to cover corrupted nested sets (#39437).

Patch by Jens Krämer. Marius BĂLTEANU

17:36 Revision 22460 (svn): Revert undesired change (#22458).

Marius BĂLTEANU

15:40 Revision 22459 (svn): Moves create parent issue journal to after_commit hook to work around stale object errors on concurrency (#39437).

Patch by Jens Krämer. Marius BĂLTEANU

15:39 Revision 22458 (svn): Use a global lock provided by @with_advisory_lock@ gem to work around deadlock issues when MySQL >= 5.7 (#39437).

Patch by Jens Krämer. Marius BĂLTEANU

13:58 Patch #39558 (Closed): Remove deprecated methods in Repository and AbstractAdapter

Committed, thanks! Marius BĂLTEANU

13:58 Revision 22457 (svn): Remove deprecated methods in Repository and AbstractAdapter (#39558).

Patch by Go MAEDA. Marius BĂLTEANU

13:55 Defect #39578 (Closed): User shenllredmine created a strange empty Wiki page and a strange Issue (probably SPAM)

Thanks, I locked the user and I deleted the wiki page and the issue. Marius BĂLTEANU

12:25 Defect #39578 (Closed): User shenllredmine created a strange empty Wiki page and a strange Issue (probably SPAM)

"shenll tech":https://www.redmine.org/users/685864 user was created and this user was used immediately to create a st... Alex Chernyakevich

05:19 Defect #39576 (Resolved): `rake yard` does not work with Ruby >= 3.2

Committed the patch in r22456. Go MAEDA

03:22 Defect #39576: `rake yard` does not work with Ruby >= 3.2

The following change fixes the issue.
The cause of this issue is that the current code creates a nested array by a... Go MAEDA

01:33 Defect #39576 (Closed): `rake yard` does not work with Ruby >= 3.2

`rake yard` which generates YARD documentation raises an exception and exits immediately after startup if the Ruby ve... Go MAEDA

05:18 Revision 22456 (svn): Fix `rake yard` does not work with Ruby >= 3.2 due to nested array issue (#39576).

Patch by Go MAEDA. Go MAEDA

01:11 Feature #20620: Add data-text-formatting attribute for selected markup language to body tag

Setting the target version to 6.0.0. Go MAEDA

2023-11-17

15:56 Defect #39559 (New): Git commit linking to issue and time entry

Git commit - time log and issue link
After *committing* in git repo, which is added as Repository in Redmine proj... Mika Mitrovic

14:42 Feature #20620: Add data-text-formatting attribute for selected markup language to body tag

Thank you. I think this should also be helpful for our use-case.
We look forward to this being added to core Redmine. Felix Schäfer

02:03 Feature #20620: Add data-text-formatting attribute for selected markup language to body tag

Here is a patch to introduce a @data-text-formatting@ attribute to the @<body>@ tag. Go MAEDA

10:55 Patch #39558 (Closed): Remove deprecated methods in Repository and AbstractAdapter

The attached patch removes deprecated @Repository#supports_all_revisions?@, @AbstractAdapter#with_trailling_slash@, a... Go MAEDA

08:46 Defect #1175: Empty diff page for binary files

Peter Kövesdi wrote in #note-7:
> Even worse: the changes in binary files are not even mentioned when comparing the ... Peter Kövesdi

08:31 Defect #39553 (Closed): Mention notification is not sent (MENTION_PATTERN / LINKS_RE inconsistency)

Fixes merged to stable branches, sorry for the noise with the commits. Marius BĂLTEANU

08:30 Revision 22455 (svn): Merged r22445, r22449 and r22450 from trunk to 5.0-stable (#39553).

Marius BĂLTEANU

08:30 Revision 22454 (svn): Merged r22445, r22449 and r22450 from trunk to 5.1-stable (#39553).

Marius BĂLTEANU

07:54 Revision 22453 (svn): Add missing fixture file intended for r22440 (#39511).

Go MAEDA

07:38 Patch #39547 (Closed): Prevent automatic requiring of unnecessary gems at runtime

Committed the patch in r22452. Go MAEDA

07:38 Revision 22452 (svn): Prevent auto requiring of 'yard' gem (#39547).

Go MAEDA

06:14 Feature #36320: Migrate to Rails 7.2

Takashi Kato wrote in #note-7:
> I've updated a patch that is compatible with Rails 7.1 beta. As for the WebDriver pa... Minoru Maeda

04:35 Feature #36320: Migrate to Rails 7.2

Not a bad effort there user#486714, I gave your patch a quick go with Rails 7.1 and it seemed to work with standard R... M T

05:24 Revision 22451 (svn): Disable RuboCop warning for intentional comma in percent string array (#39553).

Go MAEDA