Feature #1725

Delete button on comments

Added by Derek Montgomery almost 5 years ago. Updated 4 months ago.

Status:NewStart date:2008-07-31
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Issues
Target version:-
Resolution:

Description

I know people with rights can just remove all content of a comment to get rid of it but it is not as "evident" as a delete icon, especially when quote and edit icons are present.

add_a_delete_link_to_journal_entries.patch Magnifier - Adds a delete button to issue journal entries (968 Bytes) Felix Schäfer, 2010-07-07 20:00

Related issues

Related to Feature #1665: Ability to delete tracker comments Resolved 2008-07-20
Related to Patch #7610: Patch providing issue journal rollback New 2011-02-11
Duplicated by Feature #11255: Add delete button for comment Closed

History

#1 Updated by Felix Schäfer almost 3 years ago

  • Assignee set to Felix Schäfer

I've been wondering about this too, will have a look at it and see how quickly feasible it is.

#2 Updated by Felix Schäfer almost 3 years ago

The supplied patch adds a delete button to an issue's journal entries, only for users with the right to edit the journal entry.

#3 Updated by Eric Davis almost 3 years ago

  • Status changed from Resolved to 7

#4 Updated by Eric Davis almost 3 years ago

  • Assignee changed from Felix Schäfer to Eric Davis
  • Target version deleted (1.0.1)

There is a problem with this patch. Journals are only deleted if:

  1. The notes are empty and
  2. The details are empty

All this patch does is to clear the notes. If a Journal had details, it wouldn't be deleted. There are two options we can do here:

  1. Add a new action to really delete a Journal and provide a link to it, or
  2. Change this icon so it's clear that it only clears the note.

I've added Holger to this issue, I know he has an opinion about deleting things like Journals and I would like to hear what he thinks.

#5 Updated by Felix Schäfer over 2 years ago

The scope of the patch wasn't to delete journals but the notes attached to it, which is currently possible to if you edit the notes to an empty string. The current functions quote and edit only work on the notes too, so I don't think that would be that misleading.

#6 Updated by Eric Davis over 2 years ago

Maybe the title attribute should say "Delete notes" then. What do you think?

#7 Updated by Felix Schäfer over 2 years ago

  • Assignee changed from Eric Davis to Felix Schäfer

Can do that, I'll change the other titles (edit and quote) too to reflect that if it's ok with you?

#8 Updated by Felix Schäfer over 2 years ago

  • Assignee changed from Felix Schäfer to Eric Davis

Eric, I slightly reworked the patch to have the title say "Delete notes", the confirmation pop-up now also states that the changes to the issue will not be reverted if the journal details are not empty.

See http://github.com/thegcat/redmine/commit/5be3c6e9b405bf03ad69226e8235e3d6618adbf5 for the change.

#9 Updated by Eric Davis over 2 years ago

  • Assignee deleted (Eric Davis)

#10 Updated by Brian Lindahl over 2 years ago

created a related patch for rolling back journal entries #7610

This rolls back the changes made to the issue as well as removing the journal entry. Note that this capability is only enabled for the last journal entry (for obvious reasons).

#11 Updated by rm user 11 months ago

another 4 years issue.. :(

#12 Updated by Jean-Philippe Lang 4 months ago

  • Status changed from 7 to New

Assigned issue with no assignee back to New status.

Also available in: Atom PDF