Feature #1725

Delete button on comments

Added by Derek Montgomery over 9 years ago. Updated almost 2 years ago.

Status:ClosedStart date:2008-07-31
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Issues
Target version:3.3.0
Resolution:Fixed

Description

I know people with rights can just remove all content of a comment to get rid of it but it is not as "evident" as a delete icon, especially when quote and edit icons are present.

add_a_delete_link_to_journal_entries.patch Magnifier - Adds a delete button to issue journal entries (968 Bytes) Felix Schäfer, 2010-07-07 20:00

delete-note.png - screenshot (47.3 KB) Go MAEDA, 2016-01-17 16:24

add_a_delete_link_to_journal_entries_v2.patch Magnifier - patch against 3.2.0.devel.15067 (1.67 KB) Go MAEDA, 2016-01-17 16:25


Related issues

Related to Redmine - Feature #1665: Ability to delete tracker comments Resolved 2008-07-20
Related to Redmine - Patch #7610: Patch providing issue journal rollback New 2011-02-11
Duplicated by Redmine - Feature #11255: Add delete button for comment Closed

Associated revisions

Revision 15072
Added by Jean-Philippe Lang almost 2 years ago

Adds a "Delete" button to issue notes (#1725).

History

#1 Updated by Felix Schäfer over 7 years ago

  • Assignee set to Felix Schäfer

I've been wondering about this too, will have a look at it and see how quickly feasible it is.

#2 Updated by Felix Schäfer over 7 years ago

The supplied patch adds a delete button to an issue's journal entries, only for users with the right to edit the journal entry.

#3 Updated by Eric Davis over 7 years ago

  • Status changed from Resolved to 7

#4 Updated by Eric Davis over 7 years ago

  • Assignee changed from Felix Schäfer to Eric Davis
  • Target version deleted (1.0.1)

There is a problem with this patch. Journals are only deleted if:

  1. The notes are empty and
  2. The details are empty

All this patch does is to clear the notes. If a Journal had details, it wouldn't be deleted. There are two options we can do here:

  1. Add a new action to really delete a Journal and provide a link to it, or
  2. Change this icon so it's clear that it only clears the note.

I've added Holger to this issue, I know he has an opinion about deleting things like Journals and I would like to hear what he thinks.

#5 Updated by Felix Schäfer about 7 years ago

The scope of the patch wasn't to delete journals but the notes attached to it, which is currently possible to if you edit the notes to an empty string. The current functions quote and edit only work on the notes too, so I don't think that would be that misleading.

#6 Updated by Eric Davis about 7 years ago

Maybe the title attribute should say "Delete notes" then. What do you think?

#7 Updated by Felix Schäfer about 7 years ago

  • Assignee changed from Eric Davis to Felix Schäfer

Can do that, I'll change the other titles (edit and quote) too to reflect that if it's ok with you?

#8 Updated by Felix Schäfer about 7 years ago

  • Assignee changed from Felix Schäfer to Eric Davis

Eric, I slightly reworked the patch to have the title say "Delete notes", the confirmation pop-up now also states that the changes to the issue will not be reverted if the journal details are not empty.

See http://github.com/thegcat/redmine/commit/5be3c6e9b405bf03ad69226e8235e3d6618adbf5 for the change.

#9 Updated by Eric Davis about 7 years ago

  • Assignee deleted (Eric Davis)

#10 Updated by Brian Lindahl almost 7 years ago

created a related patch for rolling back journal entries #7610

This rolls back the changes made to the issue as well as removing the journal entry. Note that this capability is only enabled for the last journal entry (for obvious reasons).

#11 Updated by rm user over 5 years ago

another 4 years issue.. :(

#12 Updated by Jean-Philippe Lang almost 5 years ago

  • Status changed from 7 to New

Assigned issue with no assignee back to New status.

#14 Updated by Terry Cullen over 3 years ago

+1

#15 Updated by rm user over 3 years ago

what's up with this? (5 years old and counting...)

i managed to delete WHOLE issue instead of the single comment.. :(

#16 Updated by Go MAEDA almost 2 years ago

Updated patch for 3.2.0.devel.15067.

The procedure to delete note is a little bit difficult to understand. This change improve usability. In addition, we can avoid accidental deletion of a issue by clicking delete button under a latest note.

Please include this feature in Redmine 3.3.0.

screenshot

#17 Updated by Jean-Philippe Lang almost 2 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed
Feature added in r15072.
I made slight changes to the patch:
  • removed image_tag regarding #21256
  • use of existing confirmation message
  • AJAX call (similar to how the journal edit works)

Thanks.

#18 Updated by rm user almost 2 years ago

wow! 7years old issue is finally solved!

big up Jean-Philippe and Go MAEDA!

what about permissions btw? is there a permission where user can delete only his own comments on issues?

#19 Updated by Jean-Philippe Lang almost 2 years ago

rm user wrote:

what about permissions btw? is there a permission where user can delete only his own comments on issues?

As noted above, users with "edit notes" or "edit own notes" were already able to delete notes by making them empty. The delete button is just some kind of shortcut for doing this. The permissions are the same, so the answer is yes, you can allow users to edit/delete only their own notes.

Also available in: Atom PDF