Feature #2222

Single section edit.

Added by Leonid Myravyev almost 9 years ago. Updated almost 6 years ago.

Status:ClosedStart date:2008-11-21
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

100%

Category:Wiki
Target version:1.3.0
Resolution:Fixed

Description

Hi, folks!
Wiki don't have feature to edit single section on page. (see mediawiki)
I think it maybe good.
Thanks.

Screenshot-Redmine.jpg (83.8 KB) Manuel Studer, 2009-06-04 13:40

wiki_section_edit-v0-9.patch Magnifier - Wiki section edit patch (13.5 KB) Manuel Studer, 2009-06-10 10:46

redmine-0.9-r3357-wiki_section-v1.patch Magnifier - Wiki section edit patch for redmine 0.9 trunk r3357. (13.5 KB) Manuel Studer, 2010-02-01 15:43

redmine-0.9-r3357-wiki_section-v1-1.patch Magnifier - Wiki section edit patch v1.1 for redmine 0.9 trunk r3357. (13.5 KB) Manuel Studer, 2010-02-01 15:53


Related issues

Related to Redmine - Defect #9673: Angle brackets within 'pre' blocks are silently replaced ... Closed 2011-11-28
Related to Redmine - Defect #10199: No wiki section edit when title contains code Closed

Associated revisions

Revision 7829
Added by Jean-Philippe Lang about 6 years ago

Wiki: allows single section edit (#2222).

Revision 7830
Added by Jean-Philippe Lang about 6 years ago

Do not show section edit links for wiki page history (#2222).

Revision 7831
Added by Jean-Philippe Lang about 6 years ago

Handle the case of a text formatter that doesn't support section edit (#2222).

Revision 7835
Added by Jean-Philippe Lang about 6 years ago

Fixes section edit links when text includes pre/code tag (#2222).

History

#1 Updated by Richard Pecl almost 9 years ago

+1

#2 Updated by Michael Aye almost 9 years ago

+1

#3 Updated by Zbyszek Szmek almost 9 years ago

+1

#5 Updated by Jone Marius Vignes almost 9 years ago

+1 This would be very nice

#6 Updated by Juan Pablo Saraceno over 8 years ago

+1 I believe this is the only detail on which Redmine's wiki doesn't beat mediawiki

#7 Updated by kju kju over 8 years ago

+1

Editing large wiki pages is cumbersome without.
Would be a great addition!

#8 Updated by Alain D. over 8 years ago

+1 when maintaining a document (let's say a scope statement) in the redmine wiki, if it begins to be big, we have to split it in different pages (as it's really hard to find where to do the edits), but nor the include macro nor the child_pages are sufficient to offer a one page view of this document (the toc doesn't cover the included pages sections)

The ideal solution would be to keep this document in a single page, but to be able to edit only parts of it (as does many existing wiki platforms)

#9 Updated by Manuel Studer over 8 years ago

  • % Done changed from 0 to 80

Hi folks. I've implemented this feature for the stable release v.0.8 and we are going to test this in the following two weeks. So stay tuned. ;)

#10 Updated by Manuel Studer over 8 years ago

Manuel Studer wrote:

Hi folks. I've implemented this feature for the stable release v. 0.8 and we are going to test this in the following two weeks. So stay tuned. ;)

#11 Updated by Manuel Studer over 8 years ago

I'm going to release the modification as a patch within the next days. I used Nokogiri for HTML parsing, so you'll need to install it.

And it works nice so far. Check out the screenshot.

#12 Updated by Manuel Studer over 8 years ago

Hi folks,

Here is the first release for Redmine 0.8. As I said, you need Nokogiri. On a RHEL or Centos System you can install Nokogiri like the following:

sudo yum install libxml2 libxml2-devel libxslt libxslt-devel
sudo gem install nokogiri

Then install the patch:

patch -p0 < wiki_section_edit-v0-9.patch

Let me know if it works for you.

Cheers,
Manuel

If you want to remove the patch:

patch -p0 -R < wiki_section_edit-v0-9.patch

#13 Updated by Leonid Myravyev over 8 years ago

Thanks!

But rubyforge.org is down :-(

#14 Updated by Leonid Myravyev over 8 years ago

It work!
Thank you very much. :-)

#15 Updated by Ben Oakes about 8 years ago

+1

Is this in version 0.8 now? If not, it'd be nice to have still.

#16 Updated by Ben Oakes about 8 years ago

Ben Oakes wrote:

+1

Is this in version 0.8 now? If not, it'd be nice to have still.

By the way, we're on Redmine 0.8.4.stable.2819 (MySQL) and I don't see it.

#17 Updated by Shahim Essaid almost 8 years ago

  • % Done changed from 100 to 50

+1

It would be great if you could updated this patch or add it to trunk.

I tried applying this patch to trunk #1329 and it failed. I applied it manually but this lead to exceptions. I am not a Ruby/Rails programmer and I couldn't figure out the problem.

#18 Updated by Manuel Studer almost 8 years ago

Leonid Myravyev wrote:

Hi, folks!
Wiki don't have feature to edit single section on page. (see mediawiki)
I think it maybe good.
Thanks.

Here is the updated patch for trunk r3357. Let me know if it works for you.

#19 Updated by Manuel Studer almost 8 years ago

Manuel Studer wrote:

Leonid Myravyev wrote:

Hi, folks!
Wiki don't have feature to edit single section on page. (see mediawiki)
I think it maybe good.
Thanks.

Here is the updated patch for trunk r3357. Let me know if it works for you.

Oops, there was a small bug in version 1. This is now the corrected version 1.1.

#20 Updated by Alexis Lahouze over 7 years ago

I think this feature is necessary for collaborative work on the wiki. This would avoid many problems when users are working on the same part of the project, and edit the same page at the same moment.

So:

while(true) {
    echo "+1";
}

:)

#21 Updated by Ben Oakes over 7 years ago

Nice. +1 to your +1. :)

Alexis Lahouze wrote:

I think this feature is necessary for collaborative work on the wiki. This would avoid many problems when users are working on the same part of the project, and edit the same page at the same moment.

So:

while(true) {
    echo "+1";
}

:)

#22 Updated by Fredrik Norén over 7 years ago

+1

The patch doesn't seem to work with 1.0 (r3858) though, getting the following error:

patching file app/helpers/wiki_helper.rb
patching file app/helpers/application_helper.rb
Hunk #1 FAILED at 402.
1 out of 1 hunk FAILED -- saving rejects to file app/helpers/application_helper.rb.rej
patching file app/controllers/application_controller.rb
patching file app/controllers/wiki_controller.rb
Hunk #1 FAILED at 61.
Hunk #2 succeeded at 245 (offset 11 lines).
1 out of 2 hunks FAILED -- saving rejects to file app/controllers/wiki_controller.rb.rej
patching file app/views/wiki/edit.rhtml
Hunk #1 succeeded at 2 with fuzz 2.
patching file public/stylesheets/application.css
Hunk #1 succeeded at 724 (offset 54 lines).
Hunk #2 succeeded at 764 (offset 54 lines).

#23 Updated by Etienne Massip over 6 years ago

  • Target version set to Candidate for next major release

That would be very useful, indeed.

#24 Updated by Terence Mill over 6 years ago

+1

#25 Updated by Anonymous over 6 years ago

+1

#27 Updated by Terence Mill over 6 years ago

Very useful! PLease include into 1.3

#28 Updated by Oli Kessler about 6 years ago

+1

#30 Updated by Jean-Philippe Lang about 6 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Target version changed from Candidate for next major release to 1.3.0
  • % Done changed from 50 to 100
  • Resolution set to Fixed

Feature added in r7829. It also allows multiple users to edit different sections at the same time if they don't conflict.

#31 Updated by Etienne Massip about 6 years ago

  • Status changed from Closed to Reopened
Found a glitch:
  • if a section contains
    @WHATEVER@
    , the next section won't be editable
  • when editing a section, there is no way to go back to the page
  • as a personnal POV, that would be nice to be able to edit the section "inline", meaning staying in the wiki page and being able to see the whole page contents, like for issue comment editing

Very nice work, though!

#32 Updated by Jean-Philippe Lang about 6 years ago

  • Status changed from Reopened to Closed

Etienne Massip wrote:

Found a glitch:
  • if a section contains [...], the next section won't be editable

Fixed in r7835.

  • when editing a section, there is no way to go back to the page

You mean a Cancel link to go back to the page?

  • as a personnal POV, that would be nice to be able to edit the section "inline", meaning staying in the wiki page and being able to see the whole page contents, like for issue comment editing

I dit it the Wikipedia way but there's certainly room for improvement :-)

Thanks for the feedback.

#33 Updated by Etienne Massip about 6 years ago

Jean-Philippe Lang wrote:

You mean a Cancel link to go back to the page?

Yes, the global idea is that SSE is useful to speed up page editing in focusing on a specific section, so if you change your mind you may want to be right back to the location you were previously in the page.

I dit it the Wikipedia way but there's certainly room for improvement :-)

That's a very appreciated feature =)(with a cancel button), I'll wait for other peopple feedback =)

#34 Updated by Etienne Massip almost 6 years ago

  • Status changed from Closed to Reopened

Not confirmed, but could be broken according to Mischa's #9673.

#35 Updated by Jean-Philippe Lang almost 6 years ago

  • Status changed from Reopened to Closed

Now fixed.

Also available in: Atom PDF