Patch #22575

Enable updating private_notes property on journal edit form

Added by Takenori TAKAKI over 1 year ago. Updated over 1 year ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Issues
Target version:-

Description

In current versions of Redmine, users can set 'private' flag when they add new notes, but they don't have any way of updating the flag of existing notes.
I have made the patch, enable to updating `private_notes` property on journal update form.

patch: enable_to_update_private_notes_trunk_r15336.patch

updating_private_notes.jpg (65.7 KB) Takenori TAKAKI, 2016-04-18 03:39

enable_to_update_private_notes_trunk_r15336.patch Magnifier (5.03 KB) Takenori TAKAKI, 2016-04-18 03:41

enable_to_update_private_notes_trunk_r15361.patch Magnifier (5.57 KB) Takenori TAKAKI, 2016-04-28 10:12

cannot-set-private-to-public.mp4 (120 KB) Go MAEDA, 2016-04-30 03:14

enable_to_update_journal_notes_private_or_public_trunk_r15361.patch Magnifier (5.61 KB) Takenori TAKAKI, 2016-05-02 03:28


Related issues

Duplicates Redmine - Feature #12706: Ability to change the private flag when editing a note Closed

Associated revisions

Revision 15620
Added by Jean-Philippe Lang over 1 year ago

Enable updating private_notes property on journal edit form (#22575).

Patch by Takenori TAKAKI.

Revision 15621
Added by Jean-Philippe Lang over 1 year ago

Wrap journal attributes with a journal parameter and use safe_attributes (#22575).

Revision 15622
Added by Jean-Philippe Lang over 1 year ago

Code cleanup (#22575).

Revision 15623
Added by Jean-Philippe Lang over 1 year ago

Renames #render_private_notes to #render_private_notes_indicator (#22575).

History

#1 Updated by Go MAEDA over 1 year ago

  • Category set to Issues

#2 Updated by Go MAEDA over 1 year ago

Interesting feature. But I think "Set notes as private" permission should be checked in JournalsController when updating "private" flag.

#3 Updated by Takenori TAKAKI over 1 year ago

Go MAEDA wrote:

Interesting feature. But I think "Set notes as private" permission should be checked in JournalsController when updating "private" flag.

Thank you for pointing out the not implemented of permission-check.
I added the permission-check, and re-created the patch.
(Compatible the latest trunk r15361)

#4 Updated by Wim DePreter over 1 year ago

+1, and duplicated by #12706

#5 Updated by Go MAEDA over 1 year ago

Thanks for submitting a new patch. I confirmed that permissions are properly checked when updating the flag.

But I am having some trouble setting private note to public. I cleared "Private notes" check box and saved it, but the note still remains in private. Please see the attached video: cannot-set-private-to-public.mp4

#6 Updated by Takenori TAKAKI over 1 year ago

Go MAEDA wrote:

But I am having some trouble setting private note to public. I cleared "Private notes" check box and saved it, but the note still remains in private. Please see the attached video: cannot-set-private-to-public.mp4

Thank you for pointing out my patch's bug. I confirmed same trouble on my environment too...
I Fix the bug, and re-created the patch. Could you please try again the new patch?

#7 Updated by Go MAEDA over 1 year ago

Takenori TAKAKI wrote:

I Fix the bug, and re-created the patch. Could you please try again the new patch?

Works fine. Thanks!

#8 Updated by Go MAEDA over 1 year ago

  • Duplicates Feature #12706: Ability to change the private flag when editing a note added

#9 Updated by Go MAEDA over 1 year ago

  • Target version set to 3.4.0

It looks good to me. Setting target version to 3.4.0.

#10 Updated by Jean-Philippe Lang over 1 year ago

  • Status changed from New to Closed

#11 Updated by Jean-Philippe Lang over 1 year ago

  • Assignee set to Jean-Philippe Lang
  • Target version deleted (3.4.0)

Thanks for the patch. I've made a few changes after that.
Removing it from 3.4.0 as the feature is tracked in #12706.

Also available in: Atom PDF