Feature #22978

Links to issue notes should highlight the linked note

Added by Robert Pollak over 1 year ago. Updated 5 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:UI
Target version:4.0.0
Resolution:Fixed

Description

When I follow e.g. the link #4806#note-9, the issue page opens without any indication where the linked note is: The web browser cannot scroll it to the top, because it is one of the last notes.

It would be very helpful to have the linked note visually emphasized it this case, e.g. by using a lightly colored background.

click_the_link.gif (318 KB) Mizuki ISHIKAWA, 2017-06-28 04:04

highlight_the_linked_note.patch Magnifier (525 Bytes) Mizuki ISHIKAWA, 2017-06-28 04:05

highlight_the_linked_note-v2.patch Magnifier (555 Bytes) Go MAEDA, 2017-06-28 09:30

highlight_the_linked_note-v3.patch Magnifier (1.14 KB) Mizuki ISHIKAWA, 2017-06-29 04:56

Associated revisions

Revision 16776
Added by Jean-Philippe Lang 5 months ago

Note URLs should highlight the linked note (#22978).

Patch by Mizuki ISHIKAWA.

Revision 16777
Added by Jean-Philippe Lang 5 months ago

Change highlight settings (#22978).

Revision 16912
Added by Jean-Philippe Lang 5 months ago

Use CSS to highlight the journal title (#22978).

Revision 16914
Added by Jean-Philippe Lang 5 months ago

Removes unused class (#22978).

History

#1 Updated by Toshi MARUYAMA over 1 year ago

  • Description updated (diff)

#2 Updated by Mizuki ISHIKAWA 6 months ago

I wrote a patch to implement this feature.
Please see the attached gif animation: click_the_link.gif

#3 Updated by Go MAEDA 6 months ago

  • Target version set to Candidate for next major release

I am sure this feature can improve UX. Discourse (open source discussion board software) has similar feature. You can try highlight feature of Discourse by clicking https://meta.discourse.org/t/educate-users-about-paragraphs/65220/9 .

The patch from Mizuki Ishikawa looks good to me but I think it is safer to change the patch as follows:

--- highlight_the_linked_note.patch.org    2017-06-28 13:44:46.000000000 +0900
+++ highlight_the_linked_note.patch    2017-06-28 13:45:00.000000000 +0900
@@ -12,7 +12,7 @@
 +  $(window).on('load hashchange',function(){
 +    var hash = location.hash;
 +    if (hash){
-+      $('div' + hash).css('background-color', '#ffffdd').animate({backgroundColor: ''}, 2000);
++      $('#history div' + hash).css('background-color', '#ffffdd').animate({backgroundColor: ''}, 2000);
 +    }
 +  });
 +});

#4 Updated by Robert Schneider 6 months ago

+1 Nice improvement!

#5 Updated by Go MAEDA 6 months ago

I slightly changed the patch. The new patch checks if the format of the fragment identifier is "#change-nnn" or "#note-nnn".

#6 Updated by Mizuki ISHIKAWA 6 months ago

Updated my patch. Replaced a color value with a CSS class in the view.

#7 Updated by Mischa The Evil 6 months ago

  • Target version changed from Candidate for next major release to 4.1.0

#8 Updated by Yuuki NARA 5 months ago

+1

#9 Updated by Jean-Philippe Lang 5 months ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Committed, thanks. I've made the transition a bit longer and changed the color.

#10 Updated by Jean-Philippe Lang 5 months ago

  • Subject changed from Note URLs should highlight the linked note to Links to issue notes should highlight the linked note

#11 Updated by Jean-Philippe Lang 5 months ago

  • Target version changed from 4.1.0 to 4.0.0

#12 Updated by Robert Pollak 5 months ago

Thanks to everyone involved!

Also available in: Atom PDF