Feature #22978: Links to issue notes should highlight the linked note - Redmine

Feature #22978

Links to issue notes should highlight the linked note

Added by Robert Pollak about 1 year ago. Updated about 1 month ago.

Status:

Closed

Start date:

Priority:

Normal

Due date:

Assignee:

Jean-Philippe Lang

% Done:

Category:

Target version:

4.0.0

Resolution:

Fixed

Description

When I follow e.g. the link #4806#note-9, the issue page opens without any indication where the linked note is: The web browser cannot scroll it to the top, because it is one of the last notes.

It would be very helpful to have the linked note visually emphasized it this case, e.g. by using a lightly colored background.

click_the_link.gif (318 KB) Mizuki ISHIKAWA, 2017-06-28 04:04

highlight_the_linked_note.patch (525 Bytes) Mizuki ISHIKAWA, 2017-06-28 04:05

highlight_the_linked_note-v2.patch (555 Bytes) Go MAEDA, 2017-06-28 09:30

highlight_the_linked_note-v3.patch (1.14 KB) Mizuki ISHIKAWA, 2017-06-29 04:56

Associated revisions

Revision 16776
Added by Jean-Philippe Lang about 1 month ago

Note URLs should highlight the linked note (#22978).

Patch by Mizuki ISHIKAWA.

Revision 16777
Added by Jean-Philippe Lang about 1 month ago

Change highlight settings (#22978).

Revision 16912
Added by Jean-Philippe Lang 18 days ago

Use CSS to highlight the journal title (#22978).

Revision 16914
Added by Jean-Philippe Lang 18 days ago

Removes unused class (#22978).

History

#1 Updated by Toshi MARUYAMA about 1 year ago

Description updated (diff)

#2 Updated by Mizuki ISHIKAWA about 1 month ago

File click_the_link.gif added
File highlight_the_linked_note.patch added

I wrote a patch to implement this feature.
Please see the attached gif animation: click_the_link.gif

#3 Updated by Go MAEDA about 1 month ago

Target version set to Candidate for next major release

I am sure this feature can improve UX. Discourse (open source discussion board software) has similar feature. You can try highlight feature of Discourse by clicking https://meta.discourse.org/t/educate-users-about-paragraphs/65220/9 .

The patch from Mizuki Ishikawa looks good to me but I think it is safer to change the patch as follows:

--- highlight_the_linked_note.patch.org    2017-06-28 13:44:46.000000000 +0900
+++ highlight_the_linked_note.patch    2017-06-28 13:45:00.000000000 +0900
@@ -12,7 +12,7 @@
 +  $(window).on('load hashchange',function(){
 +    var hash = location.hash;
 +    if (hash){
-+      $('div' + hash).css('background-color', '#ffffdd').animate({backgroundColor: ''}, 2000);
++      $('#history div' + hash).css('background-color', '#ffffdd').animate({backgroundColor: ''}, 2000);
 +    }
 +  });
 +});