Patch #25320

Remove initial indentation of blockquotes for better readability

Added by Jan from Planio www.plan.io 2 months ago. Updated 2 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

90%

Category:UI
Target version:3.4.0

Description

Currently, quoted text in Redmine is rendered with the blockquote element which is styled to be a grey vertical bar.

On the second and onward levels, the indentation of quotes equals the width of the bar plus some padding to the right.

Only on the first level, there is some additional margin to the left indenting the entire quote block even more. I find quotes to be more readable and more visually appealing if this margin was removed. Hence this patch.

How it looks now:

How it will look with the patch:

The patch will also apply this to HTML in notification emails.

blockquotes_after.png (104 KB) Jan from Planio www.plan.io, 2017-03-14 07:07

blockquotes_before.png (104 KB) Jan from Planio www.plan.io, 2017-03-14 07:07

0001-Remove-initial-indentation-for-block-quotes.patch Magnifier (2.45 KB) Jan from Planio www.plan.io, 2017-03-14 09:20

Associated revisions

Revision 16417
Added by Jean-Philippe Lang 2 months ago

Remove initial indentation of blockquotes for better readability (#25320).

Patch by Jan Schulz-Hofen.

History

#1 Updated by Go MAEDA 2 months ago

I think that source:trunk/app/views/layouts/mailer.html.erb@16087#L28 should be updated if the proposed patch is merged.

#2 Updated by Marius BALTEANU 2 months ago

The proposed change looks good to me.

#3 Updated by Go MAEDA 2 months ago

Go MAEDA wrote:

I think that source:trunk/app/views/layouts/mailer.html.erb@16087#L28 should be updated if the proposed patch is merged.

Sorry, the patch also updates mailer.html.erb. I missed it.

#4 Updated by Jan from Planio www.plan.io 2 months ago

Thanks for your feedback, Go and Marius.

Sadly, I overlooked RTL support. Here's an updated patch including the proposed change for RTL writing systems, e.g. Arabic.

#5 Updated by Jan from Planio www.plan.io 2 months ago

  • File deleted (0001-Remove-initial-indentation-for-block-quotes.patch)

#6 Updated by Jean-Philippe Lang 2 months ago

Sounds good to me.

#7 Updated by Go MAEDA 2 months ago

  • Status changed from Needs feedback to New
  • Target version changed from Candidate for next minor release to 3.4.0

Jean-Philippe Lang wrote:

Sounds good to me.

Setting target version to 3.4.0.

#8 Updated by Jean-Philippe Lang 2 months ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Committed, thanks.

Also available in: Atom PDF