Feature #5159

Ability to add Non-Member watchers to the watch list

Added by Jason Trahan over 7 years ago. Updated almost 4 years ago.

Status:ClosedStart date:2010-03-23
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Issues
Target version:1.4.0
Resolution:Fixed

Description

We currently have over 4,000 employees in our company. We would like the ability to add a watcher to the list without having to add them to the actual project. Since there are over 30 projects currently in our system maintaining a watcher list is becoming a nightmare because the project managers are having to constantly add the employees to the reporter list so that they can be added to the watch list.

add_watchers.png (8.6 KB) Jean-Philippe Lang, 2012-01-09 19:41


Related issues

Related to Redmine - Patch #6226: Add multiple watchers at once and add any redmine user as... Closed 2010-08-26
Related to Redmine - Feature #9942: Allow non-members to watch issues Closed
Related to Redmine - Feature #11724: Prevent users from seeing other users based on their proj... Closed
Related to Redmine - Defect #15123: "Add watcher" leaks all active users Closed
Duplicated by Redmine - Feature #6065: Display/add/remove watchers that are non-members on a pro... Closed 2010-08-06
Duplicated by Redmine - Feature #3448: Add issue watcher that isn't a maintainer Closed 2009-06-04
Duplicated by Redmine - Feature #4889: Ability to CC users not assigned to a project, but with p... Closed 2010-02-21

Associated revisions

Revision 8592
Added by Jean-Philippe Lang over 5 years ago

Ability to add non-member users as watchers (#5159).

Revision 9254
Added by Jean-Philippe Lang over 5 years ago

Ability to add non-member watchers on issue creation (#5159).

Revision 9307
Added by Toshi MARUYAMA over 5 years ago

generate i18n "label_search_for_watchers" key (#5159)

History

#1 Updated by Jon Lumpkin over 7 years ago

+1

#2 Updated by Stephen Fuhry over 7 years ago

+1

#3 Updated by Stanislav German-Evtushenko over 7 years ago

It would be very nice!

#4 Updated by Stanislav German-Evtushenko over 7 years ago

I do workaround at the moment, but it's quite useless:
1. Add user to project.
2. Add him as watcher.
3. Remove user from project.

#5 Updated by Arnaud Martel over 7 years ago

I did a quick patch to fix this on my server. I'm pretty sure that Jean-Philippe and Eric will have a nicer solution but, in the meantime, this one works for me...

First, edit the file app/views/watchers/_watchers.rhtml and insert the following text at line 21:

<% if @project.is_public? %>
<br>or email: <%= text_field 'email_watcher', :size => 80 %>
<% end %>

you should have something like:

...
<p><%= f.select :user_id, (watched.addable_watcher_users.collect {|m| [m.name, m.id]}), :prompt => true %>
<% if @project.is_public? %>
<br>or email: <%= text_field 'email_watcher', :size => 80 %>
<% end %>
<%= submit_tag l(:button_add) %>
...

Next, edit the file app/controllers/watchers_controller.rb and insert the following text at the start of the new function (line 40):

    if params[:email_watcher]
      wuser = User.find_by_mail(params[:email_watcher][:size80])
      if wuser
        params[:watcher][:user_id] = wuser.id
      else
        raise
      end
    end

you should have something like:

...
  def new
    if params[:email_watcher]
      wuser = User.find_by_mail(params[:email_watcher][:size80])
      if wuser
        params[:watcher][:user_id] = wuser.id
      else
        raise
      end
    end
    @watcher = Watcher.new(params[:watcher])
...

Final step: restart your web server and it should work as you like...

#6 Updated by Enrique Delgado about 7 years ago

+1

Aranaud: Okay so if I understand correctly, with your patch you can add a watcher based on the email, as long as that email matches a redmine user? How about any email address? More like a "CC" field? Maybe Jean-Philippe and Eric can consider this functionality...

#7 Updated by Arnaud Martel about 7 years ago

You're right: with my patch, emails have to match a redmine user. As you have seen, redmine_cc_addresses plugin seems to be a better choice for you...

#8 Updated by Eric Seigne about 7 years ago

Did you see #6226 ?

#9 Updated by Jean-Philippe Lang over 5 years ago

  • File add_watchers.png added
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Target version set to 1.4.0
  • Resolution set to Fixed

Feature added in r8592.

Watchers can now be added via a dialog box. It displays project members by default and you can use the search field to search for other users. Multiple users can be added at the same time.

#10 Updated by Jason Trahan over 5 years ago

Thank you very much. This will be a tremendous help.

#11 Updated by Jason Trahan over 5 years ago

  • Status changed from Closed to Reopened

It appears I can only add the watchers after the ticket is created. It would be nice to be able to add them at the time of ticket creation.

#12 Updated by Terence Mill over 5 years ago

+1 to add groups as well

#13 Updated by Mischa The Evil over 5 years ago

Jason Trahan wrote:

It appears I can only add the watchers after the ticket is created. It would be nice to be able to add them at the time of ticket creation.

See related issue #9500#note-3.

#14 Updated by Jean-Philippe Lang over 5 years ago

  • Status changed from Reopened to Closed

Jason Trahan wrote:

It appears I can only add the watchers after the ticket is created. It would be nice to be able to add them at the time of ticket creation.

Added in r9254.

#15 Updated by Fernando Hartmann about 5 years ago

I don't understood how this work !

  • Added one watcher user to a issue in with no permission on that project.
  • Posted some update to a issue
Results:
  • Users registered to that project received a email notification
  • Other watcher user didn't received nothing
  • User with no perms on the project didn't have access to a issue

How this feature is supposed to work ? Is there some docs about this ?

#16 Updated by Maxim Kim about 5 years ago

This change caused a major problems at least for us.
We let our customers to add new issues and watchers. And now our customers can see other customer names, which is inacceptable!
Could you please add asap setting to switch off this feature.

My personal opinion is that right solution was to add permission "can be non-member watcher" as someone suggested earlier.

#17 Updated by Enrique Delgado about 5 years ago

Arnaud Martel wrote:

You're right: with my patch, emails have to match a redmine user. As you have seen, redmine_cc_addresses plugin seems to be a better choice for you...

Just as a follow up: thanks Arnaud, I did end up going the redmine_cc_addresses route. I also like the new feature. Maybe to ease Maxim's concerns, some permissions need to be established so that some projects allow watchers from non-members, while some projects do not.

Thanks all for all your fine work.

#18 Updated by Daniel Hochman about 4 years ago

We are running BitNami Redmine 2.3.1 and I am not able to see users in the watchers list unless they are a member of the project. The Projects are "public" so these users have access. We are using the "Watchers Textinput plugin" - is that causing this issue? Before using that plugin, we had a long list of checkboxes.

#19 Updated by Toshi MARUYAMA almost 4 years ago

  • Related to Defect #15123: "Add watcher" leaks all active users added

#20 Updated by Beni Bilme almost 4 years ago

We are using bitnami redmine stack for redmine 2.3.3, and watchers function is not working unless the watcher is project member.

#21 Updated by Toshi MARUYAMA almost 4 years ago

Beni Bilme wrote:

We are using bitnami redmine stack for redmine 2.3.3, and watchers function is not working unless the watcher is project member.

You need to search in text box.

#22 Updated by Daniel Hochman almost 4 years ago

No, this is a bug. I am having the same issue as Beni and we are no longer on bitnami stack. This issue needs to be re-opened as a bug. You cannot add watchers who are not members of the project after issue creation.

#23 Updated by Toshi MARUYAMA almost 4 years ago

Daniel Hochman wrote:

No, this is a bug. I am having the same issue as Beni and we are no longer on bitnami stack. This issue needs to be re-opened as a bug. You cannot add watchers who are not members of the project after issue creation.

If it is on only bitnami, please contact bitnami.
If it is on clean Redmine, do not re-open this issue, create new issue.

#24 Updated by Daniel Hochman almost 4 years ago

OK thanks. Filed #15622

#25 Updated by Go MAEDA almost 2 years ago

  • Duplicated by Feature #4889: Ability to CC users not assigned to a project, but with project view rights added

Also available in: Atom PDF