Defect #7335
closedSorting issues in gantt by date, not by id
90%
Description
I can't tell if the prior issues (see below) related to gantt chart issue sorting are about new- or old-style gantt charts. I do know that the default 1.1.0 isn't very useful, since they're sorted by root_id (ie. parent issue id). That has little relation to the order that the issues need to be worked on in. I made a one-line change that worked for me:
- TODO: top level issues should be sorted by start date
def gantt_issue_compare(x, y, issues)
[(x.root.start_date or x.start_date or Date.new()), (x.start_date or Date.new()), x.root_id, x.lft] <=> [(y.root.start_date or y.start_date or Date.new()), (y.start_date or Date.new()), y.root_id, y.lft]
#if x.root_id == y.root_id # x.lft <=> y.lft
#else # #x.root_id <=> y.root_id
#end
end
I'm not 100% certain if it works in all cases, but for my DB (multi-project, multi-version, single nesting level issues), it works fine.
Files
Related issues
Updated by Eli Stevens almost 14 years ago
Updated by Guillaume Pellegrin almost 14 years ago
Hi Eli,
And thanks for your patch. Worked fine for me. I'll post here in case this breaks some use cases.
Hope this change will be made available in the next release.
Regards,
Guillaume
Updated by Eli Stevens almost 14 years ago
Update: the first line didn't work in all cases for me. This one seems to be behaving better:
[(x.root.start_date or x.start_date or Date.new()), x.root_id, (x.start_date or Date.new()), x.lft] <=> [(y.root.start_date or y.start_date or Date.new()), y.root_id, (y.start_date or Date.new()), y.lft]
Updated by Sebastian Buckpesch almost 14 years ago
Hi,
where do I enter this line of code or apply this patch?
Thanks,
Sebastian
Updated by Etienne Massip almost 14 years ago
lib/redmine/helpers/gantt_helper.rb (gantt_issue_compare())
?
Updated by E M almost 14 years ago
Anyone knows if we can also sort by name? Or if the above patch could be easily modified to sort by top level issue name (instead of id like current or start date like this fix)?
feel free to move this to a new issue if you feel it's necessary.
Updated by Felipe Ribeiro almost 13 years ago
- File sort_issues_from_start_date.diff sort_issues_from_start_date.diff added
- File sort_issues.rb sort_issues.rb added
I solved this by changing the way to insert issues in the Data Base. I just insert them already in the correct order.
But also I had to change the values of rgt and lft directly on the Data Base, because there were projects already inserted in the system, and doing this I guarantee that all projects will be sorted correctly.
Is attached the diff file and the new script i had to create.
Updated by Toshi MARUYAMA about 12 years ago
- Assignee deleted (
Mischa The Evil)
Updated by Toshi MARUYAMA about 12 years ago
- File redmine-trunk-r10713.png redmine-trunk-r10713.png added
- File redmine-trunk-r10713-patch.png redmine-trunk-r10713-patch.png added
- File gantt-sort-r10713.diff gantt-sort-r10713.diff added
This is a patch for trunk r10713.
This patch sort start date algorism is referred from Redmine Better Gantt Chart Plugin
But, issues tree structure is broken by start date sorting.
Redmine trunk r10713
¶
Patch applied
¶
Updated by Etienne Massip about 12 years ago
FTR the patch in #7456 originally implemented some sorting too.
Updated by Jonathan Vargas almost 12 years ago
Hi guys.
I just required the sort by start date and then applied manually the first chunk mentioned on sort_issues_from_start_date.diff, to my 2.2.0 version, and it worked as expected.
So, could it be possible to apply it on 2.2's trunk or next versions? I see that a default sorting by start_date first has more sense than by issue_id.
Thanks in advance.
Updated by Toshi MARUYAMA almost 12 years ago
New patch is posted at #8366#note-2.
Updated by Toshi MARUYAMA over 11 years ago
- File gantt-sort-trunk-r11692.diff gantt-sort-trunk-r11692.diff added
- File gantt-sort-trunk-r11692.png gantt-sort-trunk-r11692.png added
I confirmed #8366 Change-Gantt-default-sorting-to-start_date-instead-of-id.patch fixes note-16 problem.
I re-post it as gantt-sort-trunk-r11692.diff .
Updated by Yuhki ISHIGURO over 11 years ago
Thank you for your patch, Toshi.
I applied your patch, and it looked working correctly, first.
However, note-16 problem is still happen to issues which added
after your patch applied.
Updated by Toshi MARUYAMA over 11 years ago
Yuhki Ishiguro wrote:
Thank you for your patch, Toshi.
I applied your patch, and it looked working correctly, first.
However, note-16 problem is still happen to issues which added
after your patch applied.
Thank you for your trying.
Could you try this patch using another logic.
This logic is from here (in Japanese).
http://d.hatena.ne.jp/itto100pen/20121202
Updated by Yuhki ISHIGURO over 11 years ago
Umm... I tried new patch. And, same things happen.
I show you my Test project.
426 wasn't added correctly, but after adding 428, it was solved.
Updated by Toshi MARUYAMA over 11 years ago
I got a suggestion from patch author.
https://twitter.com/nobu_toyofuku/status/326227862808064000
Could you try this patch?
Updated by Yuhki ISHIGURO over 11 years ago
I tried gantt-sort-trunk-r11740.diff, and it seems working correctly!
Thank you !!
Regards,
Yuhki ISHIGURO
Updated by Toshi MARUYAMA over 11 years ago
gantt-sort-trunk-r11740.diff does not sort root issues.
This patch fixes it.
Updated by Yuhki ISHIGURO over 11 years ago
Toshi MARUYAMA wrote:
gantt-sort-trunk-r11740.diff does not sort root issues.
This patch fixes it.
I greatly appreciate for you contribution.
I tried your new patch gantt-sort-trunk-r11744.
It works fine, and I think it solves this issue.
Regards,
Yuhki ISHIGURO
Updated by David Dupont over 11 years ago
Hi,
I tried to apply patch but errors occured :
root@linus:/var/www/redmine# patch -p0 < gantt-sort-trunk-r11744.diff patching file b/lib/redmine/helpers/gantt.rb Hunk #1 FAILED at 675. 1 out of 1 hunk FAILED -- saving rejects to file b/lib/redmine/helpers/gantt.rb.rej patching file b/lib/redmine/helpers/gantt.rb Hunk #1 FAILED at 687. 1 out of 1 hunk FAILED -- saving rejects to file b/lib/redmine/helpers/gantt.rb.rej patching file b/lib/redmine/helpers/gantt.rb Hunk #1 FAILED at 686. 1 out of 1 hunk FAILED -- saving rejects to file b/lib/redmine/helpers/gantt.rb.rej patching file b/lib/redmine/helpers/gantt.rb Hunk #1 FAILED at 220. Hunk #2 FAILED at 694. 2 out of 2 hunks FAILED -- saving rejects to file b/lib/redmine/helpers/gantt.rb.rej
Some help please ?
Thanks.
Version Info :
Environment:
Redmine version 2.3.0.devel.11744
Ruby version 1.8.7 (x86_64-linux)
Rails version 3.2.13
Environment production
Database adapter MySQL
Redmine plugins:
due_date_reminder 0.3.1
Updated by Toshi MARUYAMA over 11 years ago
David Dupont wrote:
Some help please ?
Use -p1 instead of -p0.
patch -p1 < gantt-sort-trunk-r11744.diff
And this patch is for trunk r11744, not 2.3.0.
Updated by David Dupont over 11 years ago
Thanks for the answer !
So i can't install it ?
Even if i change the file manually ? Is there too many difference between the trunk and 2.3.0 ?
Updated by Toshi MARUYAMA over 11 years ago
Updated by Toshi MARUYAMA over 11 years ago
This is patch for trunk.
There is no logic change from note-26 patch.
Updated by Toshi MARUYAMA over 11 years ago
- Target version set to 2.4.0
- % Done changed from 0 to 100
Updated by Toshi MARUYAMA over 11 years ago
- Related to Defect #7579: Gantt tab gives internal error. added
Updated by Toshi MARUYAMA over 11 years ago
- Related to Feature #14397: Gantt sorting as a configurable setting added
Updated by Filou Centrinov over 11 years ago
Please correct sort_version_logic(). Only "version.effective_date" contains the start date of a version. Otherwise the versions won't sorted by start date as expected.
Updated by Mischa The Evil about 11 years ago
- Assignee set to Toshi MARUYAMA
Filou Centrinov wrote:
Please correct sort_version_logic(). Only "version.effective_date" contains the start date of a version. Otherwise the versions won't sorted by start date as expected.
Toshi, can you look into this? Seems there might be something wrong with the tests because this does not trigger test failures.
Updated by Jean-Philippe Lang about 11 years ago
- Target version changed from 2.4.0 to Candidate for next major release
2.4 feature freeze
Updated by Toshi MARUYAMA about 11 years ago
- Target version changed from Candidate for next major release to 2.4.0
I think note 36 patch need to check in 2.4.0.
Updated by Jean-Philippe Lang about 11 years ago
Filou Centrinov wrote:
Please correct sort_version_logic(). Only "version.effective_date" contains the start date of a version. Otherwise the versions won't sorted by start date as expected.
A better option would be to sort versions by version.effective_date || version.start_date
. A version may not have an effective_date but some issues with start dates assigned to it.
Versions with no start_date nor effective should be listed at the very end. I'm not this is the case with || Date.new
.
Updated by Etienne Massip about 11 years ago
If it can help, here's an excerpt from #7456 where the idea was also to display shared version before concerned projects:
The shared version is tied to the selected project (also valid for "all projects" Gantt):
parent project -> shared version -> subproject -> shared version issues (including parent project issues)
The shared version is tied to a not-visible-parent project of the selected project:
subproject -> shared version -> shared version issues (excluding parent project issues)
Issue sorting code within a version+project scope:
# Compare issues for rendering order
def gantt_issue_compare(x, y)
if x.parent_id == y.parent_id
# Same level in issue hierarchy
basic_gantt_issue_compare(x, y)
elsif x.root_id == y.root_id || x.root_id == y.id || y.root_id == x.id
# Same issue hierarchy
x.lft <=> y.lft
else
# Distinct hierarchies
x.root_id <=> y.root_id
# TODO : advanced sort between issues when ancestors have been filtered out by query
end
end
def basic_gantt_issue_compare(x, y)
if x.start_date == y.start_date
x.id <=> y.id
elsif x.start_date.nil?
1 # null date appears at the end
elsif y.start_date.nil?
-1
else
x.start_date <=> y.start_date
end
end
Updated by Jean-Philippe Lang almost 11 years ago
- Subject changed from Sorting issues in new gantt (v1.1.0) to Sorting issues in gantt by date, not by id
- Status changed from New to Closed
- Resolution set to Fixed