Project

General

Profile

Actions

Feature #12795

closed

View group members by non-admin users

Added by Scott Roland over 11 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Groups
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

There is currently no way for a user to find out who is a member of which groups. I would like this page (and the individual group pages) to be visible by non-admin users (although obviously not editable):
http://demo.redmine.org/groups

In conjunction with Feature Request #12794 (Member groups not listed in project page), here is how I would see it being used:
I open a new Bug Issue for a project and assign it to the group "Database-Developers". When nothing happens with the issue, I want to know who is in that group so that I can talk to them in person.


Files


Related issues

Related to Redmine - Feature #12796: Display user's groups on profileClosedJean-Philippe Lang

Actions
Related to Redmine - Feature #12794: Member groups not listed in project pageClosed

Actions
Related to Redmine - Defect #35823: undefined method `+' for nil:NilClassClosedGo MAEDA

Actions
Related to Redmine - Patch #38144: Refactoring: Use Group.visible instead of manual visibility check in GroupsControllerClosedGo MAEDA

Actions
Related to Redmine - Patch #37994: Unify link to user/group in application helperNew

Actions
Actions #1

Updated by Jean-Philippe Lang over 11 years ago

  • Tracker changed from Defect to Feature
  • Subject changed from Non-admin users cannot get info about groups to View group members by non-admin users
Actions #2

Updated by Go MAEDA over 3 years ago

+1

The following code allows users to see group members according to "Users visibility" setting (#11724) of their role.

diff --git a/app/controllers/groups_controller.rb b/app/controllers/groups_controller.rb
index fb21e2f05..68fa826c9 100644
--- a/app/controllers/groups_controller.rb
+++ b/app/controllers/groups_controller.rb
@@ -21,7 +21,7 @@ class GroupsController < ApplicationController
   layout 'admin'
   self.main_menu = false

-  before_action :require_admin
+  before_action :require_admin, :except => [:show]
   before_action :find_group, :except => [:index, :new, :create]
   accept_api_auth :index, :show, :create, :update, :destroy, :add_users, :remove_user

@@ -50,6 +50,8 @@ class GroupsController < ApplicationController
   end

   def show
+    return render_404 unless @group.visible?
+
     respond_to do |format|
       format.html
       format.api
Actions #3

Updated by Go MAEDA over 3 years ago

The attached patches implement the feature.

  • A user can see /groups/:id page that displays group members if the group is visible for the user. The visibility of the group follows "Users visibility" setting of roles
  • Adds links from group names to /groups/:id page

Actions #4

Updated by Go MAEDA almost 3 years ago

Updated the patch. Make the page layout consistent with the user profile page.

Actions #5

Updated by Go MAEDA almost 3 years ago

  • File deleted (0001-Allow-non-admin-users-to-see-group-members-when-the-.patch)
Actions #6

Updated by Go MAEDA almost 3 years ago

  • Target version set to Candidate for next major release
Actions #7

Updated by Go MAEDA almost 3 years ago

  • Target version changed from Candidate for next major release to 5.0.0

Setting the target version to 5.0.0.

Actions #8

Updated by Go MAEDA over 2 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch.

Non-admin users can see group members by clicking a group name on the project overview page.

Actions #9

Updated by Go MAEDA over 2 years ago

Go MAEDA wrote:

Committed the patch.

Non-admin users can see group members by clicking a group name on the project overview page.

Also, the assignee field now shows a link to the group page if the assignee is a group (r21075).

Actions #10

Updated by Go MAEDA over 2 years ago

  • Related to Defect #35823: undefined method `+' for nil:NilClass added
Actions #11

Updated by Holger Just over 1 year ago

  • Related to Patch #38144: Refactoring: Use Group.visible instead of manual visibility check in GroupsController added
Actions #12

Updated by Holger Just over 1 year ago

  • Related to Patch #37994: Unify link to user/group in application helper added
Actions

Also available in: Atom PDF