Feature #12795
closedView group members by non-admin users
0%
Description
There is currently no way for a user to find out who is a member of which groups. I would like this page (and the individual group pages) to be visible by non-admin users (although obviously not editable):
http://demo.redmine.org/groups
In conjunction with Feature Request #12794 (Member groups not listed in project page), here is how I would see it being used:
I open a new Bug Issue for a project and assign it to the group "Database-Developers". When nothing happens with the issue, I want to know who is in that group so that I can talk to them in person.
Files
Related issues
      
      Updated by Jean-Philippe Lang almost 13 years ago
      
    
    - Tracker changed from Defect to Feature
 - Subject changed from Non-admin users cannot get info about groups to View group members by non-admin users
 
      
      Updated by Go MAEDA almost 5 years ago
      
    
    +1
The following code allows users to see group members according to "Users visibility" setting (#11724) of their role.
diff --git a/app/controllers/groups_controller.rb b/app/controllers/groups_controller.rb
index fb21e2f05..68fa826c9 100644
--- a/app/controllers/groups_controller.rb
+++ b/app/controllers/groups_controller.rb
@@ -21,7 +21,7 @@ class GroupsController < ApplicationController
   layout 'admin'
   self.main_menu = false
-  before_action :require_admin
+  before_action :require_admin, :except => [:show]
   before_action :find_group, :except => [:index, :new, :create]
   accept_api_auth :index, :show, :create, :update, :destroy, :add_users, :remove_user
@@ -50,6 +50,8 @@ class GroupsController < ApplicationController
   end
   def show
+    return render_404 unless @group.visible?
+
     respond_to do |format|
       format.html
       format.api
      
      Updated by Go MAEDA almost 5 years ago
      
    
    - File 0001-Allow-non-admin-users-to-see-group-members-when-the-.patch added
 - File 0002-Add-link-from-group-name-to-group-page.patch 0002-Add-link-from-group-name-to-group-page.patch added
 - File link-from-group-name-to-group-page.png link-from-group-name-to-group-page.png added
 - File group-page.png group-page.png added
 
The attached patches implement the feature.
- A user can see /groups/:id page that displays group members if the group is visible for the user. The visibility of the group follows "Users visibility" setting of roles
 - Adds links from group names to /groups/:id page
 


      
      Updated by Go MAEDA over 4 years ago
      
    
    - File 0001-Allow-non-admin-users-to-see-group-members-when-the-.patch 0001-Allow-non-admin-users-to-see-group-members-when-the-.patch added
 
Updated the patch. Make the page layout consistent with the user profile page.
      
      Updated by Go MAEDA over 4 years ago
      
    
    - File deleted (
0001-Allow-non-admin-users-to-see-group-members-when-the-.patch) 
      
      Updated by Go MAEDA over 4 years ago
      
    
    - Target version set to Candidate for next major release
 
      
      Updated by Go MAEDA over 4 years ago
      
    
    - Target version changed from Candidate for next major release to 5.0.0
 
Setting the target version to 5.0.0.
      
      Updated by Go MAEDA over 4 years ago
      
    
    - Status changed from New to Closed
 - Assignee set to Go MAEDA
 - Resolution set to Fixed
 
Committed the patch.
Non-admin users can see group members by clicking a group name on the project overview page.
      
      Updated by Go MAEDA over 4 years ago
      
    
    Go MAEDA wrote:
Committed the patch.
Non-admin users can see group members by clicking a group name on the project overview page.
Also, the assignee field now shows a link to the group page if the assignee is a group (r21075).
      
      Updated by Go MAEDA about 4 years ago
      
    
    - Related to Defect #35823: undefined method `+' for nil:NilClass added
 
      
      Updated by Holger Just almost 3 years ago
      
    
    - Related to Patch #38144: Refactoring: Use Group.visible instead of manual visibility check in GroupsController added
 
      
      Updated by Holger Just almost 3 years ago
      
    
    - Related to Patch #37994: Unify link to user/group in application helper added