Defect #13673: Parent issue column includes issue subject (making issue list unworkable wide) - Redmine

Custom queries

Documentation issues
Open defects
Open features
Patch queue
Plugin issues
Translation patches

Actions

Copy link

Defect #13673

closed

Parent issue column includes issue subject (making issue list unworkable wide)

Added by Jongwook Choi almost 13 years ago. Updated about 9 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Jean-Philippe Lang

Category:

Target version:

2.6.1

Resolution:

Fixed

Affected version:

2.3.0

Description

Hi. There is a report for the new bug I've just found.

Since redmine 2.3.0, the parent issue field is being displayed too long with the issue's title in the list view.
This disturbs the list narrowing other columns as figure below, especially when the issues have long titles.

I found r10972 (#1766) is responsible for this behavior; it seems that this is just a mistake rather than intended.

This is a workaround patch I've tried:

--- app/helpers/queries_helper.rb    (revision 11695)
+++ app/helpers/queries_helper.rb    (working copy)
@@ -100,7 +100,7 @@ module QueriesHelper
     when 'FalseClass'
       l(:general_text_No)
     when 'Issue'
-      value.visible? ? link_to_issue(value) : "##{value.id}" 
+      value.visible? ? link_to_issue(value, :subject => false) : "##{value.id}" 
     when 'IssueRelation'
       other = value.other_issue(issue)
       content_tag('span',

Thanks.

Files

too-long-parent-issue.png (44.4 KB) too-long-parent-issue.png

Jongwook Choi, 2013-04-03 14:55

Related issues

Related to Redmine - Patch #16437: Parent task is not wrapped in the Issues list	Closed		Actions
Related to Redmine - Defect #13608: Parent column in CSV export should include issue id only	Closed	Jean-Philippe Lang	Actions
Related to Redmine - Feature #19371: Add a new query column for the parent task subject	Closed	Go MAEDA	Actions
Has duplicate Redmine - Defect #16227: Father task info displayed in issue tooooooooo long	Closed		Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Jongwook Choi over 12 years ago

Any feedback on this?

Actions

Copy link

Updated by Mr Purple over 12 years ago

+ 1

Actions

Copy link

Updated by Danny Armstrong over 12 years ago

+1, This makes the list practically unusable.

I've taken parent task out of my default columns until there is a fix.

Actions

Copy link

Updated by Jongwook Choi over 12 years ago

Wish 2.3.3 maintenance release would include this.

Actions

Copy link

Updated by Gergely Nagy over 12 years ago

+1, Wish 2.3.4 maintenance release would include this.

Actions

Copy link

Updated by Mischa The Evil over 12 years ago

Subject changed from Parent issue column unexpectedly displayed too long in issue list to Parent issue column includes issue subject (making issue list unworkable wide)
Status changed from New to Confirmed
Target version set to Candidate for next minor release

Jongwook Choi wrote:

Since redmine 2.3.0, the parent issue field is being displayed too long with the issue's title in the list view.
This disturbs the list narrowing other columns as figure below, especially when the issues have long titles.
[...]
I found r10972 (#1766) is responsible for this behavior; it seems that this is just a mistake rather than intended.

I can confirm the issue on current trunk. It is indeed introduced in r10972. Though, it isn't a mistake for sure. It is an intended change that is required to render the value for the issue column on the spent time reports correctly.

This is a workaround patch I've tried:

That patch breaks the issue column on the spent time reports.

Here follows a quick patch that restores the previous markup of the parent task column values on the issue list (without subject) and maintains (and restores) markup of the issue column values on the spent time reports (with subject truncated to 50 chars¹) without breaking parts of the core²:

Index: app/helpers/queries_helper.rb
===================================================================
--- app/helpers/queries_helper.rb    (revision 12224)
+++ app/helpers/queries_helper.rb    (working copy)
@@ -124,7 +124,12 @@
     when 'FalseClass'
       l(:general_text_No)
     when 'Issue'
-      value.visible? ? link_to_issue(value) : "##{value.id}" 
+      case @query.class.name
+      when 'IssueQuery'
+        value.visible? ? link_to_issue(value, :subject => false) : "##{value.id}" 
+      when 'TimeEntryQuery'
+        value.visible? ? link_to_issue(value, :truncate => 50) : "##{value.id}" 
+      end
     when 'IssueRelation'
       other = value.other_issue(issue)
       content_tag('span',

¹ although it might be a good idea to keep the unlimited description here like introduced in r10972.

² although, I am not sure if this change doesn't break the existing test suite.

Actions

Copy link

Updated by Fran Fabrizio almost 12 years ago

Actions

Copy link

Updated by Luis Serrano Aranda almost 12 years ago

Actions

Copy link

Updated by René Carolus almost 12 years ago

I´m looking for a fix to remove the subject from the column parent task in Redmine 2.5.
Is there a possibility to fix this in any file?

Actions

Copy link

#10

Updated by Toshi MARUYAMA almost 12 years ago

Related to Patch #16437: Parent task is not wrapped in the Issues list added

Actions

Copy link

#11

Updated by Toshi MARUYAMA almost 12 years ago

Try #16437 patch.

Actions

Copy link

#12

Updated by René Carolus almost 12 years ago

Thanks. This is better than bevor.
I hope in the next minor Version the there is a possibility to remove the name or to configure the content of the column.

Actions

Copy link

#13

Updated by Michael Pickelbauer over 11 years ago

+1, but I would be in favor to solve this issue via CSS. The column "Parent Task" does not get wrapped due to this CSS property:

/stylesheets/application.css: 152

tr.issue { text-align: center; white-space: nowrap; }

This would actually mean, that every column will not be wrapped if the column gets to wide, but the next statement makes some exceptions:

/stylesheets/application.css: 153

tr.issue td.subject, tr.issue td.category, td.assigned_to, tr.issue td.string, tr.issue td.text, tr.issue td.relations { white-space: normal; }

I am in favor to add the parent column to this list of exceptions.

Actions

Copy link

#14

Updated by Go MAEDA over 11 years ago

Related to #13608 and #16227.

Actions

Copy link

#15

Updated by Toshi MARUYAMA over 11 years ago

Related to Defect #13608: Parent column in CSV export should include issue id only added

Actions

Copy link

#16

Updated by Toshi MARUYAMA over 11 years ago

Has duplicate Defect #16227: Father task info displayed in issue tooooooooo long added

Actions

Copy link

#17

Updated by Rainer Putzinger over 11 years ago

René Carolus wrote:

I´m looking for a fix to remove the subject from the column parent task in Redmine 2.5.
Is there a possibility to fix this in any file?

Second that; I, too, am looking for a solution in RedMine 2.5, but the patched code parts are no longer part of query_helper.rb, as it seems.

Could someone please provide some hint? Thanks!

Actions

Copy link

#18

Updated by Jean-Philippe Lang over 11 years ago

Status changed from Confirmed to Resolved
Assignee set to Jean-Philippe Lang
Target version changed from Candidate for next minor release to 2.6.1
Resolution set to Fixed

Fixed in r13556, the parent column contains tracker and issue id only as before.

Actions

Copy link

#19

Updated by Jean-Philippe Lang about 11 years ago

Status changed from Resolved to Closed

Merged.

Actions

Copy link

#20

Updated by Sebastian Paluch almost 11 years ago

I have just updated to 2.6.2 and this broke a lot for us...

Seeing only parent issue number makes the column useless because we do not know what the parent is about :/ often parent subject contains general information (e.g. test A) and then more details in subtasks (e.g. prepare setup, make report, etc.), now I see only few tasks like prepare setup with no information what the setup is for :/

Wasn't better fix for this provided in #19120 and in note 13? Or maybe an option in settings?

I have added another issue #19371 to track this separately.

Actions

Copy link

#21

Updated by Volker Theiding almost 11 years ago

+1 for config option.

Same here at my company. Actually, since we switched to Redmine, we always saw the parents subject, so when it now went away, we first believed it was a bug. I see the majority of users prefers the form without the subject. So a config option would be great.

Actions

Copy link

#22

Updated by Jonatã Bolzan Loss about 9 years ago

+1, it would be great to give an option to show the subject.

Actions

Copy link

#23

Updated by Toshi MARUYAMA about 9 years ago

Related to Feature #19371: Add a new query column for the parent task subject added

Actions

Copy link

Also available in: Atom PDF

Project

General

Profile

Redmine

Custom queries

Defect #13673

Parent issue column includes issue subject (making issue list unworkable wide)

Updated by Jongwook Choi over 12 years ago

Updated by Mr Purple over 12 years ago

Updated by Danny Armstrong over 12 years ago

Updated by Jongwook Choi over 12 years ago

Updated by Gergely Nagy over 12 years ago

Updated by Mischa The Evil over 12 years ago

Updated by Fran Fabrizio almost 12 years ago

Updated by Luis Serrano Aranda almost 12 years ago

Updated by René Carolus almost 12 years ago

Updated by Toshi MARUYAMA almost 12 years ago

Updated by Toshi MARUYAMA almost 12 years ago

Updated by René Carolus almost 12 years ago

Updated by Michael Pickelbauer over 11 years ago

Updated by Go MAEDA over 11 years ago

Updated by Toshi MARUYAMA over 11 years ago

Updated by Toshi MARUYAMA over 11 years ago

Updated by Rainer Putzinger over 11 years ago

Updated by Jean-Philippe Lang over 11 years ago

Updated by Jean-Philippe Lang about 11 years ago

Updated by Sebastian Paluch almost 11 years ago

Updated by Volker Theiding almost 11 years ago

Updated by Jonatã Bolzan Loss about 9 years ago

Updated by Toshi MARUYAMA about 9 years ago