Defect #14817
closed
Redmine loses filters after deleting a spent time
Added by Thomas Godard about 13 years ago.
Updated almost 10 years ago.
Description
When you add filters in the spent time "Details" view, and then delete an entry, the refresh loses the filters you had.
Steps to reproduce:
- Add a filter
- Delete a spent time
Expected result:
Refresh with the filter you had
Actual result:
Refresh with the default page
Files
This issue reproduces also on the latest trunk version.
I think that this issue is generated by another issue: time spent filters are not stored in the session.
To reproduce:
- Go to the spent time tab
- Create a filter
- Navigate to issues tab
- Return to the spent time tab
- Observe that the filters are reseted.
The below change seems to fix the issue. I'm going to make a patch with tests for this.
diff --git a/app/controllers/timelog_controller.rb b/app/controllers/timelog_controller.rb
old mode 100644
new mode 100755
index 6c0cd3e..2edf556
--- a/app/controllers/timelog_controller.rb
+++ b/app/controllers/timelog_controller.rb
@@ -281,6 +281,6 @@ private
end
def retrieve_time_entry_query
- retrieve_query(TimeEntryQuery, false)
+ retrieve_query(TimeEntryQuery, true)
end
end
Attached is a patch that fixes the issue reported initially in this ticket and the issue from note-2. Please let me know if a should open a new ticket for the issue from note-2.
- Target version set to 3.3.2
Thank you for the patch, it works fine for me and passed all tests.
In addition, the patch also fixes #13622.
Setting target version to 3.3.2.
- Related to Defect #13622: "Clear" button in Spent Time Report tab also clears global filters added
- Status changed from New to Resolved
- Assignee set to Jean-Philippe Lang
- Resolution set to Fixed
Marius BALTEANU wrote:
Attached is a patch that fixes the issue reported initially in this ticket and the issue from note-2. Please let me know if a should open a new ticket for the issue from note-2.
Storing the filters in session is a different behaviour, please open another ticket and we'll see if this is desirable, thanks.
I've have the reported issue in r16056 without changing this behaviour.
Jean-Philippe Lang wrote:
Marius BALTEANU wrote:
Attached is a patch that fixes the issue reported initially in this ticket and the issue from note-2. Please let me know if a should open a new ticket for the issue from note-2.
Storing the filters in session is a different behaviour, please open another ticket and we'll see if this is desirable, thanks.
I've have the reported issue in r16056 without changing this behaviour.
Here is the new ticket #24581.
- Subject changed from Redmine loses filters after deleting a spent time. to Redmine loses filters after deleting a spent time
- Status changed from Resolved to Closed
- Has duplicate Defect #9016: displayed page after deleting time_entry added
- Related to Defect #17302: Forwarding from issues time entries page to project time entries page added
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by