Project

General

Profile

Actions

Patch #16133

closed

Available watchers on new issue form include users who cannot even view issues

Added by Jan from Planio www.plan.io about 10 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Issues
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

The proposed watchers on the new issue form should be able to at least view issues. Otherwise it would not make sense to add them as watchers.

The attached patch fixes the behavior and makes it consistent with source:trunk/lib/plugins/acts_as_watchable/lib/acts_as_watchable.rb@11960#L36

No test for now, though.


Files

available_watchers_in_project.patch (831 Bytes) available_watchers_in_project.patch Jan from Planio www.plan.io, 2014-02-19 17:41

Related issues

Related to Redmine - Defect #17071: Adding Watchers UX Is Not CleanNew

Actions
Related to Redmine - Defect #22977: A project member has no access and gets no notification, when being a watcher of the issueNew

Actions
Related to Redmine - Defect #24061: Tickets can be watched by users who are not available in specific trackerNew

Actions
Related to Redmine - Feature #28368: regarding watcher added in private project but not getting notification Closed

Actions
Related to Redmine - Defect #30370: No validation when adding watcher who is not in this projectClosed

Actions
Related to Redmine - Feature #5159: Ability to add Non-Member watchers to the watch listClosedJean-Philippe Lang2010-03-23

Actions
Related to Redmine - Patch #33329: Improve watchers functionality to mark the users that are watching a non visible object and to not return watchers that cannot see the objectClosedGo MAEDA

Actions
Actions #1

Updated by Jan from Planio www.plan.io over 9 years ago

  • Target version changed from Candidate for next minor release to 2.5.3

I think this is a an easy one. Is it okay if I simply assign it to a target version?

Actions #2

Updated by Brett Patterson over 9 years ago

This ties in with #17071 which adjusts the behavior of the watchers assignment so you can filter/search and not have to add them one at a time.

Actions #3

Updated by Toshi MARUYAMA over 9 years ago

  • Related to Defect #17071: Adding Watchers UX Is Not Clean added
Actions #4

Updated by Jean-Philippe Lang over 9 years ago

  • Target version changed from 2.5.3 to Candidate for next minor release

I see the point but this change adds to much overhead for projects with lots of users.

Actions #6

Updated by Toshi MARUYAMA over 7 years ago

  • Related to Defect #22977: A project member has no access and gets no notification, when being a watcher of the issue added
Actions #7

Updated by Go MAEDA over 7 years ago

  • Related to Defect #24061: Tickets can be watched by users who are not available in specific tracker added
Actions #8

Updated by Go MAEDA almost 6 years ago

  • Related to Feature #28368: regarding watcher added in private project but not getting notification added
Actions #9

Updated by Go MAEDA about 5 years ago

  • Related to Defect #30370: No validation when adding watcher who is not in this project added
Actions #10

Updated by Go MAEDA about 4 years ago

  • Related to Feature #5159: Ability to add Non-Member watchers to the watch list added
Actions #11

Updated by Marius BÄ‚LTEANU almost 4 years ago

Here are some ideas in order to avoid the overhead:

1. If we really want to show some watchers in the new issue form:
  • Get first 20 users from the database and check the visibility only for them
  • Get more users from the database and check the visibility until we get 20 users that can watch the issue.
  • Load them async.

2. If not, we just display the "Search for watchers to add" link to the user.

If we go for 1, we need also to load the watchers form when the tracker/project changes.

Actions #12

Updated by Go MAEDA about 3 years ago

  • Related to Patch #33329: Improve watchers functionality to mark the users that are watching a non visible object and to not return watchers that cannot see the object added
Actions #13

Updated by Go MAEDA over 2 years ago

  • Status changed from New to Closed
  • Target version deleted (Candidate for next minor release)

A similar fix has been merged in Redmine 4.2.0 (#33329).

Actions

Also available in: Atom PDF