Patch #16133

Available watchers on new issue form include users who cannot even view issues

Added by Jan from Planio www.plan.io over 6 years ago. Updated 3 months ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Issues
Target version:Candidate for next minor release

Description

The proposed watchers on the new issue form should be able to at least view issues. Otherwise it would not make sense to add them as watchers.

The attached patch fixes the behavior and makes it consistent with source:trunk/lib/plugins/acts_as_watchable/lib/acts_as_watchable.rb@11960#L36

No test for now, though.

available_watchers_in_project.patch Magnifier (831 Bytes) Jan from Planio www.plan.io, 2014-02-19 17:41


Related issues

Related to Redmine - Defect #17071: Adding Watchers UX Is Not Clean New
Related to Redmine - Defect #22977: A project member has no access and gets no notification, ... New
Related to Redmine - Defect #24061: Tickets can be watched by users who are not available in ... New
Related to Redmine - Feature #28368: regarding watcher added in private project but not gettin... Closed
Related to Redmine - Defect #30370: No validation when adding watcher who is not in this project Closed
Related to Redmine - Feature #5159: Ability to add Non-Member watchers to the watch list Closed 2010-03-23

History

#1 Updated by Jan from Planio www.plan.io almost 6 years ago

  • Target version changed from Candidate for next minor release to 2.5.3

I think this is a an easy one. Is it okay if I simply assign it to a target version?

#2 Updated by Brett Patterson almost 6 years ago

This ties in with #17071 which adjusts the behavior of the watchers assignment so you can filter/search and not have to add them one at a time.

#3 Updated by Toshi MARUYAMA almost 6 years ago

  • Related to Defect #17071: Adding Watchers UX Is Not Clean added

#4 Updated by Jean-Philippe Lang almost 6 years ago

  • Target version changed from 2.5.3 to Candidate for next minor release

I see the point but this change adds to much overhead for projects with lots of users.

#6 Updated by Toshi MARUYAMA about 4 years ago

  • Related to Defect #22977: A project member has no access and gets no notification, when being a watcher of the issue added

#7 Updated by Go MAEDA over 3 years ago

  • Related to Defect #24061: Tickets can be watched by users who are not available in specific tracker added

#8 Updated by Go MAEDA about 2 years ago

  • Related to Feature #28368: regarding watcher added in private project but not getting notification added

#9 Updated by Go MAEDA over 1 year ago

  • Related to Defect #30370: No validation when adding watcher who is not in this project added

#10 Updated by Go MAEDA 5 months ago

  • Related to Feature #5159: Ability to add Non-Member watchers to the watch list added

#11 Updated by Marius BALTEANU 3 months ago

Here are some ideas in order to avoid the overhead:

1. If we really want to show some watchers in the new issue form:
  • Get first 20 users from the database and check the visibility only for them
  • Get more users from the database and check the visibility until we get 20 users that can watch the issue.
  • Load them async.

2. If not, we just display the "Search for watchers to add" link to the user.

If we go for 1, we need also to load the watchers form when the tracker/project changes.

Also available in: Atom PDF