Feature #21662

Search in issue assigned dropdown list

Added by kunkka zhang almost 2 years ago. Updated 9 days ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:UI
Target version:4.1.0
Resolution:

Description

My team used redmine over one year,now there are about 100 people in one project。

Everytime I create a issue ,I must assgin to somebody, and the dropdown list is tooooooo long, really hard to find the people I want to assgin.

sorry about my english,can somebody tell me to do fix it?

autocomplete-issue-assigned-to_01@2x.png (66.1 KB) Tomomi Yuzuriha, 2017-10-27 09:59

autocomplete-issue-assigned-to_02@2x.png (67.1 KB) Tomomi Yuzuriha, 2017-10-27 09:59

autocomplete-issue-assigned-totrunk-r17004.patch Magnifier (2.21 KB) Tomomi Yuzuriha, 2017-10-27 10:02

gravatar_icon_none@2x.png (46.8 KB) Tomomi Yuzuriha, 2017-11-07 01:03

gravatar_icon_present@2x.png (60 KB) Tomomi Yuzuriha, 2017-11-07 01:03

0001-Add-autcomplete-issue-assigned-to.patch Magnifier (3.4 KB) Tomomi Yuzuriha, 2017-11-07 01:04

0002-Add-display-gravatar-on-assigners-list.patch Magnifier (2.07 KB) Tomomi Yuzuriha, 2017-11-07 01:04

0002-Add-display-gravatar-on-assigners-list.patch Magnifier (2.08 KB) Tomomi Yuzuriha, 2017-12-05 01:18

0001-Add-autcomplete-issue-assigned-to.patch Magnifier (3.41 KB) Tomomi Yuzuriha, 2017-12-05 01:18

gravatar-icon-none@2x.png (58 KB) Tomomi Yuzuriha, 2017-12-05 01:19

gravatar-icon-present@2x.png (76.3 KB) Tomomi Yuzuriha, 2017-12-05 01:19


Related issues

Related to Redmine - Feature #22275: Could search or input manually assignee and target version New
Duplicated by Redmine - Feature #26656: Search Assignee Closed

History

#1 Updated by Toshi MARUYAMA almost 2 years ago

  • Category set to UI
  • Priority changed from High to Normal

#2 Updated by Go MAEDA 11 months ago

  • Related to Feature #22275: Could search or input manually assignee and target version added

#3 Updated by Go MAEDA 11 months ago

It would be great if "Assignee" drop-down has incremental search feature like "Jump to project" drop-down improved by #23310.

#4 Updated by Toshi MARUYAMA 4 months ago

#5 Updated by Tomomi Yuzuriha about 1 month ago

+1 for kunkka zhang's idea!

I made the patch to implement this feature (compatible with latest trunk 17004).
This patch alows user to select assigner using incremental search.

Please see the screenshots below for the details.

Patch: autocomplete-issue-assigned-totrunk-r17004.patch

#6 Updated by Go MAEDA about 1 month ago

Tomomi Yuzuriha, thank you for contributing to Redmine.

I have just tried your patch and I noticed a problem. The problem is that "<< me >>" in the assignee list is removed by your patch. I think this is a big problem because "<< me >>" is very useful and probably many people use it.

I hope that "<< Me >>" will be available in your patch.

#7 Updated by Marius BALTEANU about 1 month ago

This improvement looks very nice and it'll improve Redmine UI/UX. I'm wondering if it is possible to make this implementation like a widget or JS function that can be reused easily in other parts from Redmine (eg: selects, add watchers, plugins).

#8 Updated by Tomomi Yuzuriha about 1 month ago

Go Maeda, Thank you for your pointting out of my patch's problem.

Refering your comment, I changed the patch as follows.
  • Add "<< me >>" in assignee list
  • Add separator between Users and Groups

Please see the screenshot and patch below for the details.


Patch: 0001-Add-autcomplete-issue-assigned-to.patch

Additionaly, Possible to add gravatar to the assignee list with the following patch.

Patch: 0002-Add-display-gravatar-on-assigners-list.patch

#9 Updated by Akipii Oga about 1 month ago

Tomomi Yuzuriha - san, +1 !

#10 Updated by Toshi MARUYAMA about 1 month ago

  • Subject changed from can enable to search people in dropdown list while assgin? to Search in issue assigned dropdown list

#11 Updated by Go MAEDA 27 days ago

  • Target version set to 4.1.0

LGTM. Setting the target version to 4.1.0.

#12 Updated by Tomomi Yuzuriha 10 days ago

I changed the patch because the layout was corrupted as shown below on the specific browser(e.g. chrome, IE).

Layout with chrome:

#13 Updated by Mischa The Evil 9 days ago

The screenshots look nice indeed. However, in my view1 there are some issues with this patch series in its current state2:
  • I'll start by saying that I agree with what Marius wrote in note#7: "[...] if it is possible to make this implementation like a widget or JS function that can be reused easily in other parts from Redmine (eg: selects, add watchers, plugins)". I actually think it might even be a requirement.
  • This functionality is only implemented in the issues/_attributes.html.erb partial, while there are:
    • one: more current uses of principals_options_for_select that (might) need the same functionality:
      • ProjectsHelper#project_default_assigned_to_options
      • issues/bulk_edit.html.erb view
      • issue_categories/_form.html.erb view
    • two: other similar parts of the current Redmine core code and indeed even plugins that could benefit from this change (again referring to Marius' quote here) [two other practical use-cases I though of were the user custom fields and even version selects (with the second one I'm thinking especially about the currently sometimes very long lists)].
      This becomes a problem (duplication) when the same functionality is being implemented in those other places too. Because of that it would be better if most of the implementation (logic) is outside of the views/partials. I haven't looked up what the possibilities here exactly are but what about an ApplicationHelper#principals_options_for_autocomplete or something? And what about some extraction/abstraction into (at least) (a) reusable JS function(s)?
  • And btw: what about the raw usage? Is is safe? I'd have to look into it more closely.
  • Some typo-look-a-like, potentially ambiguous variable names: assignner_list & assigners. What about assignee(s)_list & assignees?
  • What about some top-padding for the groups separator? Maybe a little less padding around the items themselfs? Maybe style the separator like the other opt-group implementations in Redmine3 by omitting the dashes and making the label bold. I should keep the icon in this case.
  • I see several CSS styles and li element styles. Does this affect themes/themeability? Transfer to application.css? Responsive styling ok? I haven't tested it.
  • This is I think the biggest problem currently: this patch misses an equivalent of :required => @issue.required_attribute?('assigned_to_id') introduced in r9977 for #703 and #3521.

All in all, I don't think that these patches are ready for integration yet.

1 disclaimer one: I don't consider myself a JavaScript guru.

2 disclaimer two: I haven't actually run this code myself (yet); I only did a (superficial) visual review of the patches from note#12.

3 like: r6307, r13662, r15601, r16194.

Also available in: Atom PDF