Defect #24723
closed
[regression?] r10132's changes were reverted with r15569
Added by Mischa The Evil over 7 years ago.
Updated 3 months ago.
Category:
Third-party libraries
Description
The adjustments made in r10132 were reverted by r15569 for #23107. Was this intentional, eg. to bring the upstream alpha base in sync with Redmine's theme or was it by mistake? Either way, the inline styles in the multilingual wiki_syntax_detailed_[*].html documentation needs to be re-synced again (like in r14492 for #20288). Before I start mocking-up a patch, I'd like to know what was/is intended...
Files
I guess they were not reverted intentionally.
- Related to Patch #24800: Remove internal style sheet duplication and obsoleted meta tag from wiki_syntax_* documentation. added
I am working on this. I'll leave an incomplete WIP patch that just re-introduces the changes from
r10132 as I don't have time to complete this task today. I'll continue working on it tomorrow.
Still to do:
- check upstream modifications of styles adjusted by/after r10132:
- lib/coderay/styles/alpha.rb:
- make sure the styles used for documentation files are in sync with Redmine's CodeRay styles with the final changes for this issue applied (made easier by #24800).
- compare all changes with #24681, review them and report back.
This patch, against current source:/trunk@16171, is produced using git format-patch which makes the patch apply-able using "patch -p1 < 0001-...".
- Status changed from Confirmed to Closed
- Resolution set to Wont fix
I am closing this issue because CodeRay was removed in Redmine 4.0.0 (#24681) and the current application.css does not have the styles.
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by