Project

General

Profile

Actions
Copy link

Feature #24927

closed

Render high resolution Gravatars and Thumbnails

Added by Jan from Planio www.plan.io about 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
UI
Target version:
3.4.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

In addition to #24922, this patch implements hi-res support for Gravatars and Thumbnails using the srcset attribute. Only a DPR of 2x is supported currently.

Here, the patch will actually use separate URLs for 1x and 2x images, so that browsers supporting srcset will only load the appropriate image and will not need to scale on the client.

Files

Download all files
0002-Hires-2x-DPR-image-support-for-Thumbnails.patch (897 Bytes) 0002-Hires-2x-DPR-image-support-for-Thumbnails.patch Jan from Planio www.plan.io, 2017-01-26 12:35
0001-Hires-2x-DPR-image-support-for-Gravatars.patch (914 Bytes) 0001-Hires-2x-DPR-image-support-for-Gravatars.patch Jan from Planio www.plan.io, 2017-01-26 13:36
24927-thumbnail-problem-in-firefox.png (73 KB) 24927-thumbnail-problem-in-firefox.png Go MAEDA, 2017-01-28 12:21
0003-Whitespace-only-reorg-of-ApplicationHelper-thumbnail.patch (1.43 KB) 0003-Whitespace-only-reorg-of-ApplicationHelper-thumbnail.patch Jan from Planio www.plan.io, 2017-01-28 19:19
0004-set-thumbnail-width-on-image-tag-to-avoid-too-wide-w.patch (958 Bytes) 0004-set-thumbnail-width-on-image-tag-to-avoid-too-wide-w.patch Jan from Planio www.plan.io, 2017-01-28 19:19
24927-effect-gravatar.png (79.5 KB) 24927-effect-gravatar.png Go MAEDA, 2017-01-29 03:43

Related issues

Related to Redmine - Feature #24922: Support high resolution images in formatted contentClosedJean-Philippe Lang

Actions
Related to Redmine - Feature #11757: Add support for HDPI screens (retina)New

Actions
Blocked by Redmine - Defect #24935: Gravatar icons in activity view are broken on r15858 and laterClosedJean-Philippe Lang

Actions
Actions
Copy link
 #1

Updated by Jan from Planio www.plan.io about 7 years ago

  • Related to Feature #24922: Support high resolution images in formatted content added
Actions
Copy link
 #2

Updated by Jan from Planio www.plan.io about 7 years ago

  • File deleted (0001-Hires-2x-DPR-image-support-for-Gravatars.patch)
Actions
Copy link
 #4

Updated by Go MAEDA about 7 years ago

  • Related to Feature #11757: Add support for HDPI screens (retina) added
Actions
Copy link
 #5

Updated by Go MAEDA about 7 years ago

  • Blocked by Defect #24935: Gravatar icons in activity view are broken on r15858 and later added
Actions
Copy link
 #6

Updated by Go MAEDA about 7 years ago

Thanks for the patch. Gravatar icons and thumbnails for HDPI display is beautiful.
But I see strange blank area in Firefox. Could you inspect it?

Actions
Copy link
 #9

Updated by Go MAEDA about 7 years ago

Jan from Planio www.plan.io wrote:

Thanks for pointing this out. I'm adding two more patches which fix this problem.

Thanks, I confirmed that the problem has been fixed.

Actions
Copy link
 #10

Updated by Go MAEDA about 7 years ago

With these patches, we can see sharp Gravatar icons and thumbnails on High DPI monitors.
High DPI monitors are becoming common these days, so I think that this feature should be included in 3.4.0.

Actions
Copy link
 #11

Updated by Jean-Philippe Lang about 7 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Committed, thanks.

Actions
Copy link

Also available in: Atom PDF