Patch #26341

Add useful details to error message

Added by Vincent Robert about 1 month ago. Updated 20 days ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Administration
Target version:4.1.0

Description

When a template is missing, this message is added to the logs:

Missing template, responding with 404

We could complete this message with useful details. For instance:

Missing partial issues/_list_simple with {:locale=>[:fr, :en], :formats=>[:html], :variants=>[], :handlers=>[:erb, :builder, :raw, :ruby, :rsb]}. Searched in:
  * "/redmine/app/views" 

Here is my current patch:

 app/controllers/application_controller.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb
index a05f54077..a71103a89 100644
--- a/app/controllers/application_controller.rb
+++ b/app/controllers/application_controller.rb
@@ -502,8 +502,8 @@ class ApplicationController < ActionController::Base
   end

   # Handler for ActionView::MissingTemplate exception
-  def missing_template
-    logger.warn "Missing template, responding with 404" 
+  def missing_template(exception)
+    logger.warn "Missing template, responding with 404: #{exception}" 
     @project = nil
     render_404
   end
--

patch.diff Magnifier (910 Bytes) Vincent Robert, 2017-07-04 10:29

History

#1 Updated by Pavel Rosick√Ĺ about 1 month ago

+1

#2 Updated by Marius BALTEANU about 1 month ago

+ 1. Very useful.

#3 Updated by Go MAEDA about 1 month ago

  • Target version set to Candidate for next minor release

+1
I also suffered from this error when r16401 was committed.

#4 Updated by Go MAEDA about 1 month ago

  • Target version changed from Candidate for next minor release to 4.1.0

#5 Updated by Go MAEDA about 1 month ago

  • Category set to Administration

#6 Updated by Angelinsky7 Angelinsky7 20 days ago

+1

Also available in: Atom PDF