Feature #26826
Issue filtering by spent time
Status: | Closed | Start date: | ||
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | % Done: | 0% | ||
Category: | Issues filter | |||
Target version: | 4.1.0 | |||
Resolution: |
Description
Hi!
Here's a patch that adds a filter for spent time to IssueQuery. Any chance this could be included in the next 3.3 and 3.4 versions?
Related issues
Associated revisions
Issue filtering by spent time (#26826).
Patch by Tobias Umbach and Takenori TAKAKI.
Group time tracking filters in the filter select list (#26826).
History
#1 Updated by Anonymous over 3 years ago
- File issue-filter-by-spent-time-2.diff
added
Here's an updated patch based on feedback that meineerde gave me on IRC.
- An unknown operator leads to invalid SQL,
return nil
early instead NUMERIC
is a non-standard PostgreSQL type, useDECIMAL
instead
#2
Updated by Toshi MARUYAMA over 3 years ago
- Target version set to 4.1.0
#3
Updated by Mischa The Evil almost 3 years ago
- Duplicated by Feature #13947: Add spent time issue list filter added
#4
Updated by Go MAEDA over 2 years ago
- File 26826-note4-before@2x.png added
- File 26826-note4-after@2x.png added
- File issue-filter-by-spent-time-3.diff
added
I think it would be better to move the position of "Spent time" filter in the filters list. The reasons are as follows:
- The proposed patch places the filter in the third position. I think it is a too excellent position for the filter because most users don't use the filter so frequently.
- "Spent time" and "Estimated time" are closely related to each other. These two filters should be next to each other.
Attaching an updated patch.
Before:
After:
#5
Updated by Takenori TAKAKI over 2 years ago
- File issue-filter-by-spent-time-4.diff
added
I tested the patch "issue-filter-by-spent-time-3.diff" posted by Go Maeda.
As a result, I found that it is necessary to add a fixture of time_entrys to the test code "test/unit/query_test.rb".
Tests were done with MySQL, PostgreSQL, SQLite and all succeeded.
I attach a new patch that added fixture.
#6
Updated by Takenori TAKAKI over 2 years ago
- File issue-filter-by-spent-time-5.diff
added
I noticed that 'expected' and 'actual' are reversed on the added assertions.
Attaching an updated patch.
#7
Updated by Go MAEDA over 1 year ago
- Status changed from New to Closed
- Assignee set to Go MAEDA
Committed the patch. Thank you for improving Redmine.
#8
Updated by Jean-Philippe Lang about 1 year ago
- Tracker changed from Patch to Feature