Project

General

Profile

Actions

Feature #26826

closed

Issue filtering by spent time

Added by Anonymous over 5 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Issues filter
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:

Description

Hi!

Here's a patch that adds a filter for spent time to IssueQuery. Any chance this could be included in the next 3.3 and 3.4 versions?


Files

issue-filter-by-spent-time.diff (2.88 KB) issue-filter-by-spent-time.diff Anonymous, 2017-09-01 14:50
issue-filter-by-spent-time-2.diff (2.94 KB) issue-filter-by-spent-time-2.diff Anonymous, 2017-09-15 15:56
26826-note4-before@2x.png (55 KB) 26826-note4-before@2x.png Go MAEDA, 2018-05-13 14:24
26826-note4-after@2x.png (54.6 KB) 26826-note4-after@2x.png Go MAEDA, 2018-05-13 14:30
issue-filter-by-spent-time-3.diff (2.69 KB) issue-filter-by-spent-time-3.diff moves the position of "Spent time" filter Go MAEDA, 2018-05-13 14:35
issue-filter-by-spent-time-4.diff (2.82 KB) issue-filter-by-spent-time-4.diff Takenori TAKAKI, 2018-09-20 08:58
issue-filter-by-spent-time-5.diff (2.82 KB) issue-filter-by-spent-time-5.diff Takenori TAKAKI, 2018-09-20 09:53

Related issues

Related to Redmine - Feature #35798: Add Total estimated/spent time issue query filtersNew

Actions
Has duplicate Redmine - Feature #13947: Add spent time issue list filterClosed

Actions
Actions #1

Updated by Anonymous over 5 years ago

Here's an updated patch based on feedback that meineerde gave me on IRC.

  • An unknown operator leads to invalid SQL, return nil early instead
  • NUMERIC is a non-standard PostgreSQL type, use DECIMAL instead
Actions #2

Updated by Toshi MARUYAMA over 5 years ago

  • Target version set to 4.1.0
Actions #3

Updated by Mischa The Evil about 5 years ago

  • Has duplicate Feature #13947: Add spent time issue list filter added
Actions #4

Updated by Go MAEDA almost 5 years ago

I think it would be better to move the position of "Spent time" filter in the filters list. The reasons are as follows:

  • The proposed patch places the filter in the third position. I think it is a too excellent position for the filter because most users don't use the filter so frequently.
  • "Spent time" and "Estimated time" are closely related to each other. These two filters should be next to each other.

Attaching an updated patch.

Before:

After:

Actions #5

Updated by Takenori TAKAKI over 4 years ago

I tested the patch "issue-filter-by-spent-time-3.diff" posted by Go Maeda.
As a result, I found that it is necessary to add a fixture of time_entrys to the test code "test/unit/query_test.rb".
Tests were done with MySQL, PostgreSQL, SQLite and all succeeded.
I attach a new patch that added fixture.

Actions #6

Updated by Takenori TAKAKI over 4 years ago

I noticed that 'expected' and 'actual' are reversed on the added assertions.
Attaching an updated patch.

Actions #7

Updated by Go MAEDA almost 4 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch. Thank you for improving Redmine.

Actions #8

Updated by Jean-Philippe Lang over 3 years ago

  • Tracker changed from Patch to Feature
Actions #9

Updated by Mischa The Evil over 1 year ago

  • Related to Feature #35798: Add Total estimated/spent time issue query filters added
Actions

Also available in: Atom PDF