Feature #26826
closed
Issue filtering by spent time
Added by Anonymous over 6 years ago. Updated over 4 years ago.
0%
Description
Hi!
Here's a patch that adds a filter for spent time to IssueQuery. Any chance this could be included in the next 3.3 and 3.4 versions?
Files
| issue-filter-by-spent-time.diff (2.88 KB) issue-filter-by-spent-time.diff | Anonymous, 2017-09-01 14:50 | ||
| issue-filter-by-spent-time-2.diff (2.94 KB) issue-filter-by-spent-time-2.diff | Anonymous, 2017-09-15 15:56 | ||
| 26826-note4-before@2x.png (55 KB) 26826-note4-before@2x.png | Go MAEDA, 2018-05-13 14:24 | ||
| 26826-note4-after@2x.png (54.6 KB) 26826-note4-after@2x.png | Go MAEDA, 2018-05-13 14:30 | ||
| issue-filter-by-spent-time-3.diff (2.69 KB) issue-filter-by-spent-time-3.diff | moves the position of "Spent time" filter | Go MAEDA, 2018-05-13 14:35 | |
| issue-filter-by-spent-time-4.diff (2.82 KB) issue-filter-by-spent-time-4.diff | Takenori TAKAKI, 2018-09-20 08:58 | ||
| issue-filter-by-spent-time-5.diff (2.82 KB) issue-filter-by-spent-time-5.diff | Takenori TAKAKI, 2018-09-20 09:53 |
Related issues
Updated by Anonymous over 6 years ago
Here's an updated patch based on feedback that meineerde gave me on IRC.
- An unknown operator leads to invalid SQL,
return nilearly instead NUMERICis a non-standard PostgreSQL type, useDECIMALinstead
Updated by Toshi MARUYAMA
Updated by Mischa The Evil about 6 years ago
- Has duplicate Feature #13947: Add spent time issue list filter added
Updated by Go MAEDA almost 6 years ago
- File 26826-note4-before@2x.png 26826-note4-before@2x.png added
- File 26826-note4-after@2x.png 26826-note4-after@2x.png added
- File issue-filter-by-spent-time-3.diff issue-filter-by-spent-time-3.diff added
I think it would be better to move the position of "Spent time" filter in the filters list. The reasons are as follows:
- The proposed patch places the filter in the third position. I think it is a too excellent position for the filter because most users don't use the filter so frequently.
- "Spent time" and "Estimated time" are closely related to each other. These two filters should be next to each other.
Attaching an updated patch.
Before:
After:
Updated by Takenori TAKAKI over 5 years ago
I tested the patch "issue-filter-by-spent-time-3.diff" posted by Go Maeda.
As a result, I found that it is necessary to add a fixture of time_entrys to the test code "test/unit/query_test.rb".
Tests were done with MySQL, PostgreSQL, SQLite and all succeeded.
I attach a new patch that added fixture.
Updated by Takenori TAKAKI over 5 years ago
I noticed that 'expected' and 'actual' are reversed on the added assertions.
Attaching an updated patch.
Updated by Go MAEDA almost 5 years ago
- Status changed from New to Closed
- Assignee set to Go MAEDA
Committed the patch. Thank you for improving Redmine.
Updated by Jean-Philippe Lang over 4 years ago
- Tracker changed from Patch to Feature
Updated by Mischa The Evil over 2 years ago
- Related to Feature #35798: Add Total estimated/spent time issue query filters added