Feature #27096

Mark non-working days in calendar view

Added by Maxim KruĊĦina over 1 year ago. Updated 4 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Calendar
Target version:4.1.0
Resolution:Fixed

Description

In global settings, we can set which are / are not working days - it should be nice to have it visually marked in project's calendar view

non-working-days.png (322 KB) Marius BALTEANU, 2018-09-05 21:10

0001-Move-calendar-day-classes-to-a-helper.patch Magnifier (1.61 KB) Marius BALTEANU, 2018-12-18 07:37

0002-Add-nwday-class-to-non-working-days-in-calendar.patch Magnifier (2.52 KB) Marius BALTEANU, 2019-01-07 05:11

Associated revisions

Revision 17797
Added by Go MAEDA 4 months ago

Move calendar day classes to a helper (#27096).

Patch by Marius BALTEANU.

Revision 17798
Added by Go MAEDA 4 months ago

Add "nwday" class to non-working days in calendar (#27096).

Patch by Marius BALTEANU.

Revision 17799
Added by Go MAEDA 4 months ago

Add a style for non-working days in calendar (#27096).

Patch by Go MAEDA.

History

#1 Updated by Mischa The Evil over 1 year ago

  • Category set to Calendar

#2 Updated by Toshi MARUYAMA over 1 year ago

  • Description updated (diff)

#3 Updated by Marius BALTEANU 9 months ago

Maybe we can grey-out the non working days using the same style like the days from other months? Something like that:

#4 Updated by Go MAEDA 7 months ago

Marius BALTEANU wrote:

Maybe we can grey-out the non working days using the same style like the days from other months?

+1
I think it would be even better to use a different background color from dates of previous/next months.

#5 Updated by Marius BALTEANU 7 months ago

  • Assignee set to Marius BALTEANU

Go MAEDA wrote:

+1
I think it would be even better to use a different background color from dates of previous/next months.

Yes, it could be an option. Let me see what can I do.

#6 Updated by Marius BALTEANU 5 months ago

  • File 0001-Move-calendar-day-classes-to-a-helper.patchMagnifier added
  • File 0002-Add-non-working-class-to-non-working-days-in-calenda.patch added
  • Assignee changed from Marius BALTEANU to Go MAEDA
  • Target version set to Candidate for next major release

Go Maeda, attached the patches that mark the non working days in the calendars from Projects and My Page. I didn't apply any style on the class because I didn't have any idea (apart from the same style as the one from days from other month). Please feel free to add a style to my patches.

#7 Updated by Marius BALTEANU 5 months ago

Go Maeda, did you have the chance to look over this feature?

#8 Updated by Go MAEDA 5 months ago

  • Assignee changed from Go MAEDA to Marius BALTEANU

Marius, thank you for writing the patch.

It looks OK except one thing. Do you think it is OK that the class name for non-working days is different from gantt? Although gantt already uses "nwday", your patch uses "non-working".

#9 Updated by Marius BALTEANU 5 months ago

  • File deleted (0002-Add-non-working-class-to-non-working-days-in-calenda.patch)

#10 Updated by Marius BALTEANU 5 months ago

Go MAEDA wrote:

It looks OK except one thing. Do you think it is OK that the class name for non-working days is different from gantt? Although gantt already uses "nwday", your patch uses "non-working".

For sure we should use the existing "nwday" class, but I didn't know about it. I've updated my second patch, thanks for pointing out.

Tests results here: https://gitlab.com/marius-balteanu/redmine/-/jobs/142133626

#11 Updated by Go MAEDA 5 months ago

  • Target version changed from Candidate for next major release to 4.1.0

Thank you for updating the patch, it looks good. Setting the target version to 4.1.0.

#12 Updated by Go MAEDA 4 months ago

  • Status changed from New to Closed
  • Resolution set to Fixed

Committed the patches. Thank you for improving Redmine.

And I have added a style for non-working days. The background color is the same with non-working days in gantt.

#13 Updated by Go MAEDA 4 months ago

  • Subject changed from Mark (somehow) non-working days in calendar view to Mark non-working days in calendar view

Also available in: Atom PDF