Project

General

Profile

Actions

Feature #28085

closed

Wiki Toolbar on Full Width Custom Fields

Added by Stephen Stuart about 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Custom fields
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Duplicate

Description

Upon upgrading to version 3.4.4 we noticed we now have the ability to have custom long text fields with Full Width Layout and Text Formatting options.

When editing an issue, fields with these options should also have the wiki toolbar displayed.

We were able to make it appear by adding a call to wikitoolbar_for in app/views/issues/_form_custom_fields.html.erb as follows:

<% custom_field_values_full_width.each do |value| %>
  <p><%= custom_field_tag_with_label :issue, value, :required => @issue.required_attribute?(value.custom_field_id) %>
  <%= wikitoolbar_for custom_field_tag_id :issue, value.custom_field %>
  </p>
<% end %>

Note that I'm not checking the Text Formatting option so all full width fields have the toolbar.


Files

patch.txt (7.89 KB) patch.txt Osamu Murayama, 2018-02-07 12:28
wiki-toolbar-and-preview-for-full-width-cf@2x.png (40.8 KB) wiki-toolbar-and-preview-for-full-width-cf@2x.png Go MAEDA, 2018-02-20 15:29
patch.patch (7.89 KB) patch.patch Same patch as note-1, but with correct extension. Mischa The Evil, 2018-02-24 00:42

Related issues

Related to Redmine - Patch #21705: Option for long text custom fields to be displayed using full widthClosedJean-Philippe Lang

Actions
Is duplicate of Redmine - Feature #29712: Preview and wiki toolbar for full width custom fieldsClosedGo MAEDA

Actions
Actions #1

Updated by Osamu Murayama about 6 years ago

I upload my patch. All (not only issue's) custom fields which format_type "text" and text_formatting "full" have the wiki toolbar in there edit forms.
And you can preview at "project setting" and issue's form.

Actions #2

Updated by Mischa The Evil about 6 years ago

  • Related to Patch #21705: Option for long text custom fields to be displayed using full width added
Actions #3

Updated by Go MAEDA about 6 years ago

Osamu Murayama, thank you for sharing the patch. Preview for full-width custom fields is especially nice.

Marius, could you review this patch? I think you are the right person to check this patch because you implemented full-width custom fields (#21705) and now working to improve preview (#27758).

Actions #4

Updated by Marius BĂLTEANU about 6 years ago

Go MAEDA wrote:

Marius, could you review this patch? I think you are the right person to check this patch because you implemented full-width custom fields (#21705) and now working to improve preview (#27758).

Go MAEDA, I'll be happy to review this patch, but first I would like to take a call regarding #27758. I think that this feature can be implemented easier after the preview tab is added to the core.

Actions #5

Updated by Mischa The Evil about 6 years ago

I'll attach the same patch, but renamed so that it is recognized by Redmine as a patch (which will ease the review process of it).

Actions #6

Updated by Go MAEDA over 5 years ago

  • Related to Feature #29712: Preview and wiki toolbar for full width custom fields added
Actions #7

Updated by Marius BĂLTEANU over 5 years ago

  • Related to deleted (Feature #29712: Preview and wiki toolbar for full width custom fields)
Actions #8

Updated by Marius BĂLTEANU over 5 years ago

  • Is duplicate of Feature #29712: Preview and wiki toolbar for full width custom fields added
Actions #9

Updated by Marius BĂLTEANU over 5 years ago

  • Status changed from New to Closed
  • Target version deleted (Candidate for next major release)
  • Resolution set to Duplicate

I'm closing this in favour of #29712 where we started the discussions to implement this feature.

Actions

Also available in: Atom PDF