Redmine

Hi Kamil,

I have added these shortcuts to my Redmine Shortcuts Plugin.
Try it if you want.

Davide

Davide,

I've installed 0.2.0 version but it doesn't seem to work.
Both (while creating and editing) it displays browser popup "do you really want to leave this site"?

Redmine version?

3.4.6.stable

+1

Many apps or services such as Gitlab, GitHub, Gmail, Outlook, Slack, Facebook, and Twitter support submitting a form by hitting Ctrl+Enter / ⌘+Return. I think that a lot of users are familiar with this shortcut key.

Redmine will be able to provide consistent UI with many other apps if the key combination is supported.

The patch can be simplified as follows.

diff --git a/public/javascripts/application.js b/public/javascripts/application.js
index 7076aabcb..825d96c88 100644
--- a/public/javascripts/application.js
+++ b/public/javascripts/application.js
@@ -851,6 +851,14 @@ function setupFilePreviewNavigation() {
   }
 }

+$(document).on('keydown', 'form textarea', function(e) {
+  // Submit the form with Ctrl + Enter or Command + Return
+  var targetForm = $(e.target).closest('form');
+  if(e.keyCode == 13 && ((e.ctrlKey && !e.metaKey) || (!e.ctrlKey && e.metaKey) && targetForm.length)) {
+    $(e.target).closest('form').find('textarea').blur().removeData('changed');
+    targetForm.submit();
+  }
+});

 function hideOnLoad() {

• It is not necessary to process keydown events for input[type="text"] because it submits the form by pressing Enter/Return by default. The form is submitted also by Ctrl+Enter/Option+Return
• If the keydown for input is removed, submit() can always be used. we don't have to use both click() and submit() as attachment:feature-29473-v2.patch do. Modal dialogs to add a category or a target version also works as expected

Go MAEDA wrote:

The patch can be simplified as follows.

[...]

• It is not necessary to process keydown events for input[type="text"] because it submits the form by pressing Enter/Return by default. The form is submitted also by Ctrl+Enter/Option+Return
• If the keydown for input is removed, submit() can always be used. we don't have to use both click() and submit() as attachment:feature-29473-v2.patch do. Modal dialogs to add a category or a target version also works as expected

That looks good.