Patch #31356

replace icon-fav with icon-user for 'my projects'

Added by Jens Krämer 7 days ago. Updated 6 days ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Projects
Target version:4.1.0

0001-feature-my-projects-fav-user-icon.patch Magnifier (1.59 KB) Jens Krämer, 2019-05-13 11:06

31356-before@2x.png (38.1 KB) Go MAEDA, 2019-05-13 11:22

31356-after@2x.png (40.3 KB) Go MAEDA, 2019-05-13 11:22

0001-swaps-out-the-icon-fav-for-icon-user-on-projects-ind.patch Magnifier - updated patch that keeps the icon positioning at the end of the project name (2.3 KB) Jens Krämer, 2019-05-13 13:28


Related issues

Related to Redmine - Patch #31355: Bookmarks and recently used projects for the project jump... New

Associated revisions

Revision 18164
Added by Go MAEDA 6 days ago

Swaps out the icon-fav for icon-user on projects#index (#31356).

Patch by Jens Krämer.

History

#1 Updated by Jens Krämer 7 days ago

While working on #31355 we (Planio, that is) found that using the fav icon that is also used for watching things is not really appropriate for designating projects the user is a member of. We'd vote for replacing this with the user icon instead on the All projects list, which is what the attached patch does.

#2 Updated by Go MAEDA 7 days ago

[Before]

[After]

#3 Updated by Go MAEDA 7 days ago

  • Related to Patch #31355: Bookmarks and recently used projects for the project jump box added

#4 Updated by Jens Krämer 7 days ago

updated patch that keeps the icon positioning at the end of the project name

#5 Updated by Go MAEDA 6 days ago

  • Category set to Projects
  • Target version changed from Candidate for next major release to 4.1.0

I am in favor of this change.

The current "My project" icon "★" is used as a "Watch" icon in other pages. Therefore, it looks as if those are watched projects (some notifications are sent).

Since "My projects" means "the projects I am a member of", I think that using "icon-user" is reasonable.

Setting the target version to 4.1.0.

#6 Updated by Marius BALTEANU 6 days ago

I'm in favour too.

#7 Updated by Go MAEDA 6 days ago

  • Subject changed from replace icon-fav with icon-user for 'my projects to replace icon-fav with icon-user for 'my projects'
  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch. Thanks.

Also available in: Atom PDF