Patch #32922: Reload detached attachments - Redmine

Custom queries

Documentation issues
Open defects
Open features
Patch queue
Plugin issues
Translation patches

Actions

Copy link

Patch #32922

closed

Reload detached attachments

Added by Pavel Rosický about 4 years ago. Updated about 3 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Go MAEDA

Category:

Code cleanup/refactoring

Target version:

5.0.0

Start date:

Due date:

% Done:

Estimated time:

Description

use #reload instead, after upgrading to Rails 5

Files

acts_as_attachable.rb.patch (552 Bytes) acts_as_attachable.rb.patch

Pavel Rosický, 2020-01-30 00:56

Related issues

Related to Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading

Closed

Go MAEDA

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Marius BĂLTEANU about 4 years ago

Thanks Pavel for posting the patches for Rails 6 update.

I've applied this patch on the current trunk and a test fails:

 Failure:
 AttachmentsTest#test_upload_and_resubmit_after_validation_failure [/builds/redmine-org/redmine/test/integration/attachments_test.rb:113]:
 Expected at least 1 element matching "input[name="attachments[p0][description]"][value="My uploaded file"]", found 0..
 Expected 0 to be >= 1.
 bin/rails test test/integration/attachments_test.rb:99

You can see the test results here.

Actions

Copy link