Pavel Rosický wrote:
@marius - I see you've finally started working on this. Just to let you know, there's a mistake in this patch. The removed part simply shouldn't be removed, the rest is ok. I'll send you a few other patches because there was a new major release of Rails and Ruby since the last time :)
Indeed, I've started work on preparing patches to update Rails to latest version (6.1.3.1) and you can see here the results. I've only 3 failing tests, 2 are caused by this patch and one I need to investigate because it passes on my local environment.
Anyway, please take a look on all the commits that I've pushed and feel free to post new patches or improved solutions for the existing patches.
My plan is the following:
- first priority: make all the tests pass (I will post the patches on #29914)
- refactor some existing solutions (on separate issues)
- adopt some new Rails features (like Zeitwerk) (on separate issues)
- inform Jean-Philippe that we have the patches ready for review and hopefully, we get an approval from him to commit them as soon as possible.
Pavel, thank you for all of your work on this, your patches were really useful.