Project

General

Profile

Actions

Defect #32973

closed

Editing a time entry for a locked user changes the user to the current user

Defect #32973: Editing a time entry for a locked user changes the user to the current user

Added by Marius BĂLTEANU almost 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Category:
Time tracking
Target version:
Resolution:
Fixed
Affected version:

Description

Steps to reproduce:

1. Add a time entry for another user (B)
2. Lock that user (B)
3. Edit the time entry
4. Observe that field User is selected with "me".

Saving the time entry, it will lose the user.


Files


Related issues 2 (0 open — 2 closed)

Related to Redmine - Feature #3848: Permission to log time for another userClosedJean-Philippe LangActions
Related to Redmine - Defect #33341: Time entry user is shown twice in the User drop-down when editing spent timeClosedGo MAEDAActions

Updated by Marius BĂLTEANU almost 7 years ago Actions #1

  • Related to Feature #3848: Permission to log time for another user added

Updated by Marius BĂLTEANU almost 7 years ago Actions #2

I see two options to fix this:

1. We don't allow changing the user when the time entry is logged on a locked user.
2. We add the locked user to the list of users.

Updated by Go MAEDA almost 7 years ago Actions #3

Marius BALTEANU wrote:

I see two options to fix this:

1. We don't allow changing the user when the time entry is logged on a locked user.
2. We add the locked user to the list of users.

I think the second option is better because the limitation suggested in option 1 may confuse users. In my opinion, there is no reason to disallow changing the user when the user of the time entry is locked.

Updated by Marius BĂLTEANU almost 7 years ago Actions #4

Here is the fix for the second option, but I would like a double check on the solution. The second patch renames and reorders the test added in #32959.

All tests pass: https://gitlab.com/redmine-org/redmine/pipelines/116292306

Updated by Jean-Philippe Lang over 6 years ago Actions #5

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Committed and merged, thanks!

Updated by Go MAEDA over 6 years ago Actions #6

  • Related to Defect #33341: Time entry user is shown twice in the User drop-down when editing spent time added
Actions

Also available in: PDF Atom