Defect #33341
Time entry user is shown twice in the User drop-down when editing spent time
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Go MAEDA | % Done: | 0% | |
| Category: | Time tracking | |||
| Target version: | 4.1.2 | |||
| Resolution: | Fixed | Affected version: | 4.1.1 |
Description
Hi,
When editing Spent Time the current time entry user is shown twice in the User drop-down.
This is because the condition to add the current time entry user to the collection is wrong in TimelogHelper#user_collection_for_select_options.
It is:
collection << time_entry.user unless time_entry.user.nil? && !collection.include?(time_entry.user)But it should be:
collection << time_entry.user if time_entry.user && !collection.include?(time_entry.user)Best regards,
Thomas
timelog_helper.diff 
(686 Bytes)
33341-screenshot.png (109 KB)
0001-Fix-time-entry-user-is-shown-twice-in-the-User-drop-.patch
(1.51 KB)
Related issues
Associated revisions
Fix time entry user is shown twice in the User drop-down (#33341).
Patch by Thomas Löber and Marius BALTEANU.
History
#1
Updated by Go MAEDA 4 months ago
- File 33341-screenshot.png added
- Status changed from New to Confirmed
- Affected version set to 4.1.0
#3
Updated by Go MAEDA 4 months ago
- Related to Defect #32973: Editing a time entry for a locked user changes the user to the current user added
#5
Updated by Marius BALTEANU 4 months ago
The fix looks good to me. The attached patch contains the fix and an assertion.
Tests pass: https://gitlab.com/redmine-org/redmine/pipelines/139995890
#6
Updated by Go MAEDA 4 months ago
- Subject changed from When editing Spent Time the current time entry user is shown twice in the User drop-down to Time entry user is shown twice in the User drop-down when editing spent time
- Status changed from Confirmed to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the fix. Thank you.