Project

General

Profile

Actions
Copy link

Patch #35396

closed

Use base_scope for issue query results

Added by Alexander Meindl almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Code cleanup/refactoring
Target version:
5.0.0

Description

This is some refactoring, which drops redundant definition of query scope. With this change, base_scope is used for issues.

Second advantage is, plugin developer can overwrite base_scope to include more features (e.g. for search filter).

There are no downsides with it.

Files

Download all files
issues_with_base_scope.patch (550 Bytes) issues_with_base_scope.patch Alexander Meindl, 2021-06-10 18:59
issues_with_base_scope_v2.patch (938 Bytes) issues_with_base_scope_v2.patch Alexander Meindl, 2021-06-10 19:06
Actions
Copy link
 #1

Updated by Alexander Meindl almost 5 years ago

I created a second patch, which also uses base_scope for issue_ids.

Actions
Copy link
 #2

Updated by Go MAEDA almost 5 years ago

  • Category changed from Issues list to Code cleanup/refactoring
  • Target version set to Candidate for next major release

IssueQuery#base_scope was added in r14642. I think the proposed changes should have been included in r14642.

Actions
Copy link
 #3

Updated by Go MAEDA almost 5 years ago

  • Target version changed from Candidate for next major release to 5.0.0

Setting the target version to 5.0.0.

Actions
Copy link
 #4

Updated by Go MAEDA almost 5 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch. Thank you.

Actions
Copy link

Also available in: Atom PDF