Defect #37730: Missing copyright headers in source files - Redmine

Actions

Copy link

Defect #37730

closed

Missing copyright headers in source files

Added by Mischa The Evil over 1 year ago. Updated 4 months ago.

Status:

Closed

Priority:

Normal

Assignee:

Marius BĂLTEANU

Category:

Code cleanup/refactoring

Target version:

6.0.0

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Affected version:

Description

The source files in the following list are missing proper copyright headers:

View file list...View file list...

source:/trunk/public/javascripts/responsive.js

source:/trunk/lib/redmine/core_ext/string.rb
source:/trunk/lib/redmine/scm/base.rb
source:/trunk/lib/redmine/codeset_util.rb
source:/trunk/lib/redmine/core_ext.rb
source:/trunk/lib/redmine/info.rb
source:/trunk/lib/redmine/notifiable.rb
source:/trunk/lib/redmine/sudo_mode.rb
source:/trunk/lib/redmine/version.rb

source:/trunk/lib/plugins/acts_as_activity_provider/init.rb
source:/trunk/lib/plugins/acts_as_attachable/init.rb
source:/trunk/lib/plugins/acts_as_customizable/init.rb
source:/trunk/lib/plugins/acts_as_event/init.rb
source:/trunk/lib/plugins/acts_as_searchable/init.rb
source:/trunk/lib/plugins/acts_as_watchable/init.rb
source:/trunk/lib/plugins/acts_as_watchable/lib/acts_as_watchable.rb

source:/trunk/lib/tasks/ci.rake
source:/trunk/lib/tasks/deprecated.rake
source:/trunk/lib/tasks/extract_fixtures.rake
source:/trunk/lib/tasks/initializers.rake
source:/trunk/lib/tasks/load_default_data.rake
source:/trunk/lib/tasks/locales.rake
source:/trunk/lib/tasks/metrics.rake
source:/trunk/lib/tasks/permissions.rake
source:/trunk/lib/tasks/testing.rake
source:/trunk/lib/tasks/yardoc.rake

source:/trunk/public/stylesheets/application.css
source:/trunk/public/stylesheets/context_menu.css
source:/trunk/public/stylesheets/context_menu_rtl.css
source:/trunk/public/stylesheets/jstoolbar.css¹
source:/trunk/public/stylesheets/responsive.css
source:/trunk/public/stylesheets/rtl.css
source:/trunk/public/stylesheets/scm.css

source:/trunk/public/themes/alternate/stylesheets/application.css
source:/trunk/public/themes/classic/stylesheets/application.css

Given that all these files are distributed as part of the Redmine core, I'd say that it would be correct if each of them would contain appropriate copyright headers (even the plugin initialization, rake task and CSS files).

¹ since the content of this file is derived from DotClear, it might be correct to add the original DotClear copyright headers (like e.g. source:/trunk/public/javascripts/jstoolbar) to this file.

Files

Karel Pičman, 2023-10-10 14:48

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Go MAEDA over 1 year ago

Target version set to 5.1.0

Actions

Copy link

Updated by Go MAEDA 7 months ago

Target version changed from 5.1.0 to 6.0.0

Actions

Copy link

Updated by Karel Pičman 7 months ago

File copyright.diff copyright.diff added

Here is a patch covering missing copyright headers.

Actions

Copy link

Updated by Marius BĂLTEANU 6 months ago

Status changed from New to Closed
Assignee set to Marius BĂLTEANU
Resolution set to Fixed

Committed, thanks!

Actions

Copy link

Updated by Mischa The Evil 5 months ago

Status changed from Closed to Reopened

Thanks for fixing this. However, given our current asset serving mechanism, I'd have chosen to only add a short copyright notice to the CSS and JS assets instead.
With the current change we increase bandwidth usage more than necessary IMHO and as such we might want to (re-)consider this...

Actions

Copy link

Updated by Mischa The Evil 5 months ago

Additionally, r22482 also adds a header to acts_as_tree plugin files, which is obviously incorrect (it's in fact a vendored third-party core component, see source:/trunk/lib/plugins/acts_as_tree/README).

Actions

Copy link

Updated by Marius BĂLTEANU 4 months ago

Thanks Mischa for review the changes, I have fixed now all the reported issues.

Actions

Copy link

Updated by Marius BĂLTEANU 4 months ago

Status changed from Reopened to Closed

Actions

Copy link

Updated by Go MAEDA 4 months ago

Status changed from Closed to Reopened

I think we should not add Redmine's copyright header to source:trunk/public/stylesheets/tribute-5.1.3.css because the file is a part of Tribute distribution.

https://github.com/zurb/tribute/blob/master/dist/tribute.css

Actions

Copy link

#10

Updated by Marius BĂLTEANU 4 months ago

Status changed from Reopened to Closed

Go MAEDA wrote in #note-9:

I think we should not add Redmine's copyright header to source:trunk/public/stylesheets/tribute-5.1.3.css because the file is a part of Tribute distribution.

https://github.com/zurb/tribute/blob/master/dist/tribute.css

Agree, fixed, thanks!

Actions

Copy link

Also available in: Atom PDF

Project

General

Profile

Redmine

Custom queries

Defect #37730

Missing copyright headers in source files

Updated by Go MAEDA over 1 year ago

Updated by Go MAEDA 7 months ago

Updated by Karel Pičman 7 months ago

Updated by Marius BĂLTEANU 6 months ago

Updated by Mischa The Evil 5 months ago

Updated by Mischa The Evil 5 months ago

Updated by Marius BĂLTEANU 4 months ago

Updated by Marius BĂLTEANU 4 months ago

Updated by Go MAEDA 4 months ago

Updated by Marius BĂLTEANU 4 months ago