Defect #37730
closed
Missing copyright headers in source files
Added by Mischa The Evil over 3 years ago.
Updated over 2 years ago.
Category:
Code cleanup/refactoring
Description
The source files in the following list are missing proper copyright headers:
View file list...View file list...
- source:/trunk/public/javascripts/responsive.js
- source:/trunk/lib/redmine/core_ext/string.rb
- source:/trunk/lib/redmine/scm/base.rb
- source:/trunk/lib/redmine/codeset_util.rb
- source:/trunk/lib/redmine/core_ext.rb
- source:/trunk/lib/redmine/info.rb
- source:/trunk/lib/redmine/notifiable.rb
- source:/trunk/lib/redmine/sudo_mode.rb
- source:/trunk/lib/redmine/version.rb
- source:/trunk/lib/plugins/acts_as_activity_provider/init.rb
- source:/trunk/lib/plugins/acts_as_attachable/init.rb
- source:/trunk/lib/plugins/acts_as_customizable/init.rb
- source:/trunk/lib/plugins/acts_as_event/init.rb
- source:/trunk/lib/plugins/acts_as_searchable/init.rb
- source:/trunk/lib/plugins/acts_as_watchable/init.rb
- source:/trunk/lib/plugins/acts_as_watchable/lib/acts_as_watchable.rb
- source:/trunk/lib/tasks/ci.rake
- source:/trunk/lib/tasks/deprecated.rake
- source:/trunk/lib/tasks/extract_fixtures.rake
- source:/trunk/lib/tasks/initializers.rake
- source:/trunk/lib/tasks/load_default_data.rake
- source:/trunk/lib/tasks/locales.rake
- source:/trunk/lib/tasks/metrics.rake
- source:/trunk/lib/tasks/permissions.rake
- source:/trunk/lib/tasks/testing.rake
- source:/trunk/lib/tasks/yardoc.rake
- source:/trunk/public/stylesheets/application.css
- source:/trunk/public/stylesheets/context_menu.css
- source:/trunk/public/stylesheets/context_menu_rtl.css
- source:/trunk/public/stylesheets/jstoolbar.css1
- source:/trunk/public/stylesheets/responsive.css
- source:/trunk/public/stylesheets/rtl.css
- source:/trunk/public/stylesheets/scm.css
- source:/trunk/public/themes/alternate/stylesheets/application.css
- source:/trunk/public/themes/classic/stylesheets/application.css
Given that all these files are distributed as part of the Redmine core, I'd say that it would be correct if each of them would contain appropriate copyright headers (even the plugin initialization, rake task and CSS files).
Files
- Target version set to 5.1.0
- Target version changed from 5.1.0 to 6.0.0
Here is a patch covering missing copyright headers.
- Status changed from New to Closed
- Assignee set to Marius BĂLTEANU
- Resolution set to Fixed
- Status changed from Closed to Reopened
Thanks for fixing this. However, given our current asset serving mechanism, I'd have chosen to only add a short copyright notice to the CSS and JS assets instead.
With the current change we increase bandwidth usage more than necessary IMHO and as such we might want to (re-)consider this...
Thanks Mischa for review the changes, I have fixed now all the reported issues.
- Status changed from Reopened to Closed
- Status changed from Closed to Reopened
- Status changed from Reopened to Closed
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by 
Updated by