Feature #39528
closed
Change mention link color for users without access to view issues
Added by Mizuki ISHIKAWA almost 3 years ago.
Updated 3 days ago.
Description
I propose a feature enhancement for better visibility regarding user permissions and mention notifications. Currently, when a user who does not have the permission to view a particular issue is mentioned, they do not receive a mention notification email. However, this is not visually apparent since the mention link looks identical to others, potentially leading to confusion over whether a notification was sent.
To improve clarity, I suggest altering the background color of mention links for users who cannot view the issue. This visual cue would instantly inform others that the mentioned individual may not be notified due to permission restrictions.
Files
After applying the attached patch, the background colour of the mentions link changes according to access rights as follows.
Minor bugs fixed.
And I created an additional issue because I thought it was likely that just changing the colour in this issue would not convey the intention. (#39529)
- Target version set to Candidate for next major release
- Related to Feature #39529: Add tooltips for clarifying non-notifiable user mentions added
- Assignee set to Marius BĂLTEANU
- Related to Feature #13919: Mention user on issues and wiki pages using @user with autocomplete added
- Target version changed from Candidate for next major release to 7.0.0
I've moved the user mention code into its own method link_to_mention.
Currently, we have four different visual states for user links:
1. @jsmith: User cannot view the mentioned user (Plain text).
2. @John Smith (blue background): User can view the mentioned user.
3. John Smith (no background): User is linked using user:jsmith syntax.
4. @John Smith (#F3EDD1 or other background): User can view the mentioned user, but the mentioned user cannot view the object (Proposed in this issue).
What if we simplify this and show the user with no background by default? We could then change the condition to apply the --oc-blue-0 background only when the mentioned user has access to see the object. This would provide a clear visual distinction without adding a fourth color/state.
Before finalizing this, I’ll run performance tests. Last year, Jean-Philippe mentioned that the mention feature was slowing down redmine.org, which led to changing many links from @login to user:#id. I want to see how each change related to this feature impact the performance
- Target version changed from 7.0.0 to 7.1.0
I've committed the change:
user-current : applied when the mentioned user is the current logged-in user.user-mentionable: applied when the mentioned user has permission to view the target object.
Mentions of users without access to the object fall back to the standard user link style without the mention highlight.
States Overview¶
| State / Condition |
CSS Classes |
Color / Style |
Description |
| Mentionable User (has view permission) |
user-mention user-mentionable |
Light-blue background (--oc-blue-0) |
Highlighted mention style. User is notified. |
| Current User Mentioned |
user-mention user-current user-mentionable |
Orange background (--oc-orange-1) |
Distinct highlight for the logged-in user (ensures contrast on both white notes and yellow issue boxes). |
| Non-mentionable User (no view permission) |
user-mention |
Default link (no background) |
Plain link style. User is not notified. |
Standard User Link (via user:login) |
user |
Default link (no background) |
Standard user profile link without mention styling. |
- Status changed from Resolved to Closed
- Related to Patch #44423: Improve performance when formatting user mentions added
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by