Project

General

Profile

Actions

Patch #40197

open

Update commonmark to 1.1

Added by Marius BĂLTEANU 9 months ago. Updated about 2 months ago.

Status:
New
Priority:
Normal
Category:
Gems support
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:


Files


Related issues

Blocked by Redmine - Feature #38585: Drop Ruby 2.7 and 3.0 supportClosedGo MAEDA

Actions
Actions #1

Updated by Go MAEDA 9 months ago

FYI: CommonMarker 1.0 requires Ruby 3.1.0 or higher. If this change is included in Redmine 6.0.0, Redmine 6.0.0 will drop support for Ruby 3.0 as well as 2.7.

Actions #2

Updated by Go MAEDA 2 months ago

Go MAEDA wrote in #note-1:

FYI: CommonMarker 1.0 requires Ruby 3.1.0 or higher. If this change is included in Redmine 6.0.0, Redmine 6.0.0 will drop support for Ruby 3.0 as well as 2.7.

Due to the migration to Rails 7.2 in #36320#note-42, Redmine now requires Ruby 3.1 and higher.
It is no longer necessary to consider the supported Ruby versions to update the CommonMarker gem.

Actions #3

Updated by Go MAEDA 2 months ago

Actions #4

Updated by Marius BĂLTEANU about 2 months ago

Here is the patch that updates commonmark to 1.1.5. This update switches from libcmark-gfm to comrak/Rust which give us more option in terms of text formatting.

Actions #5

Updated by Marius BĂLTEANU about 2 months ago

Two new patches in addition to the first one:
  • 0002-Simplify-code.patch: just simplify the existing code
  • 0003-Disable-syntax_highlighter-plugin-shipped-by-commonm.patch: disables for now the commonmark plugin for syntax_highlighter.
Actions

Also available in: Atom PDF