Project

General

Profile

Actions

Patch #40197

closed

Update commonmarker to 2.3.0

Added by Marius BĂLTEANU over 1 year ago. Updated 29 days ago.

Status:
Closed
Priority:
Normal
Category:
Gems support
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:


Files


Related issues

Related to Redmine - Patch #42602: Replaces deckar01-task_list with commonmarks tasklist extensionClosedMarius BĂLTEANU

Actions
Related to Redmine - Feature #39130: Common Formatting - Check tasklist item without editing functionNewMarius BĂLTEANU

Actions
Blocked by Redmine - Feature #38585: Drop Ruby 2.7 and 3.0 supportClosedGo MAEDA

Actions
Actions #1

Updated by Go MAEDA over 1 year ago

FYI: CommonMarker 1.0 requires Ruby 3.1.0 or higher. If this change is included in Redmine 6.0.0, Redmine 6.0.0 will drop support for Ruby 3.0 as well as 2.7.

Actions #2

Updated by Go MAEDA 9 months ago

Go MAEDA wrote in #note-1:

FYI: CommonMarker 1.0 requires Ruby 3.1.0 or higher. If this change is included in Redmine 6.0.0, Redmine 6.0.0 will drop support for Ruby 3.0 as well as 2.7.

Due to the migration to Rails 7.2 in #36320#note-42, Redmine now requires Ruby 3.1 and higher.
It is no longer necessary to consider the supported Ruby versions to update the CommonMarker gem.

Actions #3

Updated by Go MAEDA 9 months ago

Actions #4

Updated by Marius BĂLTEANU 9 months ago

Here is the patch that updates commonmark to 1.1.5. This update switches from libcmark-gfm to comrak/Rust which give us more option in terms of text formatting.

Actions #5

Updated by Marius BĂLTEANU 9 months ago

Two new patches in addition to the first one:
  • 0002-Simplify-code.patch: just simplify the existing code
  • 0003-Disable-syntax_highlighter-plugin-shipped-by-commonm.patch: disables for now the commonmark plugin for syntax_highlighter.
Actions #6

Updated by Marius BĂLTEANU 7 months ago

  • Target version changed from 6.0.0 to 6.1.0
Actions #7

Updated by Marius BĂLTEANU 7 months ago

  • Target version changed from 6.1.0 to 6.0.0
Actions #8

Updated by Marius BĂLTEANU 7 months ago

  • Status changed from New to Resolved

I've updated commonmark gem to 1.1.5.

Actions #9

Updated by Marius BĂLTEANU 7 months ago

  • Status changed from Resolved to New
  • Target version changed from 6.0.0 to 6.1.0

I'm postponing this for 6.1.0 in order to fix the CI build.

Actions #10

Updated by Marius BĂLTEANU 6 months ago

  • Status changed from New to Resolved
Actions #11

Updated by Marius BĂLTEANU 6 months ago

Committed the patches again, I'm closing this after we have the CI fixed.

Actions #12

Updated by Marius BĂLTEANU 6 months ago

  • Status changed from Resolved to Closed

The build is passing now, I'm closing this.

Actions #13

Updated by Marius BĂLTEANU about 1 month ago

  • Subject changed from Update commonmark to 1.1 to Update commonmarker to 2.3.0
  • Status changed from Closed to Reopened
Actions #14

Updated by Marius BĂLTEANU about 1 month ago

I've updated commonmarker to latest version, I will create new issues for each feature that I would like to enable.

Actions #15

Updated by Marius BĂLTEANU about 1 month ago

  • Status changed from Reopened to Resolved
Actions #16

Updated by Marius BĂLTEANU about 1 month ago

  • Related to Patch #42602: Replaces deckar01-task_list with commonmarks tasklist extension added
Actions #17

Updated by Marius BĂLTEANU about 1 month ago

  • Related to Feature #39130: Common Formatting - Check tasklist item without editing function added
Actions #18

Updated by Marius BĂLTEANU 29 days ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF