Patch #40197: Update commonmarker to 2.3.0 - Redmine

Custom queries

Documentation issues
Open defects
Open features
Patch queue
Plugin issues
Translation patches

Actions

Copy link

Patch #40197

closed

Update commonmarker to 2.3.0

Added by Marius BĂLTEANU about 2 years ago. Updated 11 months ago.

Status:

Closed

Priority:

Normal

Assignee:

Marius BĂLTEANU

Category:

Gems support

Target version:

6.1.0

Description

https://github.com/gjtorikian/commonmarker/blob/main/CHANGELOG.md

Files

Download all files

0001-Updates-commonmark-gem-version-to-1.1.5-which-switch.patch (9.14 KB) 0001-Updates-commonmark-gem-version-to-1.1.5-which-switch.patch		Marius BĂLTEANU, 2024-08-28 01:53
0002-Simplify-code.patch (1.29 KB) 0002-Simplify-code.patch		Marius BĂLTEANU, 2024-08-29 22:21
0003-Disable-syntax_highlighter-plugin-shipped-by-commonm.patch (1.81 KB) 0003-Disable-syntax_highlighter-plugin-shipped-by-commonm.patch		Marius BĂLTEANU, 2024-08-29 22:21

Related issues

Related to Redmine - Patch #42602: Replaces deckar01-task_list with commonmarks tasklist extension	Closed	Marius BĂLTEANU	Actions
Related to Redmine - Feature #39130: Common Formatting - Check tasklist item without editing function	New	Marius BĂLTEANU	Actions
Blocked by Redmine - Feature #38585: Drop Ruby 2.7 and 3.0 support	Closed	Go MAEDA	Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Go MAEDA about 2 years ago

FYI: CommonMarker 1.0 requires Ruby 3.1.0 or higher. If this change is included in Redmine 6.0.0, Redmine 6.0.0 will drop support for Ruby 3.0 as well as 2.7.

Actions

Copy link

Updated by Go MAEDA over 1 year ago

Go MAEDA wrote in #note-1:

FYI: CommonMarker 1.0 requires Ruby 3.1.0 or higher. If this change is included in Redmine 6.0.0, Redmine 6.0.0 will drop support for Ruby 3.0 as well as 2.7.

Due to the migration to Rails 7.2 in #36320#note-42, Redmine now requires Ruby 3.1 and higher.
It is no longer necessary to consider the supported Ruby versions to update the CommonMarker gem.

Actions

Copy link

Updated by Go MAEDA over 1 year ago

Blocked by Feature #38585: Drop Ruby 2.7 and 3.0 support added

Actions

Copy link

Updated by Marius BĂLTEANU over 1 year ago

File 0001-Updates-commonmark-gem-version-to-1.1.5-which-switch.patch 0001-Updates-commonmark-gem-version-to-1.1.5-which-switch.patch added
Subject changed from Update commonmark to 1.0 to Update commonmark to 1.1
Target version changed from Candidate for next major release to 6.0.0

Here is the patch that updates commonmark to 1.1.5. This update switches from libcmark-gfm to comrak/Rust which give us more option in terms of text formatting.

Actions

Copy link

Updated by Marius BĂLTEANU over 1 year ago

File 0002-Simplify-code.patch 0002-Simplify-code.patch added
File 0003-Disable-syntax_highlighter-plugin-shipped-by-commonm.patch 0003-Disable-syntax_highlighter-plugin-shipped-by-commonm.patch added

Two new patches in addition to the first one:

0002-Simplify-code.patch: just simplify the existing code
0003-Disable-syntax_highlighter-plugin-shipped-by-commonm.patch: disables for now the commonmark plugin for syntax_highlighter.

Actions

Copy link