Project

General

Profile

Actions

Patch #40197

closed

Update commonmarker to 2.3.0

Patch #40197: Update commonmarker to 2.3.0

Added by Marius BĂLTEANU almost 3 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Gems support
Target version:


Files


Related issues 3 (1 open — 2 closed)

Related to Redmine - Patch #42602: Replaces deckar01-task_list with commonmarks tasklist extensionClosedMarius BĂLTEANUActions
Related to Redmine - Feature #39130: Common Formatting - Check tasklist item without editing functionNewMarius BĂLTEANUActions
Blocked by Redmine - Feature #38585: Drop Ruby 2.7 and 3.0 supportClosedGo MAEDAActions

Updated by Go MAEDA almost 3 years ago Actions #1

FYI: CommonMarker 1.0 requires Ruby 3.1.0 or higher. If this change is included in Redmine 6.0.0, Redmine 6.0.0 will drop support for Ruby 3.0 as well as 2.7.

Updated by Go MAEDA over 2 years ago Actions #2

Go MAEDA wrote in #note-1:

FYI: CommonMarker 1.0 requires Ruby 3.1.0 or higher. If this change is included in Redmine 6.0.0, Redmine 6.0.0 will drop support for Ruby 3.0 as well as 2.7.

Due to the migration to Rails 7.2 in #36320#note-42, Redmine now requires Ruby 3.1 and higher.
It is no longer necessary to consider the supported Ruby versions to update the CommonMarker gem.

Updated by Go MAEDA over 2 years ago Actions #3

Updated by Marius BĂLTEANU about 2 years ago Actions #4

Here is the patch that updates commonmark to 1.1.5. This update switches from libcmark-gfm to comrak/Rust which give us more option in terms of text formatting.

Updated by Marius BĂLTEANU about 2 years ago Actions #5

Two new patches in addition to the first one:
  • 0002-Simplify-code.patch: just simplify the existing code
  • 0003-Disable-syntax_highlighter-plugin-shipped-by-commonm.patch: disables for now the commonmark plugin for syntax_highlighter.

Updated by Marius BĂLTEANU about 2 years ago Actions #6

  • Target version changed from 6.0.0 to 6.1.0

Updated by Marius BĂLTEANU about 2 years ago Actions #7

  • Target version changed from 6.1.0 to 6.0.0

Updated by Marius BĂLTEANU about 2 years ago Actions #8

  • Status changed from New to Resolved

I've updated commonmark gem to 1.1.5.

Updated by Marius BĂLTEANU about 2 years ago Actions #9

  • Status changed from Resolved to New
  • Target version changed from 6.0.0 to 6.1.0

I'm postponing this for 6.1.0 in order to fix the CI build.

Updated by Marius BĂLTEANU about 2 years ago Actions #10

  • Status changed from New to Resolved

Updated by Marius BĂLTEANU about 2 years ago Actions #11

Committed the patches again, I'm closing this after we have the CI fixed.

Updated by Marius BĂLTEANU about 2 years ago Actions #12

  • Status changed from Resolved to Closed

The build is passing now, I'm closing this.

Updated by Marius BĂLTEANU over 1 year ago Actions #13

  • Subject changed from Update commonmark to 1.1 to Update commonmarker to 2.3.0
  • Status changed from Closed to Reopened

Updated by Marius BĂLTEANU over 1 year ago Actions #14

I've updated commonmarker to latest version, I will create new issues for each feature that I would like to enable.

Updated by Marius BĂLTEANU over 1 year ago Actions #15

  • Status changed from Reopened to Resolved

Updated by Marius BĂLTEANU over 1 year ago Actions #16

  • Related to Patch #42602: Replaces deckar01-task_list with commonmarks tasklist extension added

Updated by Marius BĂLTEANU over 1 year ago Actions #17

  • Related to Feature #39130: Common Formatting - Check tasklist item without editing function added

Updated by Marius BĂLTEANU over 1 year ago Actions #18

  • Status changed from Resolved to Closed
Actions

Also available in: PDF Atom