Project

General

Profile

Actions

Feature #4221

closed

Force passwords to contain specified character classes

Feature #4221: Force passwords to contain specified character classes

Added by jim joseph about 17 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Accounts / authentication
Target version:
Resolution:
Fixed

Description

I would like to enforce strong password for users in redmine. As if now redmine will accept any four letter password. Is there a way that applicaton checks how strong a password is when a new user register in it.

Can we implement any password generator with redmine?


Files


Related issues 4 (1 open — 3 closed)

Related to Redmine - Feature #3872: New user password - better functionalityClosedJean-Philippe LangActions
Related to Redmine - Feature #3155: Password policy and secure logon procedureNewActions
Related to Redmine - Defect #37449: Passing a wrong parameter to `with_settings` in UserTest::test_random_password_include_required_charactersClosedGo MAEDAActions
Has duplicate Redmine - Feature #25054: Enforcing Strong Password in RedmineClosedActions

Updated by Jean-Philippe Lang about 17 years ago Actions #1

As of r2678, you can specify the minimum password length in settings.
But a minimum password strength setting could be also added (eg. Fair, Strong, Very strong) using kind of password strengh meter.

Updated by Jean-Philippe Lang almost 17 years ago Actions #2

  • Category set to Accounts / authentication

Updated by Henrik Ammer almost 17 years ago Actions #3

Jean-Philippe Lang wrote:

But a minimum password strength setting could be also added (eg. Fair, Strong, Very strong) using kind of password strengh meter.

I would love to see this!

Updated by Samuel Suther over 13 years ago Actions #4

*1

Updated by @ go2null over 13 years ago Actions #5

Can we implement any password generator with redmine?

  • Implemented in v2.4.0 - Feature #3872 New user password - better functionality

Updated by Toshi MARUYAMA over 13 years ago Actions #6

  • Related to Feature #3872: New user password - better functionality added

Updated by Simon O over 12 years ago Actions #7

1
The new feature implemented in 2.4.0
+ referring to Feature #3872 includes a secured password generator.
However, if users may change their password at first login, they may pick "aaaaaaaa" which is far away from being secure. Thus, I also recommend to add a kind of password security check as suggested by jim joseph.
Please reopen ticket.
Thanks a lot!

Updated by Aleksandar Pavic almost 11 years ago Actions #8

+1

There are some recent efforts as I can see.

https://github.com/simonswine/redmine_password_tool
https://github.com/go2null/redmine_account_policy

But this should be a core system feature, it is a must for enterprise use.

Updated by Toshi MARUYAMA almost 10 years ago Actions #9

  • Has duplicate Feature #25054: Enforcing Strong Password in Redmine added

Updated by Go MAEDA over 7 years ago Actions #10

  • Related to Feature #3155: Password policy and secure logon procedure added

Updated by Takenori TAKAKI over 7 years ago Actions #11

+
If we can enforce password strength, Redmine will be used in environments where some security policy is required.
I post a patch, as I implemented the following features:
  • Enable to setting password strength in admin settings
  • Enable to selecting the enforce character types (Uppercase, Lowercase, Digits, Special characters).
  • Validation for each enforce character types

Updated by Go MAEDA over 7 years ago Actions #12

  • Priority changed from High to Normal
  • Target version set to Candidate for next major release

Updated by Go MAEDA over 7 years ago Actions #13

I think the validation in enforce-password-char-types.patch should cover all ASCII special characters, such as '(', ')', '+', '-', and '_'. The following code does that.

diff --git a/app/models/setting.rb b/app/models/setting.rb
index b18f8ed89..4171fa04e 100644
--- a/app/models/setting.rb
+++ b/app/models/setting.rb
@@ -19,6 +19,13 @@

 class Setting < ActiveRecord::Base

+  PASSWORD_REQUIRED_CHARACTER_CLASSES = {
+        'uppercase'          => /[A-Z]/,
+        'lowercase'          => /[a-z]/,
+        'digits'             => /[0-9]/,
+        'special_characters' => /[[:ascii:]&&[:graph:]&&[:^alnum:]]/
+    }
+
   DATE_FORMATS = [
         '%Y-%m-%d',
         '%d/%m/%Y',

Updated by Takenori TAKAKI about 7 years ago Actions #14

Thank you Mr. Maeda.
I change a patch and post it again.
  • Changed definition of 'special_characters' to the code proposed by Mr. Maeda
  • Changed regular expression in validation of special characters. => Almost all special characters within the ASCII range can be used.
  • Shortened constant and label names.
  • On password generation, contain special characters only when special characters are required.
  • Added display of usable characters such as "Change Password" Form.

Updated by Go MAEDA about 7 years ago Actions #15

  • Target version changed from Candidate for next major release to 4.1.0

LGTM. Setting the target version to 4.1.0.

Updated by Go MAEDA about 7 years ago Actions #16

This is the screenshot of enforce-password-char-types-v2.patch. Admins can force users to include specified character classes (uppercase, lowercase, digits, or special Characters) in their password. This feature must be welcomed by many admins.

Updated by Go MAEDA about 7 years ago Actions #17

  • Subject changed from Enforcing Strong Password for Users to Force passwords to contain specified character classes
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you for improving Redmine.

Updated by Go MAEDA over 4 years ago Actions #19

  • Related to Defect #37449: Passing a wrong parameter to `with_settings` in UserTest::test_random_password_include_required_characters added
Actions

Also available in: PDF Atom