Project

General

Profile

Actions

Feature #43650

closed

Ruby 4.0 support

Added by Katsuya HIDAKA 5 months ago. Updated 11 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Ruby support
Target version:
Resolution:
Fixed


Files


Related issues

Related to Redmine - Defect #43737: Rendering wiki is significantly slow on Ruby 4.0.1ClosedActions
Actions #1

Updated by Mizuki ISHIKAWA 4 months ago

I’m attaching a patch to make Ruby 4.0 available in Redmine.

Actions #2

Updated by Go MAEDA 4 months ago

  • Assignee set to Go MAEDA
  • Target version set to Candidate for next major release
Actions #3

Updated by Go MAEDA 4 months ago

  • Target version changed from Candidate for next major release to 7.0.0

Setting the target version to 7.0.0.

Actions #4

Updated by Go MAEDA 4 months ago

  • Status changed from New to Resolved
  • Resolution set to Fixed

Committed the patch in r24367. Thank you.

Actions #5

Updated by Go MAEDA 4 months ago

  • Status changed from Resolved to Closed
Actions #6

Updated by Marius BĂLTEANU 4 months ago

I'm wondering if it's safe to merge this into 6.1.2 considering there are no breaking changes added by this update? Or how we can ship this faster without releasing 7.0.0 that needs more time to finish the work.

Actions #7

Updated by Go MAEDA 4 months ago

  • Status changed from Closed to Reopened

Marius BĂLTEANU wrote in #note-6:

I'm wondering if it's safe to merge this into 6.1.2 considering there are no breaking changes added by this update? Or how we can ship this faster without releasing 7.0.0 that needs more time to finish the work.

I agree that it is safe to merge this into the 6.0-stable branch.

Traditionally, Redmine has supported newer Ruby versions only with major releases. However, in cases like this—where the new Ruby version requires no code changes or only minimal ones—I think it is reasonable to support it in a minor release.

Actions #8

Updated by Go MAEDA 4 months ago

  • Target version changed from 7.0.0 to 6.1.2

Setting the target version to 6.1.2.

Actions #9

Updated by Go MAEDA 4 months ago

  • Target version changed from 6.1.2 to 7.0.0

After upgrading Ruby to 4.0.1 in the Redmine instance in our company, we observed a significant slowdown in CommonMark Markdown rendering. The root cause is still unknown, but our current investigation strongly suggests that the upgrade from Ruby 3.4 to 4.0.1 is responsible.

Therefore, I believe that changes for Ruby 4.0 support should not be merged into the 6.1-stable branch at least until this issue is resolved.

Actions #11

Updated by Katsuya HIDAKA 4 months ago

I submitted #43737 about a slowdown in wiki rendering on Ruby 4.0.1.

Actions #12

Updated by Holger Just 4 months ago

  • Related to Defect #43737: Rendering wiki is significantly slow on Ruby 4.0.1 added
Actions #13

Updated by Marius BĂLTEANU 12 days ago

Go MAEDA, should we pin Ruby to 4.0.3 or 4.0.4?

Actions #14

Updated by Go MAEDA 11 days ago

Marius BĂLTEANU wrote in #note-13:

Go MAEDA, should we pin Ruby to 4.0.3 or 4.0.4?

I think it is sufficient to mention in doc/INSTALL that Ruby 4.0.0 through 4.0.3 have performance issues, and I do not think we should reject these versions in the Gemfile. The reasons are as follows.

  • No officially released version of Redmine supports Ruby 4.0 yet. Even after a Ruby 4.0-compatible version of Redmine is released, most users will likely use the latest Ruby 4.0 release, which is currently Ruby 4.0.5. Therefore, it is unlikely that many users will run Redmine with the Ruby 4.0.0 through 4.0.3 versions with performance issues.
  • If we reject specific Ruby 4.0 versions in the Gemfile, users who are already running trunk Redmine on Ruby 4.0 may suddenly become unable to start Redmine after running svn up.
  • It would make the Ruby version requirements in the Gemfile more complicated.
  • If similar issues are found in future Ruby versions, we would need to keep adding more reject conditions to the Gemfile.
Actions #15

Updated by Marius BĂLTEANU 11 days ago

  • Status changed from Reopened to Closed

Thanks!

Actions

Also available in: Atom PDF