Actions
Patch #43745
open
Move parse_hire_images and parse_inline_attachments to scrubbers
Status:
New
Priority:
Normal
Assignee:
-
Category:
Code cleanup/refactoring
Target version:
Description
#43643 introduced Loofah for textile text formatting and now we can share common scrubbers between all text formatter options.
This patch moves theparse_hire_images and parse_inline_attachments from ApplicationHelper to their own dedicated scrubbers:
HiresImagesScrubberInlineAttachmentsScrubber
Both scrubbers work only at img node level and do not require to traverse the HTML tree.
Before:
| Textile | Average: 7.85 ms |
| CommonMark | Average: 15.94 ms |
After:
| Textile | Average: 8.71 ms |
| CommonMark | Average: 16.58 ms |
Files
Related issues
Updated by Marius BĂLTEANU about 20 hours ago
If this overall approach is accepted, it will require a little bit of extra work in order to adapt the tests to the new structure and maybe to have a Base class that implements post_processor_scrubbers.
Updated by Marius BĂLTEANU about 20 hours ago
- Related to Patch #43643: Align the Textile processing approach with CommonMark by using Loofah added
Updated by Marius BĂLTEANU about 20 hours ago
- Related to Feature #35035: Refactor text formatting to HTML::Pipeline added
Updated by Marius BĂLTEANU about 20 hours ago
Takashi Kato, I've added you as watcher to this issue because is on top of your work.
Actions