Project

General

Profile

Actions
Copy link

Patch #43745

closed

Move parse_hire_images and parse_inline_attachments to scrubbers

Added by Marius BĂLTEANU 23 days ago. Updated 6 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Marius BĂLTEANU
Category:
Code cleanup/refactoring
Target version:
7.0.0

Description

#43643 introduced Loofah for textile text formatting and now we can share common scrubbers between all text formatter options.

This patch moves the parse_hire_images and parse_inline_attachments from ApplicationHelper to their own dedicated scrubbers:
  • HiresImagesScrubber
  • InlineAttachmentsScrubber

Both scrubbers work only at img node level and do not require to traverse the HTML tree.

Before:

Textile Average: 7.85 ms
CommonMark Average: 15.94 ms

After:

Textile Average: 8.71 ms
CommonMark Average: 16.58 ms

Files

0001-Moves-parse-hires-images-and-parse-inline-attachment.patch (17.2 KB) 0001-Moves-parse-hires-images-and-parse-inline-attachment.patch Marius BĂLTEANU, 2026-02-05 03:04

Related issues

Related to Redmine - Patch #43643: Align the Textile processing approach with CommonMark by using LoofahClosedMarius BĂLTEANUActions
Related to Redmine - Feature #35035: Refactor text formatting to HTML::PipelineNewActions
Actions
Copy link
 #1

Updated by Marius BĂLTEANU 23 days ago

If this overall approach is accepted, it will require a little bit of extra work in order to adapt the tests to the new structure and maybe to have a Base class that implements post_processor_scrubbers.

Actions
Copy link
 #2

Updated by Marius BĂLTEANU 23 days ago

  • Related to Patch #43643: Align the Textile processing approach with CommonMark by using Loofah added
Actions
Copy link
 #3

Updated by Marius BĂLTEANU 23 days ago

  • Related to Feature #35035: Refactor text formatting to HTML::Pipeline added
Actions
Copy link
 #4

Updated by Marius BĂLTEANU 23 days ago

Takashi Kato, I've added you as watcher to this issue because is on top of your work.

Actions
Copy link
 #5

Updated by Marius BĂLTEANU 16 days ago

  • Status changed from New to Resolved
  • Assignee set to Marius BĂLTEANU

Change committed, I just need to adapt the tests.

Actions
Copy link
 #6

Updated by Marius BĂLTEANU 6 days ago

  • Target version changed from Candidate for next major release to 7.0.0
Actions
Copy link
 #7

Updated by Marius BĂLTEANU 6 days ago

  • Status changed from Resolved to Closed

Refactored the tests, please let me know if you see any issue.

Actions
Copy link

Also available in: Atom PDF