Project

General

Profile

Actions
Copy link

Patch #43745

open

Move parse_hire_images and parse_inline_attachments to scrubbers

Added by Marius BĂLTEANU about 22 hours ago. Updated about 9 hours ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Code cleanup/refactoring
Target version:
Candidate for next major release

Description

#43643 introduced Loofah for textile text formatting and now we can share common scrubbers between all text formatter options.

This patch moves the parse_hire_images and parse_inline_attachments from ApplicationHelper to their own dedicated scrubbers:
  • HiresImagesScrubber
  • InlineAttachmentsScrubber

Both scrubbers work only at img node level and do not require to traverse the HTML tree.

Before:

Textile Average: 7.85 ms
CommonMark Average: 15.94 ms

After:

Textile Average: 8.71 ms
CommonMark Average: 16.58 ms

Files

0001-Moves-parse-hires-images-and-parse-inline-attachment.patch (17.2 KB) 0001-Moves-parse-hires-images-and-parse-inline-attachment.patch Marius BĂLTEANU, 2026-02-05 03:04

Related issues

Related to Redmine - Patch #43643: Align the Textile processing approach with CommonMark by using LoofahClosedMarius BĂLTEANUActions
Related to Redmine - Feature #35035: Refactor text formatting to HTML::PipelineNewActions
Actions
Copy link

Also available in: Atom PDF