Patch #43745
closed
Move parse_hires_images and parse_inline_attachments to scrubbers
Added by Marius BĂLTEANU 4 months ago.
Updated 19 days ago.
Category:
Code cleanup/refactoring
Description
#43643 introduced Loofah for textile text formatting and now we can share common scrubbers between all text formatter options.
This patch moves the
parse_hire_images and
parse_inline_attachments from
ApplicationHelper to their own dedicated scrubbers:
HiresImagesScrubberInlineAttachmentsScrubber
Both scrubbers work only at img node level and do not require to traverse the HTML tree.
Before:
| Textile |
Average: 7.85 ms |
| CommonMark |
Average: 15.94 ms |
After:
| Textile |
Average: 8.71 ms |
| CommonMark |
Average: 16.58 ms |
Files
If this overall approach is accepted, it will require a little bit of extra work in order to adapt the tests to the new structure and maybe to have a Base class that implements post_processor_scrubbers.
- Related to Patch #43643: Align the Textile processing approach with CommonMark by using Loofah added
- Related to Feature #35035: Refactor text formatting to HTML::Pipeline added
Takashi Kato, I've added you as watcher to this issue because is on top of your work.
- Status changed from New to Resolved
- Assignee set to Marius BĂLTEANU
Change committed, I just need to adapt the tests.
- Target version changed from Candidate for next major release to 7.0.0
- Status changed from Resolved to Closed
Refactored the tests, please let me know if you see any issue.
- Subject changed from Move parse_hire_images and parse_inline_attachments to scrubbers to Move parse_hires_images and parse_inline_attachments to scrubbers
Also available in: Atom
PDF
Updated by 
Updated by