Defect #44244
open
Spent time tab on issue page does not render commit references as links
Description
On the issue detail page, the Associated revisions tab displays revision identifiers as clickable links to the corresponding revision page.
However, in the Spent time tab, time entries that were automatically logged via commit message show the associated revision as plain text (e.g. `Applied in changeset commit:a85130f`) without any link.
This is inconsistent with the Associated revisions tab behavior.
Root cause¶
`app/views/issues/tabs/_time_entries.html.erb` outputs `time_entry.comments` as plain text. It needs to go through `textilizable` so that Redmine link syntax (e.g. `commit:xxx`) is resolved to an HTML link.
Fix¶
- <%= time_entry.comments %> + <%= textilizable(time_entry, :comments) %>
Before:
After:
A patch is attached.
Files
Related issues
Updated by Marius BĂLTEANU 23 days ago
- Category set to UI
- Status changed from New to Resolved
- Assignee set to Marius BĂLTEANU
- Target version set to 6.1.4
- Resolution set to Fixed
Committed, thanks!
Updated by Marius BĂLTEANU 23 days ago
- Related to Feature #202: Textilization of Documents, News and Timelog-entry comments added
Updated by Marius BĂLTEANU 23 days ago
I've reverted the commit because the time entries comments are not textilizable, there is a very old request to support this, please see #202.
Updated by Marius BĂLTEANU 23 days ago
- Status changed from Resolved to Needs feedback
- Resolution deleted (
Fixed)
Updated by Marius BĂLTEANU 21 days ago
- Target version changed from 6.1.4 to Candidate for next major release
Updated by Takenori TAKAKI 17 days ago
Marius BĂLTEANU wrote in #note-3:
I've reverted the commit because the time entries comments are not textilizable, there is a very old request to support this, please see #202.
I think there may be a typo in Go Maeda's comment in #202#note-21. If I understand the context correctly, I believe he intended to point out that the Spent time tab should also render Markdown/Textile.