Project

General

Profile

Actions

Defect #44317

closed

Actions dropdown is not closed after copying a link

Added by Mizuki ISHIKAWA 23 days ago. Updated 2 days ago.

Status:
Closed
Priority:
Normal
Category:
UI
Target version:
Resolution:
Fixed
Affected version:

Description

copyText in app/javascript/controllers/clipboard_controller.js closes the dropdown by looking for the nearest .drdn.expanded element from the clicked element and removing the expanded class from it:

    this.copy(e.currentTarget.dataset.clipboardText);

    const element = e.currentTarget.closest('.drdn.expanded');
    if (element !== null) {
      element.classList.remove('expanded');
    }

Since Patch #44205: Refactor actions dropdown to new dropdown component, actions_dropdown no longer uses that markup: it renders the new dropdown component, which is driven by dropdown_controller and hides its content with the hidden class instead. The selector above therefore matches nothing, and the dropdown is left open.


Files


Related issues

Related to Redmine - Patch #44205: Refactor actions dropdown to new dropdown componentClosedMarius BĂLTEANUActions
Actions #2

Updated by Marius BĂLTEANU 22 days ago

  • Assignee set to Marius BĂLTEANU
  • Target version set to 7.1.0
Actions #3

Updated by Go MAEDA 12 days ago

Wouldn't it be better to include this small fix in 7.0.1 instead of 7.1.0?

Actions #4

Updated by Marius BĂLTEANU 8 days ago

  • Related to Patch #44205: Refactor actions dropdown to new dropdown component added
Actions #5

Updated by Marius BĂLTEANU 8 days ago

  • Status changed from New to Resolved
  • Resolution set to Fixed

Committed, thanks for catching and fixing the issue.

Go MAEDA wrote in #note-3:

Wouldn't it be better to include this small fix in 7.0.1 instead of 7.1.0?

In 7.0.0, we only introduced the new dropdown component for the account menu. The refactoring of dropdown actions and the context menu has been made in the current trunk for 7.1.0. Please let me know if I'm wrong.

Actions #6

Updated by Marius BĂLTEANU 2 days ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF