Defect #6784
Redmine not working with i18n gem 0.4.2
| Status: | Closed | Start date: | 2010-11-01 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Felix Schäfer | % Done: | 0% | |
| Category: | I18n | |||
| Target version: | 1.0.4 | |||
| Resolution: | Fixed | Affected version: | 1.0.3 |
Related issues
Associated revisions
Fixed: Trunk not working with i18n gem 0.4.2 (#6784).
History
#1
Updated by Felix Schäfer almost 11 years ago
- Priority changed from High to Normal
#2
Updated by Holger Just almost 11 years ago
If you revert the workaround for i18n 0.4.1 in r4183, everything works fine again with 0.4.2.
#3
Updated by Holger Just almost 11 years ago
The "fixing" commit is probably this one. Sadly, I found no immediate solution for supporting both versions. Maybe we need to build a custom switch or patch for 0.4.1...
#4
Updated by Grigory Petrov almost 11 years ago
Maybe just place 'if gem version < xxx' code so both 'fixing' commit and a normal code will work according to i18n gem version? Unfortunately, i'm not very good at ruby world and don't know how it's supposed to fight dll hell here :).
#5
Updated by Felix Schäfer almost 11 years ago
- Target version set to 1.0.4
This https://github.com/thegcat/redmine/commit/00ef3004120035095c9cd11aba65ebd648160fe6 should make i18n 0.4.{1,2} happy with the patch.
#6
Updated by Holger Just almost 11 years ago
I can confirm that the patch by Felix works with i18n 0.4.(1|2), 0.3.7 and no i18n gem at all.
@Eric, could you please commit this one soon? We get many requests by people falling over i18n 0.4.2 currently.
@Felix, thanks for providing the solution.
#7
Updated by Alex Bevilacqua almost 11 years ago
I had the same problem this morning and Felix's patch worked beautifully. This should probably be pushed sooner rather than later to avoid a landslide of issue reports ...
#8
Updated by Jean-Philippe Lang almost 11 years ago
- Status changed from New to Resolved
- Resolution set to Fixed
Fixed in r4389 using a slightly different patch to avoid another failure next time they change the method signature.
#9
Updated by Jean-Philippe Lang almost 11 years ago
- Subject changed from Trunk not working with i18n gem 0.4.2 to Redmine not working with i18n gem 0.4.2
- Status changed from Resolved to Closed
- Affected version (unused) changed from devel to 1.0.3
- Affected version set to 1.0.3
Merged in stable branch.
#10
Updated by Etienne Massip over 10 years ago
- Category set to I18n