Defect #6802: Autolinking should not occur in link titles - Redmine

Custom queries

Documentation issues
Open defects
Open features
Patch queue
Plugin issues
Translation patches

Actions

Copy link

Defect #6802

open

Autolinking should not occur in link titles

Added by Alejandro Mery over 13 years ago. Updated over 5 years ago.

Status:

New

Priority:

Normal

Assignee:

Category:

Text formatting

Target version:

Start date:

2010-11-02

Due date:

% Done:

Estimated time:

Resolution:

Affected version:

Description

In [[www|www.example.org]] the title incorrectly gets converted into an external link.

Using 1.0-stable branch.

History
Notes
Property changes

Actions

Copy link

Updated by Holger Just over 13 years ago

Subject changed from autolinking should not occur for titles to Autolinking should not occur in link titles
Category set to Text formatting
Affected version (unused) set to devel

The issue is actually the other way round. The auto linking of URLs (performed by inline_auto_link in textile/formatter occurs occurs first, the wiki link is only generated after than.

Thus, the above statement is transformed into:

Current behavior

[[www|www.example.org]]
[[www|<a class="external" href="http://www.example.org">www.example.org</a>]]
<a href="/projects/redmine/wiki/www" class="wiki-page new"><a class="external" href="http://www.example.org">www.example.org</a></a>

Expected

[[www|www.example.org]]
<a href="/projects/redmine/wiki/www" class="wiki-page new">www.example.org</a>

This might be solved by reordering rendering methods in source:trunk/app/helpers/application_helper.rb#L453 in a way that parse_wiki_links runs before inline_auto_link. Maybe, these methods need to be included into the textile implementation in source:trunk/lib/redmine/wiki_formatting/textile in the correct ordering.

Actions

Copy link