Redmine

2018-08-13

16:27 Defect #668: Date input fields don't respect date format settings

+1.
We're currently upgrading from Redmine 2.4.3 to 3.4.6.stable, and it strikes me that this input date formattin... Jonas De Meulenaere

14:49 Patch #29378: More call_hooks for projects, issue statusses, time entries, etc.

Do you strictly need these controller hooks to distinguish updates done by the controller from other updates?
Most... Holger Just

14:33 Patch #29378 (Needs feedback): More call_hooks for projects, issue statusses, time entries, etc.

Currently there are only functional call_hooks for issues, and with that, i mean the 'controller_issues_edit_after_sa... Jonas Ineveld, van

13:39 Patch #29359 (Closed): Switch to mini_mime from mime-types

Pavel Rosický wrote:
> please also remove
> [...]
Committed. Thanks. Go MAEDA

11:28 Patch #29359 (Reopened): Switch to mini_mime from mime-types

Marius BĂLTEANU

11:18 Patch #29359: Switch to mini_mime from mime-types

please also remove... Pavel Rosický

01:37 Patch #29359 (Closed): Switch to mini_mime from mime-types

Committed. Thank you for your contribution. Go MAEDA

03:53 Defect #25727 (Closed): Interface not responsive to mobile device

Redmine supports responsive layout since 3.2. See #19097. Go MAEDA

03:43 Defect #24915: Activity shows issues and text of issues which should not

I could not reproduce the problem with 3.4.6.devel.17468. All activities on a user's profile page are visible issues ... Go MAEDA

01:55 Defect #29365 (Closed): MailHandlerTest#test_add_issue_with_localized_attributes fails with mail gem 2.7.0

... Go MAEDA

01:40 Patch #29363 (Closed): Use String#tr instead of String#gsub

Committed. Go MAEDA

2018-08-12

11:25 Patch #26747: Use find_by instead of where.first to remove unnecessary sorting

@find_by@ is significantly faster than @where.first@.... Go MAEDA

09:24 Patch #29359: Switch to mini_mime from mime-types

It's ok, thanks Pavel Rosický

09:10 Patch #29359: Switch to mini_mime from mime-types

Pavel Rosický wrote:
> @known_types is a class variable. There're two problems:
> It isn't threadsafe.
> It's unli... Go MAEDA

06:07 Patch #29363 (Closed): Use String#tr instead of String#gsub

String#tr is more than 3 times faster than String#gsub when replacing a single character in a string with another sin... Go MAEDA

2018-08-11

15:13 Feature #938: Add default Activity value per user

A patch that adds the option to define a default time entry activity for each role was added to #29286. Marius BĂLTEANU

15:12 Feature #29286: Add default spent time activity per role

Attached is the patch that adds the option to define a default time entry activity for each role.
!{width:70%; bor... Marius BĂLTEANU

10:02 Patch #29359: Switch to mini_mime from mime-types

@known_types is a class variable. There're two problems:
It isn't threadsafe.
It's unlimited and because it's relat... Pavel Rosický

09:42 Patch #29359: Switch to mini_mime from mime-types

Lets ask sam saffron if he could add it to the public api. Pavel Rosický

09:37 Patch #29359: Switch to mini_mime from mime-types

I updated my patch to preserve existing cache mechanism. Now it is fast also for unknown extensions.... Go MAEDA

08:27 Patch #29359: Switch to mini_mime from mime-types

Sorry, there was a problem with my benchmark script. After fixing the problem, I found that my patch is very slow for... Go MAEDA

08:03 Patch #29359: Switch to mini_mime from mime-types

Thank you for posting the interesting improvement.
Your patch is very fast, but I think an application should not ... Go MAEDA

00:24 Defect #29259: Attachment preview does not work for some source files such as JavaScript and Go

Why not stick with a function „is_code?“ as I already proposed?
A negative test of a file on it‘s binary property... Stephan Wenzel