Project

General

Profile

Activity

From 2018-08-10 to 2018-08-12

2018-08-12

11:25 Patch #26747: Use find_by instead of where.first to remove unnecessary sorting
@find_by@ is significantly faster than @where.first@. Go MAEDA
09:24 Patch #29359: Switch to mini_mime from mime-types
It's ok, thanks Pavel Rosický
09:10 Patch #29359: Switch to mini_mime from mime-types
Pavel Rosický wrote:
> @known_types is a class variable. There're two problems:
> ...
Although the patch still has the same problem with the current implementation, simply replacing mime-types with mini_mime will reduce memory usage an...
Go MAEDA
06:07 Patch #29363 (Closed): Use String#tr instead of String#gsub
String#tr is more than 3 times faster than String#gsub when replacing a single character in a string with another single character.
https://github.com/JuanitoFatas/fast-ruby#stringgsub-vs-stringtr-code
Go MAEDA

2018-08-11

15:13 Feature #938: Add default Activity value per user
A patch that adds the option to define a default time entry activity for each role was added to #29286. Marius BĂLTEANU
15:12 Feature #29286: Add default spent time activity per role
Attached is the patch that adds the option to define a default time entry activity for each role.
!{width:70%; border: 1px solid grey;}.default_role_time_entry.png!
Any feedback is welcome.
Marius BĂLTEANU
10:02 Patch #29359: Switch to mini_mime from mime-types
@known_types is a class variable. There're two problems:
It isn't threadsafe.
It's unlimited and because it's related to user's actions it could grow indefinetly. This memory won't be released. That's why I was trying to avoid it or li...
Pavel Rosický
09:42 Patch #29359: Switch to mini_mime from mime-types
Lets ask sam saffron if he could add it to the public api. Pavel Rosický
09:37 Patch #29359: Switch to mini_mime from mime-types
I updated my patch to preserve existing cache mechanism. Now it is fast also for unknown extensions. Go MAEDA
08:27 Patch #29359: Switch to mini_mime from mime-types
Sorry, there was a problem with my benchmark script. After fixing the problem, I found that my patch is very slow for unknown extensions.
without patches:
Go MAEDA
08:03 Patch #29359: Switch to mini_mime from mime-types
Thank you for posting the interesting improvement.
Your patch is very fast, but I think an application should not have codes which rely on the internal structure of third-party libraries. Your patch accesses mini_mime's instance varia...
Go MAEDA
00:24 Defect #29259: Attachment preview does not work for some source files such as JavaScript and Go
Why not stick with a function „is_code?“ as I already proposed?
A negative test of a file on it‘s binary property may be a too powerful „catch all“. A „catch all“ based on it‘s non-binary character may raise questions how f.i. an „.h...
Stephan Wenzel

2018-08-10

23:21 Defect #29259: Attachment preview does not work for some source files such as JavaScript and Go
Pavel Rosický
12:49 Defect #29259: Attachment preview does not work for some source files such as JavaScript and Go
Go MAEDA wrote:
> Updated the patch. Simplified @Attachment#is_text?@.
Go Maeda, the patch contains some undesired changes.
Marius BĂLTEANU
10:06 Defect #29259: Attachment preview does not work for some source files such as JavaScript and Go
Updated the patch. Simplified @Attachment#is_text?@. Go MAEDA
21:44 Patch #29359 (Closed): Switch to mini_mime from mime-types
Redmine uses unbound cache for mime types which is eliminated now. Also mime-types is too heavy and Redmine uses only a tiny peace of it, we just need a simple ext -> mime lookup.
https://github.com/mikel/mail/pull/1059 (mail 2.6.x st...
Pavel Rosický
04:48 Feature #29354 (New): Due Date alert email notifications
Allow configuring email notifications to be sent x # of days before due date.
Allow selection of projects and even choose custom fields as filters?
Allow configuring multiple entries of these email notification configurations.
James H
 

Also available in: Atom