Project

General

Profile

Activity

From 2019-05-25 to 2019-05-27

2019-05-27

23:24 Patch #31433 (Closed): Use "icon icon-*" classes for sort-handler, collapsible fieldsets and collapsible versions
Committed the patch. Thanks. Go MAEDA
21:46 Patch #31433: Use "icon icon-*" classes for sort-handler, collapsible fieldsets and collapsible versions
Go MAEDA wrote:
> Could you write the intention of this change?
Yes, it is the same as #24313 or #28605.
Marius BĂLTEANU
15:23 Feature #30826: Order of related issues types
Environment:
Redmine version 3.4.6.stable
Ruby version 2.4.1-p111 (2017-03-22) [x86_64-linux]
Rails version 4.2.10
Environment production
Database adapte...
Bolesław Kalinowski
12:54 Patch #31302: Customizable wiki assets in plugin
> If `script_format_adapter` is updated by some plugins, will only the plugin loaded last be reflected?
Of course there may be so.
But for plugins that add buttons to the toolbar with additional scripts, this change allows them to co...
Masato NODA
11:53 Patch #31302: Customizable wiki assets in plugin
> But this means that only the last plugins loaded will be reflected.
If `script_format_adapter` is updated by some plugins, will only the plugin loaded last be reflected?
Seiei Miyagi
10:54 Patch #31457 (Closed): Add support for reloading plugin assets automatically in development mode
Committed the patch. Thank you for improving Redmine. Go MAEDA
07:02 Patch #31457: Add support for reloading plugin assets automatically in development mode
Thank you for clarification. I understand that the change helps plugin developers a lot.
Setting the target version to 4.1.0.
Go MAEDA
06:07 Patch #31457: Add support for reloading plugin assets automatically in development mode
Ah, use case.
I want to improve style for [Full text search plugin](https://github.com/clear-code/redmine_full_text_search) by [CSS](https://github.com/clear-code/redmine_full_text_search/tree/master/assets/stylesheets). I want to check...
Kouhei Sutou
06:04 Patch #31457: Add support for reloading plugin assets automatically in development mode
Sure.
In Redmine itself development, we don't need to restart Redmine itself. It's useful. Because we don't need to follow the following steps:
* Change @public/stylesheets/application.css@
* Stop @bin/rails server@
* Start...
Kouhei Sutou
05:10 Patch #31457: Add support for reloading plugin assets automatically in development mode
Could you describe use cases for this feature? Since I am not familiar with plugin development, I cannot imagine why you want to update your plugins without restarting Redmine.
My concern for this feature is that it checks updates of ...
Go MAEDA
04:49 Patch #31457 (Closed): Add support for reloading plugin assets automatically in development mode
Redmine supports assets for plugin by putting files under @plugins/*/assets/@.
But Redmine doesn't support reloading (mirroring) plugin assets automatically.
For example, we need to restart @bin/rails server@ process to apply changes...
Kouhei Sutou
10:01 Patch #31399: make /my/account endpoint accessible through API
OK, then I will come up with a patch for that :) Jens Krämer
08:42 Patch #31399: make /my/account endpoint accessible through API
Jens Krämer wrote:
> If we change the API method to PUT, I would vote for changing the method used by the /my/account form to PUT, as well. What do you think?
Sounds nice, it makes things consistent. I am in favor of it.
Go MAEDA
08:19 Patch #31399: make /my/account endpoint accessible through API
Yes, the thought that POST is not really nice there crossed my mind, but in order to keep the patch as small as possible I sticked to it since that is what the web form uses as well. If we change the API method to PUT, I would vote for c... Jens Krämer
04:15 Patch #31399 (Needs feedback): make /my/account endpoint accessible through API
I have tested the patch and found that the endpoint behaves the same for both POST and PUT requests. In other words, POST updates the account instead of creating an account.
IMHO, Redmine should not respond to POST API requests. Since...
Go MAEDA
05:23 Defect #31438 (Confirmed): Incorrect position of the "Associated revisions" block when comments are displayed in reverse chronological order
I think the attached patch fixes the issue.
*[Before]*
!{width: 764px; border: 1px solid #ccc;}.31438-before@2x.png!
*[After]*
!{width: 764px; border: 1px solid #ccc;}.31438-after@2x.png!
Go MAEDA
03:51 Patch #31439: I can not attach a file to a ticket
I attach a log for reference.
log/production.log
Mic Don
02:51 Patch #31439: I can not attach a file to a ticket
Perhaps one of the plugins may cause the problem. Could you try again after removing all plugins? Go MAEDA
02:20 Patch #31439: I can not attach a file to a ticket
Thank you for your reply
* Is the problem only depends on the content of the file? Or does the file name also affects?
> It is only content of the file
* Please paste errors here if you see any errors in log/production.log file
...
Mic Don
03:06 Feature #10121: Watchers - Add Group / Role
+1 Ryoh HAMADA

2019-05-26

15:53 Feature #31418: Stacked bar charts in the issue details report
In r18201, I have slightly changed the behavior to hide closed issue statuses. As you can see in the screenshot below, hidden statuses are deleted with a strikethrough. those statuses appear in the graph if you click the status name in t... Go MAEDA
02:03 Feature #31418 (Closed): Stacked bar charts in the issue details report
Committed the patch. Thank you for the nice improvement. Go MAEDA
15:34 Defect #31438: Incorrect position of the "Associated revisions" block when comments are displayed in reverse chronological order
I think it will be fixed if #3058 is merged to the trunk. Go MAEDA
15:03 Defect #31438 (Reopened): Incorrect position of the "Associated revisions" block when comments are displayed in reverse chronological order
Hi,
thanks for the quick replay.
As I've wrote in the description is happens also with the default Redmine theme. See attached screenshot.
Mathias Buder wrote:
> Hi all,
> ...
!https://www.redmine.org/attachments/download/23...
Mathias Buder
02:40 Defect #31438 (Closed): Incorrect position of the "Associated revisions" block when comments are displayed in reverse chronological order
Since the problem occurs only in the third-party theme, there is nothing we can do.
I hope the theme developer suggests how to update the Redmine's code to fix their issue.
Go MAEDA
09:20 Patch #31399: make /my/account endpoint accessible through API
Setting the target version to 4.1.0. Go MAEDA
09:02 Patch #31441: Show elements titles using jQuery UI tooltips
Setting the target version to 4.1.0. Go MAEDA
04:29 Feature #21026: Allow selecting groups in user format custom fields
+1
Yuuki NARA

2019-05-25

08:53 Defect #31387 (Closed): Don't rescue Exception class
Committed the patch.
Pavel Rosický wrote:
> This was a fix for a very, very old jruby version. It should match MRI's behaviour now.
Thank you for the advice. I committed the following code.
Go MAEDA
07:42 Defect #31387: Don't rescue Exception class
This was a fix for a very, very old jruby version. It should match MRI's behaviour now. Pavel Rosický
03:05 Defect #31387: Don't rescue Exception class
According to r6230, it seems that we have to catch Exception in @lib/redmine/scm/adapters/abstract_adapter.rb@ unless we drop the support for JRuby. Go MAEDA
07:54 Feature #22915: Additional filetypes (tif,tiff) for thumbnails generation
Removing this issue from 4.1.0 because another patch #22481 which adds PDF thumbnails support was committed and we need a new updated patch in order to support TIFF thumbnails. Go MAEDA
05:54 Patch #30262: Show 'Add filter' dropdown menu as button beneath the filters
I am removing this from 4.1.0 for now because the patch that reflects #30262#note-8 and #30262#note-9 is not ready. Go MAEDA
05:45 Feature #13919: Mention user on issues and wiki pages using @user with autocomplete
Marius BALTEANU wrote:
> I would like to test the solution proposed because looking over the patch proposed, I think that it cannot be committed as it is and it'll require more work.
Could you point out what needs to be corrected? Ma...
Go MAEDA
05:39 Feature #31418: Stacked bar charts in the issue details report
Let's include this feature in upcoming Redmine 4.1.0. Go MAEDA
04:50 Feature #31450 (Closed): Support "YYYY/MM/DD" date format when importing issues
Issue importer supports some date formats but "YYYY/MM/DD". I think Redmine should also support the date format "YYYY/MM/DD".
In Redmine, "YYYY/MM/DD" (%Y/%m/%d) is the default format for Basque (eu), Persian (fa), Japanese (ja), Kore...
Go MAEDA
02:32 Patch #31433: Use "icon icon-*" classes for sort-handler, collapsible fieldsets and collapsible versions
Could you write the intention of this change? Go MAEDA
02:15 Patch #31445 (Closed): Bulgarian translation
Committed the patch. Thank you for maintaining the Bulgarian translation. Go MAEDA
01:38 Feature #31449 (New): Generate issue graphics
I am using Redmine as an issue manager. So, I need some issue graphics like closed vs opened and others like (opened vs resolved vs closed…).
Example: https://www.adventuresinoss.com/2016/01/19/avoiding-the-sad-graph-of-software-death...
Christian P. MOMON
 

Also available in: Atom