Project

General

Profile

Activity

From 2020-10-22 to 2020-10-24

2020-10-24

17:17 Revision 20190 (svn): restore r18857 lost by r20171 (#32530)
Toshi MARUYAMA
17:17 Revision 20189 (svn): restore r18851 lost by r20171 (#32530)
Toshi MARUYAMA
16:40 Revision 20188 (svn): use with_settings at IssuesControllerTest#test_index_with_project
Toshi MARUYAMA
16:40 Revision 20187 (svn): fix source indent of lib/redmine/scm/adapters/filesystem_adapter.rb
Toshi MARUYAMA
16:40 Revision 20186 (svn): fix source indent of RepositorySubversionTest
Toshi MARUYAMA
16:40 Revision 20185 (svn): fix source indent of lib/redmine/scm/adapters/subversion_adapter.rb
Toshi MARUYAMA
16:40 Revision 20184 (svn): fix source indent of TrackersControllerTest
Toshi MARUYAMA
16:40 Revision 20183 (svn): fix source indent of QueriesControllerTest
Toshi MARUYAMA
16:39 Revision 20182 (svn): fix source indent of TimelogControllerTest
Toshi MARUYAMA
16:39 Revision 20181 (svn): shorten long line of app/models/time_entry.rb
Toshi MARUYAMA
16:39 Revision 20180 (svn): shorten long line of GanttsController
Toshi MARUYAMA
16:39 Revision 20179 (svn): shorten long line of VersionsController
Toshi MARUYAMA
16:39 Revision 20178 (svn): shorten long line of ProjectsController
Toshi MARUYAMA
16:39 Revision 20177 (svn): shorten long line of test/unit/issue_test.rb
Toshi MARUYAMA
10:55 Feature #33802: Sub task feature without creating a new issue
You can use Custom Workflow Plugin and Write small Ruby Code to create these items.
I use this Feature in our insta...
Hans Riess
10:16 Feature #33894: Automatically set done ratio to 100% when closing a issue
Thank you for posting the patch but I think the behavior that status is set to 100% on the edit page is sometimes pro... Go MAEDA
09:41 Feature #33894: Automatically set done ratio to 100% when closing a issue
It turned out that a condition in `done_ratio_editable?` was wrong.
I have attached a fixed patch.
vzvu 3k6k
10:02 Patch #16069: Allow configuration of API limit instead of hardcoding at 100
Looks good. We've wrote a patch based on Domingo Galdos' one (Patch 0001) with Juno NISHIZAKI, sanak and me on Redmin... vzvu 3k6k
08:50 Patch #34161 (Closed): Replace gsub with tr, delete, or squeeze
Committed. Go MAEDA
08:14 Patch #34161 (Closed): Replace gsub with tr, delete, or squeeze
@String#tr@, @String#delete@, and @String#squeeze@ are faster than @String#gsub@.
https://docs.rubocop.org/rubocop...
Go MAEDA
08:46 Revision 20176 (svn): Replace gsub with tr, delete, or squeeze (#34161).
Go MAEDA
07:42 Patch #34160 (Closed): Replace Hash#merge! with Hash#[]=
Done. Go MAEDA
07:24 Patch #34160 (Closed): Replace Hash#merge! with Hash#[]=
@Hash#[]=@ is faster than @Hash#merge!@.
https://docs.rubocop.org/rubocop-performance/cops_performance.html#perfor...
Go MAEDA
07:33 Revision 20175 (svn): Replace Hash#merge! with Hash#[]= (#34160).
Go MAEDA
04:19 Patch #34159 (Closed): Update RuboCop Performance to 1.10
Committed the patch. Go MAEDA
03:54 Patch #34159 (Closed): Update RuboCop Performance to 1.10
Since Redmine dropped the support for Ruby 2.3, we can update RuboCop Performance from 1.5 to 1.8.... Go MAEDA
04:19 Revision 20174 (svn): Update RuboCop Performance to 1.8 (#34159).
Go MAEDA
03:41 Patch #34071: Handle AuthSourceExceptions in User.try_to_login
Setting the target version to 4.2.0. Go MAEDA
03:39 Patch #34153 (Closed): Use sum instead of inject(0, :+)
Committed the patch. Go MAEDA
03:39 Revision 20173 (svn): Use sum instead of inject(0, :+) (#34153).
Patch by Go MAEDA. Go MAEDA

2020-10-23

10:39 Patch #34071: Handle AuthSourceExceptions in User.try_to_login
The patch also fixes an issue that Redmine might return 500 error and HTML body against an API request.... Go MAEDA
08:23 Feature #15340: Custom field referencing other tickets
+1 Fabien Durand
08:22 Feature #7849: custom issue relation types
+1 Fabien Durand
03:31 Patch #32531 (Closed): Update RuboCop Rails to 2.9
Updated ruboCop Rails to 2.8 in r20172. Go MAEDA
02:55 Patch #32531 (Reopened): Update RuboCop Rails to 2.9
The latest version is 2.8.1.
https://rubygems.org/gems/rubocop-rails/versions/2.8.1
Since Redmine dropped support...
Go MAEDA
03:30 Revision 20172 (svn): Update RuboCop Rails to 2.8 (#32531).
Go MAEDA
02:47 Patch #32530 (Closed): Update RuboCop to 1.12
Updated RuboCop to 1.0 in r20171. Go MAEDA
02:47 Revision 20171 (svn): Update RuboCop to 1.0 (#32530).
Go MAEDA
02:30 Revision 20170 (svn): Update .rubocop_todo.yml (#32530).
Go MAEDA
02:17 Revision 20169 (svn): RuboCop: Set TargetRubyVersion to 2.4 (#34142).
Go MAEDA
02:13 Patch #34150 (Closed): Use match? instead of =~ when MatchData is not used
Committed the patch. Go MAEDA
02:13 Revision 20168 (svn): Use match? instead of =~ when MatchData is not used (#34150).
Patch by Go MAEDA. Go MAEDA
00:04 Defect #27780: Case-insensitive matching fails for Unicode filenames when referring to attachments in text formatting
Setting the target version to 4.2.0. Go MAEDA

2020-10-22

16:30 Defect #27780: Case-insensitive matching fails for Unicode filenames when referring to attachments in text formatting
Added test code to Амир Мусин's patch. Go MAEDA
16:18 Revision 20167 (svn): use with_settings at IssuesControllerTest#test_show_should_not_disclose_relations_to_invisible_issues
Toshi MARUYAMA
16:18 Revision 20166 (svn): shorten long line of test/unit/issue_test.rb
Toshi MARUYAMA
16:18 Revision 20165 (svn): shorten long line of TimeEntryQueryTest
Toshi MARUYAMA
16:18 Revision 20164 (svn): shorten long line of test/unit/query_test.rb
Toshi MARUYAMA
16:18 Revision 20163 (svn): shorten long line of lib/redmine.rb
Toshi MARUYAMA
16:18 Revision 20162 (svn): shorten long line of app/models/document.rb
Toshi MARUYAMA
16:17 Revision 20161 (svn): shorten long line of lib/redmine/default_data/loader.rb
Toshi MARUYAMA
16:17 Revision 20160 (svn): shorten long line of app/models/wiki_content_version.rb
Toshi MARUYAMA
16:17 Revision 20159 (svn): shorten long line of app/models/journal.rb
Toshi MARUYAMA
16:17 Revision 20158 (svn): shorten long line of app/models/attachment.rb
Toshi MARUYAMA
16:17 Revision 20157 (svn): shorten long line of NewsController
Toshi MARUYAMA
16:17 Revision 20156 (svn): shorten long line of test/integration/lib/redmine/menu_manager_test.rb
Toshi MARUYAMA
11:25 Patch #34153 (Closed): Use sum instead of inject(0, :+)
@Array#sum@ introduced in Ruby 2.4 is much faster than @Enumerable#inject@.... Go MAEDA
09:14 Feature #31500: Ruby 2.7 support
Enziin System wrote:
> Redmine run passed all tests on Ruby 2.7.2, isn't it?
Yes. Redmine on Ruby 2.7.2 passes al...
Go MAEDA
09:10 Feature #31500: Ruby 2.7 support
Ok, thanks!
In the above comment, you said "I think it is no problem to use Ruby 2.7.2 now"
Redmine run passed ...
Enziin System
08:12 Defect #34151 (Closed): Description Field is mandatory but not marked an such
> Sorry must be a local issue
Thank you for reporting that. Closing.
Go MAEDA
08:04 Defect #34151 (Resolved): Description Field is mandatory but not marked an such
Sorry must be a local issue Christian Zabanski
07:56 Defect #34151 (Closed): Description Field is mandatory but not marked an such
Christian Zabanski
04:42 Patch #34122: Store inline autocomplete data sources in a JS variable
+1
The change makes views clearner.
Go MAEDA
04:34 Revision 20155 (svn): Fix RuboCop offense Style/RedundantCapitalW due to r20154 (#34142).
Go MAEDA
04:17 Patch #34150 (Closed): Use match? instead of =~ when MatchData is not used
@String#match?@ was added in Ruby 2.4. you can replace @=~@ with faster @String#match?@ or @Regexp#match?@ when Match... Go MAEDA
 

Also available in: Atom