Redmine

2020-10-25

23:10 Defect #34167 (Closed): when i put if condition and update any field the if condition field lost data

... moustafa elbeda

10:43 Patch #34166 (Closed): Fix wrong comment for Mailer.deliver_lost_password

Fixed. Go MAEDA

10:40 Patch #34166 (Closed): Fix wrong comment for Mailer.deliver_lost_password

... Go MAEDA

08:10 Defect #8714 (Closed): mail-address parsing in app/models/mail_handler.rb (create_user_from_email) barks on names with Umlauts

Go MAEDA wrote:
> The following test works fine on Redmine 4.0. Does anyone still experience this issue?
>
>
> ... Go MAEDA

08:04 Defect #32315 (Closed): Impossible to validate API key without modifying anything

Fixed in Redmine 4.1.0 (#30086).
You can check if an API is correct or incorrect by sending GET request. The API k... Go MAEDA

07:24 Defect #33529 (Closed): New issue / updating issue email notification receiving delay....

Redmine sends out mail immediately, so I think it is a problem with the mail servers involved in the delivery. Go MAEDA

04:43 Patch #34061: Update locales for Vietnamese language

+1 Enziin System

04:10 Defect #34165 (Closed): RuboCop warns Layout/SpaceInsideBlockBraces and Layout/SpaceInsideHashLiteralBraces due to r20189 and r20190

RuboCops displays huge numbers of warnings in the latest trunk.
This is because someone changed .ruboco.yml by com... Go MAEDA

02:37 Feature #33902 (Closed): Server-Handler for GIF

Go MAEDA wrote:
> The reason for sending images with a "Content-Disposition: attachment" is to fix a security flaw "... Go MAEDA

02:01 Patch #34122 (Closed): Store inline autocomplete data sources in a JS variable

Committed the patch. Thank you. Go MAEDA

2020-10-24

10:55 Feature #33802: Sub task feature without creating a new issue

You can use Custom Workflow Plugin and Write small Ruby Code to create these items.
I use this Feature in our insta... Hans Riess

10:16 Feature #33894: Automatically set done ratio to 100% when closing a issue

Thank you for posting the patch but I think the behavior that status is set to 100% on the edit page is sometimes pro... Go MAEDA

09:41 Feature #33894: Automatically set done ratio to 100% when closing a issue

It turned out that a condition in `done_ratio_editable?` was wrong.
I have attached a fixed patch. vzvu 3k6k

10:02 Patch #16069: Allow configuration of API limit instead of hardcoding at 100

Looks good. We've wrote a patch based on Domingo Galdos' one (Patch 0001) with Juno NISHIZAKI, sanak and me on Redmin... vzvu 3k6k

08:50 Patch #34161 (Closed): Replace gsub with tr, delete, or squeeze

Committed. Go MAEDA

08:14 Patch #34161 (Closed): Replace gsub with tr, delete, or squeeze

@String#tr@, @String#delete@, and @String#squeeze@ are faster than @String#gsub@.
https://docs.rubocop.org/rubocop... Go MAEDA

07:42 Patch #34160 (Closed): Replace Hash#merge! with Hash#[]=

Done. Go MAEDA

07:24 Patch #34160 (Closed): Replace Hash#merge! with Hash#[]=

@Hash#[]=@ is faster than @Hash#merge!@.
https://docs.rubocop.org/rubocop-performance/cops_performance.html#perfor... Go MAEDA

04:19 Patch #34159 (Closed): Update RuboCop Performance to 1.10

Committed the patch. Go MAEDA

03:54 Patch #34159 (Closed): Update RuboCop Performance to 1.10

Since Redmine dropped the support for Ruby 2.3, we can update RuboCop Performance from 1.5 to 1.8.... Go MAEDA

03:41 Patch #34071: Handle AuthSourceExceptions in User.try_to_login

Setting the target version to 4.2.0. Go MAEDA

03:39 Patch #34153 (Closed): Use sum instead of inject(0, :+)

Committed the patch. Go MAEDA

2020-10-23

10:39 Patch #34071: Handle AuthSourceExceptions in User.try_to_login

The patch also fixes an issue that Redmine might return 500 error and HTML body against an API request.... Go MAEDA

08:23 Feature #15340: Custom field referencing other tickets

+1 Fabien Durand

08:22 Feature #7849: custom issue relation types

+1 Fabien Durand

03:31 Patch #32531 (Closed): Update RuboCop Rails to 2.9

Updated ruboCop Rails to 2.8 in r20172. Go MAEDA

02:55 Patch #32531 (Reopened): Update RuboCop Rails to 2.9

The latest version is 2.8.1.
https://rubygems.org/gems/rubocop-rails/versions/2.8.1
Since Redmine dropped support... Go MAEDA

02:47 Patch #32530 (Closed): Update RuboCop to 1.12

Updated RuboCop to 1.0 in r20171. Go MAEDA

02:13 Patch #34150 (Closed): Use match? instead of =~ when MatchData is not used

Committed the patch. Go MAEDA

00:04 Defect #27780: Case-insensitive matching fails for Unicode filenames when referring to attachments in text formatting

Setting the target version to 4.2.0. Go MAEDA