Redmine

2020-10-26

22:09 Defect #34165: RuboCop warns Layout/SpaceInsideBlockBraces and Layout/SpaceInsideHashLiteralBraces due to r20189 and r20190

Toshi, how do you want to proceed on this? I agree with Go Maeda, there are too many warnings in the current trunk an... Marius BĂLTEANU

22:05 Patch #16069: Allow configuration of API limit instead of hardcoding at 100

The final result of the patch series posted by vzvu 3k6k and Mizuki looks good to me and all the tests pass: https://... Marius BĂLTEANU

08:10 Patch #16069: Allow configuration of API limit instead of hardcoding at 100

vzvu 3k6k wrote:
> Go MAEDA wrote:
>
> >The user should not be able to set the value of API limit smaller than 10... Mizuki ISHIKAWA

19:38 Feature #7322: add ability to filter the activity page

+1 by Tracker
J. Pablo Zebraitis

16:39 Defect #22819: Internal Error while create new issue

Hi, Im working with version 3.0.2 with Rails 4.2.1. and resolve this problem, but I have a new problem when delete an... Martín Roberto Tolava

12:58 Defect #33881: No email notifications for status changes triggered by fixing keywords in repository commits.

Same here. I digged a little bit deeper:
When I manually trigger fetching the git commits by going to the reposito... Tobias Grimm

10:07 Defect #34167: when i put if condition and update any field the if condition field lost data

0
the issue is solved replace disable to readonly moustafa elbeda

08:49 Defect #34167: when i put if condition and update any field the if condition field lost data

when i put if statement filed note is cleared after update any field moustafa elbeda

07:39 Patch #34169 (Closed): MessagesControllerTest#test_post_new randomly fails

MessagesControllerTest # test_post_new test fails (trunk)... Mizuki ISHIKAWA

2020-10-25

23:10 Defect #34167 (Closed): when i put if condition and update any field the if condition field lost data

... moustafa elbeda

10:43 Patch #34166 (Closed): Fix wrong comment for Mailer.deliver_lost_password

Fixed. Go MAEDA

10:40 Patch #34166 (Closed): Fix wrong comment for Mailer.deliver_lost_password

... Go MAEDA

08:10 Defect #8714 (Closed): mail-address parsing in app/models/mail_handler.rb (create_user_from_email) barks on names with Umlauts

Go MAEDA wrote:
> The following test works fine on Redmine 4.0. Does anyone still experience this issue?
>
>
> ... Go MAEDA

08:04 Defect #32315 (Closed): Impossible to validate API key without modifying anything

Fixed in Redmine 4.1.0 (#30086).
You can check if an API is correct or incorrect by sending GET request. The API k... Go MAEDA

07:24 Defect #33529 (Closed): New issue / updating issue email notification receiving delay....

Redmine sends out mail immediately, so I think it is a problem with the mail servers involved in the delivery. Go MAEDA

04:43 Patch #34061: Update locales for Vietnamese language

+1 Enziin System

04:10 Defect #34165 (Closed): RuboCop warns Layout/SpaceInsideBlockBraces and Layout/SpaceInsideHashLiteralBraces due to r20189 and r20190

RuboCops displays huge numbers of warnings in the latest trunk.
This is because someone changed .ruboco.yml by com... Go MAEDA

02:37 Feature #33902 (Closed): Server-Handler for GIF

Go MAEDA wrote:
> The reason for sending images with a "Content-Disposition: attachment" is to fix a security flaw "... Go MAEDA

02:01 Patch #34122 (Closed): Store inline autocomplete data sources in a JS variable

Committed the patch. Thank you. Go MAEDA

2020-10-24

10:55 Feature #33802: Sub task feature without creating a new issue

You can use Custom Workflow Plugin and Write small Ruby Code to create these items.
I use this Feature in our insta... Hans Riess

10:16 Feature #33894: Automatically set done ratio to 100% when closing a issue

Thank you for posting the patch but I think the behavior that status is set to 100% on the edit page is sometimes pro... Go MAEDA

09:41 Feature #33894: Automatically set done ratio to 100% when closing a issue

It turned out that a condition in `done_ratio_editable?` was wrong.
I have attached a fixed patch. vzvu 3k6k

10:02 Patch #16069: Allow configuration of API limit instead of hardcoding at 100

Looks good. We've wrote a patch based on Domingo Galdos' one (Patch 0001) with Juno NISHIZAKI, sanak and me on Redmin... vzvu 3k6k

08:50 Patch #34161 (Closed): Replace gsub with tr, delete, or squeeze

Committed. Go MAEDA

08:14 Patch #34161 (Closed): Replace gsub with tr, delete, or squeeze

@String#tr@, @String#delete@, and @String#squeeze@ are faster than @String#gsub@.
https://docs.rubocop.org/rubocop... Go MAEDA

07:42 Patch #34160 (Closed): Replace Hash#merge! with Hash#[]=

Done. Go MAEDA

07:24 Patch #34160 (Closed): Replace Hash#merge! with Hash#[]=

@Hash#[]=@ is faster than @Hash#merge!@.
https://docs.rubocop.org/rubocop-performance/cops_performance.html#perfor... Go MAEDA

04:19 Patch #34159 (Closed): Update RuboCop Performance to 1.10

Committed the patch. Go MAEDA

03:54 Patch #34159 (Closed): Update RuboCop Performance to 1.10

Since Redmine dropped the support for Ruby 2.3, we can update RuboCop Performance from 1.5 to 1.8.... Go MAEDA

03:41 Patch #34071: Handle AuthSourceExceptions in User.try_to_login

Setting the target version to 4.2.0. Go MAEDA

03:39 Patch #34153 (Closed): Use sum instead of inject(0, :+)

Committed the patch. Go MAEDA