Redmine

Thanks for this patch.

breaks an existing tests (QueryTest#test_total_by_project_group_for_spent_hours), but I'm not sure how to fix the problem.

This is caused by a Rails bug that was reported here: https://github.com/rails/rails/issues/21922

The respective test have also a to do comment to remove some code after this issue is fixed (and is was fixed).

This is another issue that will also be fixed in Rails 5.

I'd prefer using a subquery when a filter is applied on version date or status rather that having to do a left join on versions for all queries. Otherwise, we'll have to wait for Rails 5.

Jean-Philippe Lang wrote:

I'd prefer using a subquery when a filter is applied on version date or status rather that having to do a left join on versions for all queries. Otherwise, we'll have to wait for Rails 5.

Thanks for your feedback, it is very useful for me. I'll update the patch next week to use subquries.

+1

We are also interested by this feature in our company, and I tried it on our test server.

It works well, but there is a remark I would like to make:
In most Redmine filters, using the "Is not" operator includes nulls in the results. For example, if you filter for Target version "is not" and select all versions (multi-selection), you will obtain the same result as with the "None" operator (that is, all not planned issues).

I have the feeling that your filters should do the same.
(something, like:
nl = operator == "!" ? "#{Issue.table_name}.fixed_version_id IS NULL OR" : ''
"(#{nl} #{sql_for_field("fixed_version_id", "=", version_ids, Issue.table_name, "fixed_version_id")})"
)

Olivier Houdas wrote:

In most Redmine filters, using the "Is not" operator includes nulls in the results. For example, if you filter for Target version "is not" and select all versions (multi-selection), you will obtain the same result as with the "None" operator (that is, all not planned issues).

1. Target Version's Status: which has the "Is not" operator but your scenario is not possible because versions with status null cannot exist in Redmine. Each version has a status: open, closed or locked.
2. Target Version's Due Date: The "Is not" operator isn't available for this filter.

Please let me know if I'm wrong.

1. "Target version "is not" (multiple selection of all versions defined) returns all issues which do not have any target version defined
2. "Target version status" "is not" "Closed" returns all issues having a target version defined, which have the open or locked status
3. "Target version due date" "none" returns all issues which have a target version defined, but for which no due date is defined

1. current behaviour of Redmine, unchanged
2. all issues with an open or locked target version PLUS all issues which do not have any target version defined
3. all issues which have a target version defined with no due date PLUS all issues not having any target version defined

I hope my remark is clearer with those two examples.
(edit: corrected my text as I had mixed two examples into one, making no sense, sorry)