Feature #23518

Move action links and edit form above the history when displaying comments in reverse order

Added by Mikhail Varabyou about 3 years ago. Updated over 1 year ago.

Status:ClosedStart date:
Priority:LowDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Issues
Target version:4.0.0
Resolution:Fixed

Description

When we switch comments to reverse chronological order `action_menu` and div#update are still below History section. This requires either scrolling to the top or to the very bottom of the page to be able to click "edit".
Is it possible to move `action_menu` and `edit` partials above div#history for User.current.wants_comments_in_reverse_order? ?

patch_01.patch Magnifier (1.64 KB) Mikhail Varabyou, 2016-08-05 12:41


Related issues

Related to Redmine - Patch #12524: Update issue - form position Closed
Related to Redmine - Defect #31438: Incorrect position of the "Associated revisions" block wh... Closed
Duplicated by Redmine - Feature #7637: Display edit form above History in reverse chronological ... Closed 2011-02-16
Duplicated by Redmine - Feature #26861: Display Issue Edit form Position according to comments ch... Closed

Associated revisions

Revision 17412
Added by Jean-Philippe Lang over 1 year ago

Move action links and edit form above the history when displaying comments in reverse order (#23518).

History

#1 Updated by JW Fuchs about 3 years ago

+1
This could be quite a useful addition to also have the buttons available right above the first history entry.

#2 Updated by Toshi MARUYAMA about 3 years ago

  • Target version set to 3.4.0

#3 Updated by Go MAEDA over 2 years ago

+1 for this feature.

I usually see comments in reverse chronological order, so I have to scroll up and down frequently when I write comment while referring to recent comments.

#4 Updated by Jean-Philippe Lang over 2 years ago

  • Target version deleted (3.4.0)

Such a change could have heavy consequences for plugins. We need much more requests for this before changing the issue view in this way.

#5 Updated by Go MAEDA over 2 years ago

  • Duplicated by Feature #7637: Display edit form above History in reverse chronological order added

#6 Updated by Yuuki NARA over 2 years ago

+1

I agree with this function.
When editing, since you often see the latest history.
Scrolling the screen long will reduce operability.

#7 Updated by Toshi MARUYAMA over 2 years ago

  • Related to Patch #12524: Update issue - form position added

#8 Updated by Go MAEDA about 2 years ago

  • Related to Feature #26861: Display Issue Edit form Position according to comments chronological order added

#9 Updated by Go MAEDA about 2 years ago

  • Related to deleted (Feature #26861: Display Issue Edit form Position according to comments chronological order)

#10 Updated by Go MAEDA about 2 years ago

  • Duplicated by Feature #26861: Display Issue Edit form Position according to comments chronological order added

#11 Updated by Tatsuya Saito about 2 years ago

+1

#12 Updated by Go MAEDA about 2 years ago

  • Target version set to 4.0.0

Jean-Philippe Lang wrote:

Such a change could have heavy consequences for plugins. We need much more requests for this before changing the issue view in this way.

We will switch to Rails 5.1 in Redmine 4.0 and it will break a large majority of plugins. So I think we don't have to consider about plugins if we deliver this feature in 4.0.0.

I am setting target version again in order to ask Jean-Phillpe Lang for judgment.

#13 Updated by Bernhard Rohloff about 2 years ago

+1

#14 Updated by rip heminway almost 2 years ago

+1

#15 Updated by Jean-Philippe Lang over 1 year ago

  • Subject changed from Display comments in reverse chronological order: position of action_menu and edit partials. to Move action links and edit form above the history when displaying comments in reverse order
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Committed, thanks.

#16 Updated by Go MAEDA 5 months ago

  • Related to Defect #31438: Incorrect position of the "Associated revisions" block when comments are displayed in reverse chronological order added

Also available in: Atom PDF